forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Re-enable test_property_type_registration() (#4419)

Browse Source 
# Objective

- This test was mysteriously commented out

## Solution

- Re-enable it
- Also done in #4299, but this is better as its own PR.
This commit is contained in:
Alice Cecile 2022-04-05 18:34:27 +00:00
parent cf831d5185
commit dbb2fcb677
1 changed files with 33 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
crates/bevy_reflect/src/type_registry.rs
View File

@ -353,6 +353,7 @@ impl<T: for<'a> Deserialize<'a> + Reflect> FromType<T> for ReflectDeserialize {
#[cfg(test)] #[cfg(test)]
mod test { mod test {
use crate::TypeRegistration; use crate::TypeRegistration;
use bevy_utils::HashMap;
#[test] #[test]
fn test_get_short_name() { fn test_get_short_name() {
@ -390,37 +391,36 @@ mod test {
); );
} }
// TODO: re-enable #[test]
// #[test] fn test_property_type_registration() {
// fn test_property_type_registration() { assert_eq!(
// assert_eq!( TypeRegistration::of::<Option<f64>>().short_name,
// TypeRegistration::of::<Option<f64>>().short_name, "Option<f64>"
// "Option<f64>" );
// ); assert_eq!(
// assert_eq!( TypeRegistration::of::<HashMap<u32, String>>().short_name,
// TypeRegistration::of::<HashMap<u32, String>>().short_name, "HashMap<u32, String>"
// "HashMap<u32, String>" );
// ); assert_eq!(
// assert_eq!( TypeRegistration::of::<Option<HashMap<u32, String>>>().short_name,
// TypeRegistration::of::<Option<HashMap<u32, String>>>().short_name, "Option<HashMap<u32, String>>"
// "Option<HashMap<u32, String>>" );
// ); assert_eq!(
// assert_eq!( TypeRegistration::of::<Option<HashMap<u32, Option<String>>>>().short_name,
// TypeRegistration::of::<Option<HashMap<u32, Option<String>>>>().short_name, "Option<HashMap<u32, Option<String>>>"
// "Option<HashMap<u32, Option<String>>>" );
// ); assert_eq!(
// assert_eq!( TypeRegistration::of::<Option<HashMap<String, Option<String>>>>().short_name,
// TypeRegistration::of::<Option<HashMap<String, Option<String>>>>().short_name, "Option<HashMap<String, Option<String>>>"
// "Option<HashMap<String, Option<String>>>" );
// ); assert_eq!(
// assert_eq!( TypeRegistration::of::<Option<HashMap<Option<String>, Option<String>>>>().short_name,
// TypeRegistration::of::<Option<HashMap<Option<String>, Option<String>>>>().short_name, "Option<HashMap<Option<String>, Option<String>>>"
// "Option<HashMap<Option<String>, Option<String>>>" );
// ); assert_eq!(
// assert_eq!( TypeRegistration::of::<Option<HashMap<Option<String>, (String, Option<String>)>>>()
// TypeRegistration::of::<Option<HashMap<Option<String>, (String, Option<String>)>>>() .short_name,
// .short_name, "Option<HashMap<Option<String>, (String, Option<String>)>>"
// "Option<HashMap<Option<String>, (String, Option<String>)>>" );
// ); }
// }
} }