forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix swapped docs for Rot2::rotation_to/from_y (#14307)

Browse Source 
# Objective

Fixes #14301 

## Solution

Swap them so that they are no longer swapped.
This commit is contained in:
Matty 2024-07-14 13:00:41 -04:00 committed by GitHub
parent b36b0230e6
commit e13c72d8a4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/bevy_math/src/direction.rs
View File

@ -229,7 +229,7 @@ impl Dir2 {
self.rotation_from_x().inverse() self.rotation_from_x().inverse()
} }
/// Get the rotation that rotates this direction to the Y-axis. /// Get the rotation that rotates the Y-axis to this direction.
#[inline] #[inline]
pub fn rotation_from_y(self) -> Rot2 { pub fn rotation_from_y(self) -> Rot2 {
// `x <- y`, `y <- -x` correspond to rotating clockwise by pi/2; // `x <- y`, `y <- -x` correspond to rotating clockwise by pi/2;
@ -238,7 +238,7 @@ impl Dir2 {
Rot2::from_sin_cos(-self.0.x, self.0.y) Rot2::from_sin_cos(-self.0.x, self.0.y)
} }
/// Get the rotation that rotates the Y-axis to this direction. /// Get the rotation that rotates this direction to the Y-axis.
#[inline] #[inline]
pub fn rotation_to_y(self) -> Rot2 { pub fn rotation_to_y(self) -> Rot2 {
self.rotation_from_y().inverse() self.rotation_from_y().inverse()