diff --git a/crates/bevy_pbr/src/light.rs b/crates/bevy_pbr/src/light.rs index 0d2efc2557..e57521da41 100644 --- a/crates/bevy_pbr/src/light.rs +++ b/crates/bevy_pbr/src/light.rs @@ -970,9 +970,7 @@ pub(crate) fn assign_lights_to_clusters( continue; } - let screen_size = if let Some(screen_size) = camera.physical_viewport_size() { - screen_size - } else { + let Some(screen_size) = camera.physical_viewport_size() else { clusters.clear(); continue; }; diff --git a/crates/bevy_reflect/bevy_reflect_derive/src/container_attributes.rs b/crates/bevy_reflect/bevy_reflect_derive/src/container_attributes.rs index a6512e15d6..1575a8adde 100644 --- a/crates/bevy_reflect/bevy_reflect_derive/src/container_attributes.rs +++ b/crates/bevy_reflect/bevy_reflect_derive/src/container_attributes.rs @@ -137,11 +137,10 @@ impl ReflectTraits { // Handles `#[reflect( Hash, Default, ... )]` NestedMeta::Meta(Meta::Path(path)) => { // Get the first ident in the path (hopefully the path only contains one and not `std::hash::Hash`) - let ident = if let Some(segment) = path.segments.iter().next() { - &segment.ident - } else { + let Some(segment) = path.segments.iter().next() else { continue; }; + let ident = &segment.ident; let ident_name = ident.to_string(); // Track the span where the trait is implemented for future errors @@ -172,12 +171,12 @@ impl ReflectTraits { // Handles `#[reflect( Hash(custom_hash_fn) )]` NestedMeta::Meta(Meta::List(list)) => { // Get the first ident in the path (hopefully the path only contains one and not `std::hash::Hash`) - let ident = if let Some(segment) = list.path.segments.iter().next() { - segment.ident.to_string() - } else { + let Some(segment) = list.path.segments.iter().next() else { continue; }; + let ident = segment.ident.to_string(); + // Track the span where the trait is implemented for future errors let span = ident.span(); diff --git a/crates/bevy_reflect/bevy_reflect_derive/src/type_uuid.rs b/crates/bevy_reflect/bevy_reflect_derive/src/type_uuid.rs index 1a1485dd07..d030731ab9 100644 --- a/crates/bevy_reflect/bevy_reflect_derive/src/type_uuid.rs +++ b/crates/bevy_reflect/bevy_reflect_derive/src/type_uuid.rs @@ -24,9 +24,7 @@ pub(crate) fn type_uuid_derive(input: proc_macro::TokenStream) -> proc_macro::To let mut uuid = None; for attribute in ast.attrs.iter().filter_map(|attr| attr.parse_meta().ok()) { - let name_value = if let Meta::NameValue(name_value) = attribute { - name_value - } else { + let Meta::NameValue(name_value) = attribute else { continue; }; diff --git a/crates/bevy_reflect/src/enums/helpers.rs b/crates/bevy_reflect/src/enums/helpers.rs index c14913d19d..d1ea359f8d 100644 --- a/crates/bevy_reflect/src/enums/helpers.rs +++ b/crates/bevy_reflect/src/enums/helpers.rs @@ -26,9 +26,7 @@ pub fn enum_hash(value: &TEnum) -> Option { #[inline] pub fn enum_partial_eq(a: &TEnum, b: &dyn Reflect) -> Option { // Both enums? - let b = if let ReflectRef::Enum(e) = b.reflect_ref() { - e - } else { + let ReflectRef::Enum(b) = b.reflect_ref() else { return Some(false); }; diff --git a/crates/bevy_reflect/src/list.rs b/crates/bevy_reflect/src/list.rs index f98ac0f4be..965bdcb663 100644 --- a/crates/bevy_reflect/src/list.rs +++ b/crates/bevy_reflect/src/list.rs @@ -324,9 +324,7 @@ pub fn list_apply(a: &mut L, b: &dyn Reflect) { /// Returns [`None`] if the comparison couldn't even be performed. #[inline] pub fn list_partial_eq(a: &L, b: &dyn Reflect) -> Option { - let list = if let ReflectRef::List(list) = b.reflect_ref() { - list - } else { + let ReflectRef::List(list) = b.reflect_ref() else { return Some(false); }; diff --git a/crates/bevy_reflect/src/map.rs b/crates/bevy_reflect/src/map.rs index c2b89d2bee..bbccdb73ac 100644 --- a/crates/bevy_reflect/src/map.rs +++ b/crates/bevy_reflect/src/map.rs @@ -371,9 +371,7 @@ impl<'a> ExactSizeIterator for MapIter<'a> {} /// Returns [`None`] if the comparison couldn't even be performed. #[inline] pub fn map_partial_eq(a: &M, b: &dyn Reflect) -> Option { - let map = if let ReflectRef::Map(map) = b.reflect_ref() { - map - } else { + let ReflectRef::Map(map) = b.reflect_ref() else { return Some(false); }; diff --git a/crates/bevy_reflect/src/struct_trait.rs b/crates/bevy_reflect/src/struct_trait.rs index 71736d5c5e..e4dfdf72d4 100644 --- a/crates/bevy_reflect/src/struct_trait.rs +++ b/crates/bevy_reflect/src/struct_trait.rs @@ -480,9 +480,7 @@ impl Typed for DynamicStruct { /// Returns [`None`] if the comparison couldn't even be performed. #[inline] pub fn struct_partial_eq(a: &S, b: &dyn Reflect) -> Option { - let struct_value = if let ReflectRef::Struct(struct_value) = b.reflect_ref() { - struct_value - } else { + let ReflectRef::Struct(struct_value) = b.reflect_ref() else { return Some(false); }; diff --git a/crates/bevy_reflect/src/tuple.rs b/crates/bevy_reflect/src/tuple.rs index 785dab118b..f3b1968df5 100644 --- a/crates/bevy_reflect/src/tuple.rs +++ b/crates/bevy_reflect/src/tuple.rs @@ -396,9 +396,7 @@ pub fn tuple_apply(a: &mut T, b: &dyn Reflect) { /// Returns [`None`] if the comparison couldn't even be performed. #[inline] pub fn tuple_partial_eq(a: &T, b: &dyn Reflect) -> Option { - let b = if let ReflectRef::Tuple(tuple) = b.reflect_ref() { - tuple - } else { + let ReflectRef::Tuple(b) = b.reflect_ref() else { return Some(false); }; diff --git a/crates/bevy_reflect/src/tuple_struct.rs b/crates/bevy_reflect/src/tuple_struct.rs index d27d4934fc..3069cb5ea0 100644 --- a/crates/bevy_reflect/src/tuple_struct.rs +++ b/crates/bevy_reflect/src/tuple_struct.rs @@ -381,9 +381,7 @@ impl Typed for DynamicTupleStruct { /// Returns [`None`] if the comparison couldn't even be performed. #[inline] pub fn tuple_struct_partial_eq(a: &S, b: &dyn Reflect) -> Option { - let tuple_struct = if let ReflectRef::TupleStruct(tuple_struct) = b.reflect_ref() { - tuple_struct - } else { + let ReflectRef::TupleStruct(tuple_struct) = b.reflect_ref() else { return Some(false); }; diff --git a/crates/bevy_render/macros/src/as_bind_group.rs b/crates/bevy_render/macros/src/as_bind_group.rs index 30888a5227..4c8a2b14b2 100644 --- a/crates/bevy_render/macros/src/as_bind_group.rs +++ b/crates/bevy_render/macros/src/as_bind_group.rs @@ -116,9 +116,7 @@ pub fn derive_as_bind_group(ast: syn::DeriveInput) -> Result { // Read field-level attributes for field in fields.iter() { for attr in &field.attrs { - let attr_ident = if let Some(ident) = attr.path.get_ident() { - ident - } else { + let Some(attr_ident) = attr.path.get_ident() else { continue; }; diff --git a/crates/bevy_render/src/camera/camera_driver_node.rs b/crates/bevy_render/src/camera/camera_driver_node.rs index 9cf23c106f..224e61e787 100644 --- a/crates/bevy_render/src/camera/camera_driver_node.rs +++ b/crates/bevy_render/src/camera/camera_driver_node.rs @@ -78,9 +78,7 @@ impl Node for CameraDriverNode { continue; } - let swap_chain_texture = if let Some(swap_chain_texture) = &window.swap_chain_texture { - swap_chain_texture - } else { + let Some(swap_chain_texture) = &window.swap_chain_texture else { continue; }; diff --git a/crates/bevy_render/src/texture/basis.rs b/crates/bevy_render/src/texture/basis.rs index 45240c2290..b404c4d386 100644 --- a/crates/bevy_render/src/texture/basis.rs +++ b/crates/bevy_render/src/texture/basis.rs @@ -20,9 +20,7 @@ pub fn basis_buffer_to_image( return Err(TextureError::InvalidData("Invalid header".to_string())); } - let image0_info = if let Some(image_info) = transcoder.image_info(buffer, 0) { - image_info - } else { + let Some(image0_info) = transcoder.image_info(buffer, 0) else { return Err(TextureError::InvalidData( "Failed to get image info".to_string(), )); diff --git a/crates/bevy_ui/src/render/render_pass.rs b/crates/bevy_ui/src/render/render_pass.rs index 16164c61a5..527e96538f 100644 --- a/crates/bevy_ui/src/render/render_pass.rs +++ b/crates/bevy_ui/src/render/render_pass.rs @@ -54,10 +54,9 @@ impl Node for UiPassNode { ) -> Result<(), NodeRunError> { let input_view_entity = graph.get_input_entity(Self::IN_VIEW)?; - let (transparent_phase, target, camera_ui) = - if let Ok(result) = self.ui_view_query.get_manual(world, input_view_entity) { - result - } else { + let Ok((transparent_phase, target, camera_ui)) = + self.ui_view_query.get_manual(world, input_view_entity) + else { return Ok(()); }; if transparent_phase.items.is_empty() { diff --git a/crates/bevy_winit/src/lib.rs b/crates/bevy_winit/src/lib.rs index 131c0ea28f..831020323a 100644 --- a/crates/bevy_winit/src/lib.rs +++ b/crates/bevy_winit/src/lib.rs @@ -398,9 +398,7 @@ pub fn winit_runner_with(mut app: App) { return; }; - let window = if let Some(window) = windows.get_mut(window_id) { - window - } else { + let Some(window) = windows.get_mut(window_id) else { // If we're here, this window was previously opened info!("Skipped event for closed window: {:?}", window_id); return; diff --git a/examples/games/contributors.rs b/examples/games/contributors.rs index 8194a0fed1..b7f74ecce1 100644 --- a/examples/games/contributors.rs +++ b/examples/games/contributors.rs @@ -248,9 +248,7 @@ fn collision_system( windows: Res, mut query: Query<(&mut Velocity, &mut Transform), With>, ) { - let window = if let Some(window) = windows.get_primary() { - window - } else { + let Some(window) = windows.get_primary() else { return; };