From eca7924bb44fdf28664f5ae82dea7ea4e44f08b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois?= Date: Sat, 23 Dec 2023 18:36:24 +0100 Subject: [PATCH] finish cleaning up dependency bans job (#11059) # Objective - After #10151, cache check is less useful in dependency ban job - It fails anyway because the steps are not in the right order ## Solution - Remove the added steps --- .github/workflows/dependencies.yml | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/.github/workflows/dependencies.yml b/.github/workflows/dependencies.yml index c8f11c16bf..424f2354c7 100644 --- a/.github/workflows/dependencies.yml +++ b/.github/workflows/dependencies.yml @@ -29,36 +29,11 @@ jobs: check-bans: runs-on: ubuntu-latest steps: - # on main, prepare a new cargo tree output and cache it - - name: On main, prepare new cargo tree cache - if: github.ref == 'refs/heads/main' - run: cargo tree --depth 3 > cargo-tree-from-main - - name: On main, save the new cargo tree cache - if: github.ref == 'refs/heads/main' - uses: actions/cache/save@v3 - with: - path: cargo-tree-from-main - key: cargo-tree-from-main - # on other branch, restore the cached cargo tree output - - name: On PR, restore cargo tree cache - uses: actions/cache/restore@v3 - if: github.ref != 'refs/heads/main' - with: - path: cargo-tree-from-main - key: cargo-tree-from-main - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - # if not on main, check that the cargo tree output is unchanged - - name: Check if the cargo tree changed from main - if: github.ref != 'refs/heads/main' - continue-on-error: true - id: cargo-tree-changed - run: diff cargo-tree-from-main <(cargo tree --depth 3) - name: Install cargo-deny run: cargo install cargo-deny - # if the check was not a success (either skipped because on main or failed because of a change), run the check - name: Check for banned and duplicated dependencies - if: steps.cargo-tree-changed.outcome != 'success' run: cargo deny check bans check-licenses: