From f201a9df39d0485b73d33c243b977e5f40b6a7eb Mon Sep 17 00:00:00 2001 From: Jannik Obermann <50554200+jannik4@users.noreply.github.com> Date: Fri, 31 Mar 2023 10:15:21 +0200 Subject: [PATCH] Fix CubicCurve::iter_samples iteration count (#8049) # Objective Fix `CubicCurve::iter_samples` iteration count. ## Solution If I understand the function and the docs correctly, this should iterate over `0..=subdivisions` instead of `0..subdivisions`. For example: Now the iteration returns 3 points at `subdivisions = 2`, as indicated in the documentation. --- crates/bevy_math/src/cubic_splines.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/bevy_math/src/cubic_splines.rs b/crates/bevy_math/src/cubic_splines.rs index d6779f0e0f..bb5a988557 100644 --- a/crates/bevy_math/src/cubic_splines.rs +++ b/crates/bevy_math/src/cubic_splines.rs @@ -483,7 +483,7 @@ impl CubicCurve

{ subdivisions: usize, sample_function: fn(&Self, f32) -> P, ) -> impl Iterator + '_ { - (0..subdivisions).map(move |i| { + (0..=subdivisions).map(move |i| { let segments = self.segments.len() as f32; let t = i as f32 / subdivisions as f32 * segments; sample_function(self, t)