From f61c55fd906edd24c3b25eb7915023d25ae21f78 Mon Sep 17 00:00:00 2001 From: IcyLeave6109 <33421921+juliohq@users.noreply.github.com> Date: Wed, 15 May 2024 23:22:50 -0300 Subject: [PATCH] Allow shapes to be constructed with zero values (#13365) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Objective Fixes #13332. ## Solution The assertion `circumradius >= 0.0` to allow zero. Are there any other shapes that need to be allowed to be constructed with zero? --------- Co-authored-by: François Mockers --- crates/bevy_math/src/primitives/dim2.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/crates/bevy_math/src/primitives/dim2.rs b/crates/bevy_math/src/primitives/dim2.rs index eaedb9c099..c69491fac2 100644 --- a/crates/bevy_math/src/primitives/dim2.rs +++ b/crates/bevy_math/src/primitives/dim2.rs @@ -723,10 +723,13 @@ impl RegularPolygon { /// /// # Panics /// - /// Panics if `circumradius` is non-positive + /// Panics if `circumradius` is negative #[inline(always)] pub fn new(circumradius: f32, sides: usize) -> Self { - assert!(circumradius > 0.0, "polygon has a non-positive radius"); + assert!( + circumradius.is_sign_positive(), + "polygon has a negative radius" + ); assert!(sides > 2, "polygon has less than 3 sides"); Self {