From f7fbfaf9c72035e98c6b6cec0c7d26ff9f5b1c82 Mon Sep 17 00:00:00 2001 From: JoJoJet <21144246+JoJoJet@users.noreply.github.com> Date: Sun, 12 Feb 2023 19:15:44 +0000 Subject: [PATCH] Rename an outdated benchmark from "run criteria" to "run condition" (#7645) # Objective The benchmark for run conditions still uses the outdated terminology "run criteria". ## Solution Update the name. --- benches/benches/bevy_ecs/scheduling/mod.rs | 12 ++++++------ .../{run_criteria.rs => run_condition.rs} | 16 ++++++++-------- 2 files changed, 14 insertions(+), 14 deletions(-) rename benches/benches/bevy_ecs/scheduling/{run_criteria.rs => run_condition.rs} (88%) diff --git a/benches/benches/bevy_ecs/scheduling/mod.rs b/benches/benches/bevy_ecs/scheduling/mod.rs index 7a1ef42b05..2d0529696b 100644 --- a/benches/benches/bevy_ecs/scheduling/mod.rs +++ b/benches/benches/bevy_ecs/scheduling/mod.rs @@ -1,19 +1,19 @@ use criterion::criterion_group; -mod run_criteria; +mod run_condition; mod running_systems; mod schedule; -use run_criteria::*; +use run_condition::*; use running_systems::*; use schedule::*; criterion_group!( scheduling_benches, - run_criteria_yes, - run_criteria_no, - run_criteria_yes_with_query, - run_criteria_yes_with_resource, + run_condition_yes, + run_condition_no, + run_condition_yes_with_query, + run_condition_yes_with_resource, empty_systems, busy_systems, contrived, diff --git a/benches/benches/bevy_ecs/scheduling/run_criteria.rs b/benches/benches/bevy_ecs/scheduling/run_condition.rs similarity index 88% rename from benches/benches/bevy_ecs/scheduling/run_criteria.rs rename to benches/benches/bevy_ecs/scheduling/run_condition.rs index d185654cf6..be6f25a4c7 100644 --- a/benches/benches/bevy_ecs/scheduling/run_criteria.rs +++ b/benches/benches/bevy_ecs/scheduling/run_condition.rs @@ -11,9 +11,9 @@ fn no() -> bool { false } -pub fn run_criteria_yes(criterion: &mut Criterion) { +pub fn run_condition_yes(criterion: &mut Criterion) { let mut world = World::new(); - let mut group = criterion.benchmark_group("run_criteria/yes"); + let mut group = criterion.benchmark_group("run_condition/yes"); group.warm_up_time(std::time::Duration::from_millis(500)); group.measurement_time(std::time::Duration::from_secs(3)); fn empty() {} @@ -39,9 +39,9 @@ pub fn run_criteria_yes(criterion: &mut Criterion) { group.finish(); } -pub fn run_criteria_no(criterion: &mut Criterion) { +pub fn run_condition_no(criterion: &mut Criterion) { let mut world = World::new(); - let mut group = criterion.benchmark_group("run_criteria/no"); + let mut group = criterion.benchmark_group("run_condition/no"); group.warm_up_time(std::time::Duration::from_millis(500)); group.measurement_time(std::time::Duration::from_secs(3)); fn empty() {} @@ -70,10 +70,10 @@ pub fn run_criteria_no(criterion: &mut Criterion) { #[derive(Component, Resource)] struct TestBool(pub bool); -pub fn run_criteria_yes_with_query(criterion: &mut Criterion) { +pub fn run_condition_yes_with_query(criterion: &mut Criterion) { let mut world = World::new(); world.spawn(TestBool(true)); - let mut group = criterion.benchmark_group("run_criteria/yes_using_query"); + let mut group = criterion.benchmark_group("run_condition/yes_using_query"); group.warm_up_time(std::time::Duration::from_millis(500)); group.measurement_time(std::time::Duration::from_secs(3)); fn empty() {} @@ -102,10 +102,10 @@ pub fn run_criteria_yes_with_query(criterion: &mut Criterion) { group.finish(); } -pub fn run_criteria_yes_with_resource(criterion: &mut Criterion) { +pub fn run_condition_yes_with_resource(criterion: &mut Criterion) { let mut world = World::new(); world.insert_resource(TestBool(true)); - let mut group = criterion.benchmark_group("run_criteria/yes_using_resource"); + let mut group = criterion.benchmark_group("run_condition/yes_using_resource"); group.warm_up_time(std::time::Duration::from_millis(500)); group.measurement_time(std::time::Duration::from_secs(3)); fn empty() {}