forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename an outdated benchmark from "run criteria" to "run condition" (#7645)

Browse Source 
# Objective

The benchmark for run conditions still uses the outdated terminology "run criteria".

## Solution

Update the name.
This commit is contained in:
JoJoJet 2023-02-12 19:15:44 +00:00
parent eaac730617
commit f7fbfaf9c7
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
benches/benches/bevy_ecs/scheduling/mod.rs
View File

@ -1,19 +1,19 @@
use criterion::criterion_group; use criterion::criterion_group;
mod run_criteria; mod run_condition;
mod running_systems; mod running_systems;
mod schedule; mod schedule;
use run_criteria::*; use run_condition::*;
use running_systems::*; use running_systems::*;
use schedule::*; use schedule::*;
criterion_group!( criterion_group!(
scheduling_benches, scheduling_benches,
run_criteria_yes, run_condition_yes,
run_criteria_no, run_condition_no,
run_criteria_yes_with_query, run_condition_yes_with_query,
run_criteria_yes_with_resource, run_condition_yes_with_resource,
empty_systems, empty_systems,
busy_systems, busy_systems,
contrived, contrived,

16
benches/benches/bevy_ecs/scheduling/run_criteria.rs → benches/benches/bevy_ecs/scheduling/run_condition.rs
View File

@ -11,9 +11,9 @@ fn no() -> bool {
false false
} }
pub fn run_criteria_yes(criterion: &mut Criterion) { pub fn run_condition_yes(criterion: &mut Criterion) {
let mut world = World::new(); let mut world = World::new();
let mut group = criterion.benchmark_group("run_criteria/yes"); let mut group = criterion.benchmark_group("run_condition/yes");
group.warm_up_time(std::time::Duration::from_millis(500)); group.warm_up_time(std::time::Duration::from_millis(500));
group.measurement_time(std::time::Duration::from_secs(3)); group.measurement_time(std::time::Duration::from_secs(3));
fn empty() {} fn empty() {}
@ -39,9 +39,9 @@ pub fn run_criteria_yes(criterion: &mut Criterion) {
group.finish(); group.finish();
} }
pub fn run_criteria_no(criterion: &mut Criterion) { pub fn run_condition_no(criterion: &mut Criterion) {
let mut world = World::new(); let mut world = World::new();
let mut group = criterion.benchmark_group("run_criteria/no"); let mut group = criterion.benchmark_group("run_condition/no");
group.warm_up_time(std::time::Duration::from_millis(500)); group.warm_up_time(std::time::Duration::from_millis(500));
group.measurement_time(std::time::Duration::from_secs(3)); group.measurement_time(std::time::Duration::from_secs(3));
fn empty() {} fn empty() {}
@ -70,10 +70,10 @@ pub fn run_criteria_no(criterion: &mut Criterion) {
#[derive(Component, Resource)] #[derive(Component, Resource)]
struct TestBool(pub bool); struct TestBool(pub bool);
pub fn run_criteria_yes_with_query(criterion: &mut Criterion) { pub fn run_condition_yes_with_query(criterion: &mut Criterion) {
let mut world = World::new(); let mut world = World::new();
world.spawn(TestBool(true)); world.spawn(TestBool(true));
let mut group = criterion.benchmark_group("run_criteria/yes_using_query"); let mut group = criterion.benchmark_group("run_condition/yes_using_query");
group.warm_up_time(std::time::Duration::from_millis(500)); group.warm_up_time(std::time::Duration::from_millis(500));
group.measurement_time(std::time::Duration::from_secs(3)); group.measurement_time(std::time::Duration::from_secs(3));
fn empty() {} fn empty() {}
@ -102,10 +102,10 @@ pub fn run_criteria_yes_with_query(criterion: &mut Criterion) {
group.finish(); group.finish();
} }
pub fn run_criteria_yes_with_resource(criterion: &mut Criterion) { pub fn run_condition_yes_with_resource(criterion: &mut Criterion) {
let mut world = World::new(); let mut world = World::new();
world.insert_resource(TestBool(true)); world.insert_resource(TestBool(true));
let mut group = criterion.benchmark_group("run_criteria/yes_using_resource"); let mut group = criterion.benchmark_group("run_condition/yes_using_resource");
group.warm_up_time(std::time::Duration::from_millis(500)); group.warm_up_time(std::time::Duration::from_millis(500));
group.measurement_time(std::time::Duration::from_secs(3)); group.measurement_time(std::time::Duration::from_secs(3));
fn empty() {} fn empty() {}