Commit Graph

5 Commits

Author SHA1 Message Date
François Mockers
4cd014384f
action shouldn't comment on a pr if last comment is from action (#18196)
# Objective

- While a PR is in work, if several commits fail and trigger a comment
from the action, this can create a lot of comments from actions with low
value
- Noticed on https://github.com/bevyengine/bevy/pull/18139

## Solution

- If last comment on a PR is from an action, don't add a new comment

---------

Co-authored-by: Martín Maita <47983254+mnmaita@users.noreply.github.com>
2025-03-09 20:26:19 +00:00
François Mockers
8f85d4e598
rendering regression: mention in pr comment that the solution could be to update the pr (#18153)
# Objective

- When a PR gets merged that modifies the rendering screenshots, the
main reference will be updated
- Every in-flight PR will then "fail" rendering change detection as they
come from an outdated main branch

## Solution

- Suggest updating the PR to the latest main branch
2025-03-07 00:18:24 +00:00
Alice Cecile
3be01c4d0f
Fix label name for Deliberate-Rendering-Change CI (#18118)
# Objective

The label added in #18064 is the wrong color! It should be an `M-`
(meta) label, not an `S-` (status) label!

## Solution

- Rename the label in the comment that gets left to
`M-Deliberate-Rendering-Change`
- Also make the job check for the right label 🤦🏽‍♀️ 

Once this is approved and ready to merge, I'll rename the label on
Github to match.
2025-03-02 22:54:54 +00:00
François Mockers
0122b85cc3
comment on PR when example job finds changes (#18064)
# Objective

- Comment on PR when getting a rendering change

## Solution

- When something changes in the rendering check CI, add a comment on the
PR to check the results
- Suggest adding the label `S-Deliberate-Rendering-Change` if it's
expected
- Don't comment if the label is already present

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
2025-02-27 22:46:10 +00:00
François Mockers
2f633c18ba
Split example runs to their own GitHub workflow (#18039)
# Objective

- next step for #15918 

## Solution

- Move jobs for macOS, Linux and Windows to their own workflow
- Remove running on push to `main` from workflows CI and validation
2025-02-25 23:30:31 +00:00