8d143e3ed8
272 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Lixou
|
a5c4606a98
|
Fix Welcome Contributors CI (#15123)
# Objective Fixes #15121 (hopefully, just read the docs, don't know how to test this tho) ## Solution Adds write permissions for pull-requests, see https://docs.github.com/en/rest/issues/comments?apiVersion=2022-11-28#create-an-issue-comment--fine-grained-access-tokens for more information. |
||
|
dependabot[bot]
|
ccb8854ec1
|
Bump peter-evans/create-pull-request from 6 to 7 (#15112)
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6 to 7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases">peter-evans/create-pull-request's releases</a>.</em></p> <blockquote> <h2>Create Pull Request v7.0.0</h2> <p>✨ Now supports commit signing with bot-generated tokens! See "What's new" below. ✍️🤖</p> <h3>Behaviour changes</h3> <ul> <li>Action input <code>git-token</code> has been renamed <code>branch-token</code>, to be more clear about its purpose. The <code>branch-token</code> is the token that the action will use to create and update the branch.</li> <li>The action now handles requests that have been rate-limited by GitHub. Requests hitting a primary rate limit will retry twice, for a total of three attempts. Requests hitting a secondary rate limit will not be retried.</li> <li>The <code>pull-request-operation</code> output now returns <code>none</code> when no operation was executed.</li> <li>Removed deprecated output environment variable <code>PULL_REQUEST_NUMBER</code>. Please use the <code>pull-request-number</code> action output instead.</li> </ul> <h3>What's new</h3> <ul> <li>The action can now sign commits as <code>github-actions[bot]</code> when using <code>GITHUB_TOKEN</code>, or your own bot when using <a href="https://github.com/peter-evans/create-pull-request/blob/HEAD/docs/concepts-guidelines.md#authenticating-with-github-app-generated-tokens">GitHub App tokens</a>. See <a href="https://github.com/peter-evans/create-pull-request/blob/HEAD/docs/concepts-guidelines.md#commit-signature-verification-for-bots">commit signing</a> for details.</li> <li>Action input <code>draft</code> now accepts a new value <code>always-true</code>. This will set the pull request to draft status when the pull request is updated, as well as on creation.</li> <li>A new action input <code>maintainer-can-modify</code> indicates whether <a href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork">maintainers can modify</a> the pull request. The default is <code>true</code>, which retains the existing behaviour of the action.</li> <li>A new output <code>pull-request-commits-verified</code> returns <code>true</code> or <code>false</code>, indicating whether GitHub considers the signature of the branch's commits to be verified.</li> </ul> <h2>What's Changed</h2> <ul> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.36 to 18.19.39 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3000">peter-evans/create-pull-request#3000</a></li> <li>build(deps-dev): bump ts-jest from 29.1.5 to 29.2.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3008">peter-evans/create-pull-request#3008</a></li> <li>build(deps-dev): bump prettier from 3.3.2 to 3.3.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3018">peter-evans/create-pull-request#3018</a></li> <li>build(deps-dev): bump ts-jest from 29.2.0 to 29.2.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3019">peter-evans/create-pull-request#3019</a></li> <li>build(deps-dev): bump eslint-plugin-prettier from 5.1.3 to 5.2.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3035">peter-evans/create-pull-request#3035</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.39 to 18.19.41 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3037">peter-evans/create-pull-request#3037</a></li> <li>build(deps): bump undici from 6.19.2 to 6.19.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3036">peter-evans/create-pull-request#3036</a></li> <li>build(deps-dev): bump ts-jest from 29.2.2 to 29.2.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3038">peter-evans/create-pull-request#3038</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.41 to 18.19.42 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3070">peter-evans/create-pull-request#3070</a></li> <li>build(deps): bump undici from 6.19.4 to 6.19.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3086">peter-evans/create-pull-request#3086</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.42 to 18.19.43 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3087">peter-evans/create-pull-request#3087</a></li> <li>build(deps-dev): bump ts-jest from 29.2.3 to 29.2.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3088">peter-evans/create-pull-request#3088</a></li> <li>build(deps): bump undici from 6.19.5 to 6.19.7 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3145">peter-evans/create-pull-request#3145</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.43 to 18.19.44 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3144">peter-evans/create-pull-request#3144</a></li> <li>Update distribution by <a href="https://github.com/actions-bot"><code>@actions-bot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3154">peter-evans/create-pull-request#3154</a></li> <li>build(deps): bump undici from 6.19.7 to 6.19.8 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3213">peter-evans/create-pull-request#3213</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.44 to 18.19.45 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3214">peter-evans/create-pull-request#3214</a></li> <li>Update distribution by <a href="https://github.com/actions-bot"><code>@actions-bot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3221">peter-evans/create-pull-request#3221</a></li> <li>build(deps-dev): bump eslint-import-resolver-typescript from 3.6.1 to 3.6.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3255">peter-evans/create-pull-request#3255</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.45 to 18.19.46 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3254">peter-evans/create-pull-request#3254</a></li> <li>build(deps-dev): bump ts-jest from 29.2.4 to 29.2.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3256">peter-evans/create-pull-request#3256</a></li> <li>v7 - signed commits by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3057">peter-evans/create-pull-request#3057</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/rustycl0ck"><code>@rustycl0ck</code></a> made their first contribution in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3057">peter-evans/create-pull-request#3057</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v6.1.0...v7.0.0">https://github.com/peter-evans/create-pull-request/compare/v6.1.0...v7.0.0</a></p> <h2>Create Pull Request v6.1.0</h2> <p>✨ Adds <code>pull-request-branch</code> as an action output.</p> <h2>What's Changed</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
eaa87b8c34
|
Bump crate-ci/typos from 1.24.3 to 1.24.5 (#15111)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.24.3 to 1.24.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.24.5</h2> <h2>[1.24.5] - 2024-09-04</h2> <h3>Features</h3> <ul> <li><em>(action)</em> Support windows</li> </ul> <h2>v1.24.4</h2> <h2>[1.24.4] - 2024-09-03</h2> <h3>Fixes</h3> <ul> <li>Offer a correction for <code>grather</code></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.24.5] - 2024-09-04</h2> <h3>Features</h3> <ul> <li><em>(action)</em> Support windows</li> </ul> <h2>[1.24.4] - 2024-09-03</h2> <h3>Fixes</h3> <ul> <li>Offer a correction for <code>grather</code></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Martín Maita
|
32f40f11b5
|
Bump crate-ci/typos from 1.24.1 to 1.24.3 (#15024)
# Objective - Adopts #15015 ## Solution - Fixed a typo that broke the build and prevented updating `crate-ci/typos`. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> |
||
|
dependabot[bot]
|
965c6970ff
|
Bump crate-ci/typos from 1.23.6 to 1.24.1 (#14922)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.23.6 to 1.24.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.24.1</h2> <h2>[1.24.1] - 2024-08-23</h2> <h3>Fixes</h3> <ul> <li>Remove unverified varcon (locale data) entries</li> </ul> <h2>v1.24.0</h2> <h2>[1.24.0] - 2024-08-23</h2> <h3>Features</h3> <ul> <li>Update varcon (locale data) to version 2020.12.07</li> </ul> <h2>v1.23.7</h2> <h2>[1.23.7] - 2024-08-22</h2> <h3>Fixes</h3> <ul> <li><em>(config)</em> Respect <code>--locale</code> / <code>default.locale</code> again after it was broken in 1.16.24</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.24.1] - 2024-08-23</h2> <h3>Fixes</h3> <ul> <li>Remove unverified varcon (locale data) entries</li> </ul> <h2>[1.24.0] - 2024-08-23</h2> <h3>Features</h3> <ul> <li>Update varcon (locale data) to version 2020.12.07</li> </ul> <h2>[1.23.7] - 2024-08-22</h2> <h3>Fixes</h3> <ul> <li><em>(config)</em> Respect <code>--locale</code> / <code>default.locale</code> again after it was broken in 1.16.24</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
TrialDragon
|
9054d9dacb
|
Deprecate old contributing documentation / information (#14885)
# Objective Fixes #14884 We have launched the new [contributing guide](https://bevyengine.org/learn/contribute/introduction) on Bevy's website, so these sources of information should be removed to avoid syncing across duplicate files and maintaining a single source of truth on contributing. ## Solution ### Remove the files: - `docs/release_checklist.md`. - `docs/the_bevy_organization.md`. - `.github/contributing/engine_style_guide.md`. - `.github/contributing/example_style_guide.md`. #### These are replaced by: - `https://bevyengine.org/learn/contribute/project-information/release-process/`. - `https://bevyengine.org/learn/contribute/project-information/bevy-organization/`. - `https://bevyengine.org/learn/contribute/helping-out/opening-pull-requests/#style-guide`. - `https://bevyengine.org/learn/contribute/helping-out/creating-examples/#style-guide` ### Make `CONTRIBUTING.md` re-direct to Bevy's website's Contributing Guide `https://bevyengine.org/learn/contribute/introduction` ### Change the contributing guide link in `welcome.yml` workflow to link to Bevy's website's Contributing Guide `https://bevyengine.org/learn/contribute/introduction` ## Testing I looked at the markdown files in my repository's branch to make sure they look fine. I have not tested the `welcome.yml` workflow since I don't know how, without having a new contributor make a PR to my branch. --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> |
||
|
BD103
|
2012f13c05
|
Document private items in dev-docs (#14769)
# Objective - The [developer docs](https://dev-docs.bevyengine.org) are primarily used by developers, who often deal with internal and private functions. - @mweatherley suggested [on Discord](https://discord.com/channels/691052431525675048/743559241461399582/1273658470134186112) that CI passes `--document-private-items` to the dev-docs, so contributors can easily browse these internal details. ## Solution - Add `--document-private-items` to the CI job that builds the dev-docs. ## Testing - It should run in CI and generate documentation for private code. ## Drawbacks - Users that track the main branch may use the dev-docs instead of <https://docs.rs/bevy>, which may now show a lot of unwanted internal details. - Searching may be slower / bloated with internal details. |
||
|
Tau Gärtli
|
a34651502c
|
Sync flags in docs.yml with package.metadata.docs.rs (#14734)
# Objective This PR is a follow-up to #14703. I forgot to also add the flags from `package.metadata.docs.rs` to the docs build. ## Solution As [discussed on Discord](https://discord.com/channels/691052431525675048/1272629407659589663/1272643734260940940), I added the missing flags to `docs.yml`. I also updated `rustc-args` to properly make use of the array (I think the value has to be either a space-separated string *or* an array of strings but not an array of space-separated strings 😆) |
||
|
dependabot[bot]
|
fc2f564c6f
|
Bump crate-ci/typos from 1.23.5 to 1.23.6 (#14626)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.23.5 to 1.23.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.23.6</h2> <h2>[1.23.6] - 2024-07-31</h2> <h3>Fixes</h3> <ul> <li>Updated the dictionary with the <a href="https://redirect.github.com/crate-ci/typos/issues/1051">July 2024</a> changes</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.23.6] - 2024-07-31</h2> <h3>Fixes</h3> <ul> <li>Updated the dictionary with the <a href="https://redirect.github.com/crate-ci/typos/issues/1051">July 2024</a> changes</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Jan Hohenheim
|
6f7c554daa
|
Fix common capitalization errors in documentation (#14562)
WASM -> Wasm MacOS -> macOS Nothing important, just something that annoyed me for a while :) |
||
|
Giacomo Stevanato
|
adb4709d08
|
Fix CI after #12965 (#14527)
# Objective - In #12965 I broke CI (sorry!) - The command was tested locally, but somehow the yaml formatting messed it up - I hate yaml ## Solution - It should now use the correct formatting - I hope - I wish there was a straightforward way to test github actions locally |
||
|
Giacomo Stevanato
|
71c5f1e3e4
|
Generate links to definition in source code pages on docs.rs and dev-docs.bevyengine.org (#12965)
# Objective - Fix issue #2611 ## Solution - Add `--generate-link-to-definition` to all the `rustdoc-args` arrays in the `Cargo.toml`s (for docs.rs) - Add `--generate-link-to-definition` to the `RUSTDOCFLAGS` environment variable in the docs workflow (for dev-docs.bevyengine.org) - Document all the workspace crates in the docs workflow (needed because otherwise only the source code of the `bevy` package will be included, making the argument useless) - I think this also fixes #3662, since it fixes the bug on dev-docs.bevyengine.org, while on docs.rs it has been fixed for a while on their side. --- ## Changelog - The source code viewer on docs.rs now includes links to the definitions. |
||
|
dependabot[bot]
|
ca3d8e8760
|
Bump crate-ci/typos from 1.23.2 to 1.23.5 (#14514)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.23.2 to 1.23.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.23.5</h2> <h2>[1.23.5] - 2024-07-25</h2> <h3>Features</h3> <ul> <li><em>(config)</em> Store config in <code>Cargo.toml</code></li> </ul> <h2>v1.23.4</h2> <h2>[1.23.4] - 2024-07-25</h2> <h3>Fixes</h3> <ul> <li>Don't correct <code>countr_one</code> in C++</li> </ul> <h2>v1.23.3</h2> <h2>[1.23.3] - 2024-07-22</h2> <h3>Fixes</h3> <ul> <li>Fix <code>Dockerfile</code></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.23.5] - 2024-07-25</h2> <h3>Features</h3> <ul> <li><em>(config)</em> Store config in <code>Cargo.toml</code></li> </ul> <h2>[1.23.4] - 2024-07-25</h2> <h3>Fixes</h3> <ul> <li>Don't correct <code>countr_one</code> in C++</li> </ul> <h2>[1.23.3] - 2024-07-22</h2> <h3>Fixes</h3> <ul> <li>Fix <code>Dockerfile</code></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
François Mockers
|
3a880b5c30
|
remove check-cfg job (#14477)
# Objective - Fixes #13268 ## Solution - Remove the job as it's now part of rust stable https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#checked-cfg-names-and-values |
||
|
Thierry Berger
|
26fc4c7198
|
Test for ambiguous system ordering in CI (#13950)
Progress towards https://github.com/bevyengine/bevy/issues/7386. Following discussion https://discord.com/channels/691052431525675048/1253260494538539048/1253387942311886960 This Pull Request adds an example to detect system order ambiguities, and also asserts none exist. A lot of schedules are ignored in ordered to have the test passing, we should thrive to make them pass, but in other pull requests. <details><summary>example output <b>summary</b>, without ignored schedules</summary> <p> ```txt $ cargo run --example ambiguity_detection 2>&1 | grep -C 1 "pairs of syst" 2024-06-21T13:17:55.776585Z WARN bevy_ecs::schedule::schedule: Schedule First has ambiguities. 1 pairs of systems with conflicting data access have indeterminate execution order. Consider adding `before`, `after`, or `ambiguous_with` relationships between these: -- bevy_time::time_system (in set TimeSystem) and bevy_ecs::event::event_update_system (in set EventUpdates) -- 2024-06-21T13:17:55.782265Z WARN bevy_ecs::schedule::schedule: Schedule PreUpdate has ambiguities. 11 pairs of systems with conflicting data access have indeterminate execution order. Consider adding `before`, `after`, or `ambiguous_with` relationships between these: -- bevy_pbr::prepass::update_mesh_previous_global_transforms and bevy_asset::server::handle_internal_asset_events -- 2024-06-21T13:17:55.809516Z WARN bevy_ecs::schedule::schedule: Schedule PostUpdate has ambiguities. 63 pairs of systems with conflicting data access have indeterminate execution order. Consider adding `before`, `after`, or `ambiguous_with` relationships between these: -- bevy_ui::accessibility::image_changed and bevy_ecs::schedule::executor::apply_deferred -- 2024-06-21T13:17:55.816287Z WARN bevy_ecs::schedule::schedule: Schedule Last has ambiguities. 3 pairs of systems with conflicting data access have indeterminate execution order. Consider adding `before`, `after`, or `ambiguous_with` relationships between these: -- bevy_gizmos::update_gizmo_meshes<bevy_gizmos::aabb::AabbGizmoConfigGroup> (in set UpdateGizmoMeshes) and bevy_gizmos::update_gizmo_meshes<bevy_gizmos::light::LightGizmoConfigGroup> (in set UpdateGizmoMeshes) -- 2024-06-21T13:17:55.831074Z WARN bevy_ecs::schedule::schedule: Schedule ExtractSchedule has ambiguities. 296 pairs of systems with conflicting data access have indeterminate execution order. Consider adding `before`, `after`, or `ambiguous_with` relationships between these: -- bevy_render::extract_component::extract_components<bevy_sprite::SpriteSource> and bevy_render::render_asset::extract_render_asset<bevy_sprite::mesh2d::material::PreparedMaterial2d<bevy_sprite::mesh2d::color_material::ColorMaterial>> ``` </p> </details> To try locally: ```sh CI_TESTING_CONFIG="./.github/example-run/ambiguity_detection.ron" cargo run --example ambiguity_detection --features "bevy_ci_testing,trace,trace_chrome" ``` --------- Co-authored-by: Jan Hohenheim <jan@hohenheim.ch> |
||
|
Brezak
|
293e91564b
|
Fix the dev docs robots.txt containing a literal \n instead of a newline (#14347)
# Objective The robots.txt file for the [dev docs](https://dev-docs.bevyengine.org) looks like this `User-Agent: *\nDisallow: /` It should look like this ``` User-Agent: * Disallow: / ``` ## Solution Use [`ANSI-C`](https://www.gnu.org/software/bash/manual/bash.html#ANSI_002dC-Quoting) quoting to properly handle the `\n` ## Testing - [x] Run the fixed echo command in local terminal. - [ ] Wait for the dev doces to deploy and observe if the mistake has been fixed |
||
|
dependabot[bot]
|
d57531a900
|
Bump crate-ci/typos from 1.23.1 to 1.23.2 (#14324)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.23.1 to 1.23.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.23.2</h2> <h2>[1.23.2] - 2024-07-10</h2> <h3>Features</h3> <ul> <li>Automatically ignore JWT tokens</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.23.2] - 2024-07-10</h2> <h3>Features</h3> <ul> <li>Automatically ignore JWT tokens</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Blake Bedford
|
2414311079
|
Fixed #14248 and other URL issues (#14276)
# Objective Fixes #14248 and other URL issues. ## Solution - Describe the solution used to achieve the objective above. Removed the random #s in the URL. Led users to the wrong page. For example, https://bevyengine.org/learn/errors/#b0003 takes users to https://bevyengine.org/learn/errors/introduction, which is not the right page. Removing the #s fixes it. ## Testing - Did you test these changes? If so, how? I pasted the URL into my address bar and it took me to the right place. - Are there any parts that need more testing? No |
||
|
dependabot[bot]
|
81ecfcd208
|
Bump crate-ci/typos from 1.22.9 to 1.23.1 (#14217)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.9 to 1.23.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.23.1</h2> <h2>[1.23.1] - 2024-07-05</h2> <h3>Fixes</h3> <ul> <li>Add missing <a href="https://redirect.github.com/crate-ci/typos/issues/1024">June 2024</a> changes</li> </ul> <h2>v1.23.0</h2> <h2>[1.23.0] - 2024-07-05</h2> <h3>Fixes</h3> <ul> <li>Updated the dictionary with the <a href="https://redirect.github.com/crate-ci/typos/issues/1024">June 2024</a> changes</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.23.1] - 2024-07-05</h2> <h3>Fixes</h3> <ul> <li>Add missing <a href="https://redirect.github.com/crate-ci/typos/issues/1024">June 2024</a> changes</li> </ul> <h2>[1.23.0] - 2024-07-05</h2> <h3>Fixes</h3> <ul> <li>Updated the dictionary with the <a href="https://redirect.github.com/crate-ci/typos/issues/1024">June 2024</a> changes</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
François Mockers
|
2553c3ade8
|
prepare next version: update regexes (#14170)
# Objective - The post release version bump job failed: https://github.com/bevyengine/bevy/actions/runs/9799332118 - This is because main didn't update to 0.14 as that happened in a branch ## Solution - Update the regexes to work with the -dev suffix --------- Co-authored-by: Jan Hohenheim <jan@hohenheim.ch> |
||
|
Gino Valente
|
2968d4121b
|
meta: Add Showcase section to PR template (#11750)
# Objective Oftentimes I find myself reading through a PR and not quite understanding what's going on. Even if it's super detailed, it can sometimes be difficult to imagine what the end result of the PR might look like. For example, #10756 clearly communicates its goals and contains a descriptive Changelog. However, I was still a bit lost as to what a user might see from the change until I saw the dedicated example in the diff. ## Solution At the risk of giving contributors more work, I think a dedicated `Showcase` section could be really nice. Along with providing reviewers stumbling on the PR with a "tangible summary" of the change, it should also help out when working on the release post. Sometimes someone other than the PR's author has to write up a blog section on the PR. This can be somewhat daunting to people wanting to contribute in that effort as they have to rely on the Migration Guide giving a decent example (assuming it's a breaking change), piecing together the other sections into a sensible example themselves, or manually reading through the diff. Theoretically, this new `Showcase` section would be more of an encouragement than a strict requirement. And it's probably only going to be useful where there is something to showcase (e.g. visual changes, API changes, new features, etc.). ### Bikeshedding - **Naming.** I also considered `Demo` and `Example`, but there may be others we prefer. I chose `Showcase` to communicate the feeling of fun and appreciation for the work contributors put in. - **Position.** I placed the section right above the `Changelog` section since I felt it made sense to move from the details in `Solution` to a brief example in `Showcase` to a tl;dr of the changes in `Changelog` - **Phrasing.** We can also bikeshed the bullet points and phrasing of each as well. |
||
|
François Mockers
|
63fd8fbae5
|
Windows CI example runner: back to using rust stable (#13863)
- Revert #13834 once wgpu released the fix for https://github.com/gfx-rs/wgpu/pull/5812 |
||
|
dependabot[bot]
|
c500228227
|
Bump crate-ci/typos from 1.22.7 to 1.22.9 (#13997)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.7 to 1.22.9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.22.9</h2> <h2>[1.22.9] - 2024-06-22</h2> <h3>Fixes</h3> <ul> <li>Stop correcting <code>reoccurrence</code></li> </ul> <h2>v1.22.8</h2> <h2>[1.22.8] - 2024-06-21</h2> <h3>Features</h3> <ul> <li><em>(action)</em> Add Arm, Mac support</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.22.9] - 2024-06-22</h2> <h3>Fixes</h3> <ul> <li>Stop correcting <code>reoccurrence</code></li> </ul> <h2>[1.22.8] - 2024-06-21</h2> <h3>Features</h3> <ul> <li><em>(action)</em> Add Arm, Mac support</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
13f9b6993d
|
Bump crate-ci/typos from 1.22.3 to 1.22.7 (#13890)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.3 to 1.22.7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.22.7</h2> <h2>[1.22.7] - 2024-06-12</h2> <h3>Fixes</h3> <ul> <li>Remove Linux arm64 binary support</li> </ul> <h2>v1.22.6</h2> <h2>[1.22.6] - 2024-06-12</h2> <h2>v1.22.5</h2> <h2>[1.22.5] - 2024-06-12</h2> <h3>Features</h3> <ul> <li>Linux arm64 binaries</li> </ul> <h2>v1.22.4</h2> <h2>[1.22.4] - 2024-06-10</h2> <ul> <li>Correct adventerous as adventurous instead of adventures</li> <li>Correct manifestion as manifestation instead of manifesto</li> <li>Correct manifestior as manifestation instead of manifesto</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.22.7] - 2024-06-12</h2> <h3>Fixes</h3> <ul> <li>Remove Linux arm64 binary support</li> </ul> <h2>[1.22.6] - 2024-06-12</h2> <h2>[1.22.5] - 2024-06-12</h2> <h3>Features</h3> <ul> <li>Linux arm64 binaries</li> </ul> <h2>[1.22.4] - 2024-06-10</h2> <h3>Fixes</h3> <ul> <li>Correct adventerous as adventurous instead of adventures</li> <li>Correct manifestion as manifestation instead of manifesto</li> <li>Correct manifestior as manifestation instead of manifesto</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
François Mockers
|
14fdec674d
|
run windows ci on rust 1.78 (#13834)
# Objective - temporary fix for CI - Rust 1.79 seems to have broken bevy on DX12 on some configuration ## Solution - Keep using Rust 1.78 |
||
|
dependabot[bot]
|
3478d158cc
|
Bump crate-ci/typos from 1.21.0 to 1.22.3 (#13786)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.21.0 to 1.22.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.22.3</h2> <h2>[1.22.3] - 2024-06-07</h2> <h3>Fixes</h3> <ul> <li>Don't correct <code>arbitral</code></li> </ul> <h2>v1.22.2</h2> <h2>[1.22.2] - 2024-06-07</h2> <h2>v1.22.1</h2> <h2>[1.22.1] - 2024-06-05</h2> <ul> <li>In golang, <code>flate</code> is a valid term from the stdlib</li> </ul> <h2>v1.22.0</h2> <h2>[1.22.0] - 2024-06-03</h2> <h3>Fixes</h3> <ul> <li>Updated the dictionary with the <a href="https://redirect.github.com/crate-ci/typos/issues/1007">May 2024</a> changes</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.22.3] - 2024-06-07</h2> <h3>Fixes</h3> <ul> <li>Don't correct <code>arbitral</code></li> </ul> <h2>[1.22.2] - 2024-06-07</h2> <h2>[1.22.1] - 2024-06-05</h2> <ul> <li>In golang, <code>flate</code> is a valid term from the stdlib</li> </ul> <h2>[1.22.0] - 2024-06-03</h2> <h3>Fixes</h3> <ul> <li>Updated the dictionary with the <a href="https://redirect.github.com/crate-ci/typos/issues/1007">May 2024</a> changes</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
François Mockers
|
ecdd1624f3
|
Document the Release Candidate process (#13718)
# Objective - Document how to release a RC ## Solution - Also allow CI to trigger on release branches |
||
|
Brezak
|
2a799ef6ae
|
Update release workflow pr body (#13274)
# Objective With #13245 merged ui tests no longer specify dependency versions. ## Solution Revert the change to `release.yml` made in #12810 as it's no longer required. ## Testing - Merge. - Wait for a release. - Observe the release PR body. cc @BD103 |
||
|
BD103
|
2f87bb8c1f
|
Don't deploy docs when working on a fork (#13278)
# Objective - Some developers enable Github Actions for their fork and commit directly to main. This triggers the `docs.yml` action, which attempts to deploy the documentation even if Github Pages is not enabled. (It also creates a `CNAME` file specific to Bevy and should not be used in forks, even for testing.) - For an example, see [this run](https://github.com/tychedelia/bevy/actions/runs/8978912060/job/24660082729). ## Solution - Only attempt to deploy docs when running from the main Bevy repository. - This does not affect us checking `cargo doc` on pull requests, since that it done in `ci.yml`. ## Testing It's difficult to test this, but you'd probably: 1. Fork Bevy 2. Cherry pick this PR's commits onto the main branch of your fork. 3. Push another commit to the main branch, triggering Github Actions. 4. Check the Github Actions job summary to ensure that the `build-and-deploy` job is skipped. |
||
|
dependabot[bot]
|
30cda2351f
|
Bump crate-ci/typos from 1.20.10 to 1.21.0 (#13256)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.20.10 to 1.21.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.21.0</h2> <h2>[1.21.0] - 2024-04-30</h2> <h3>Fixes</h3> <ul> <li>Updated the dictionary with the <a href="https://redirect.github.com/crate-ci/typos/issues/956">April 2024</a> changes</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.21.0] - 2024-04-30</h2> <h3>Fixes</h3> <ul> <li>Updated the dictionary with the <a href="https://redirect.github.com/crate-ci/typos/issues/956">April 2024</a> changes</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
François Mockers
|
fd4589d8df
|
new format for ci config file (#13154)
# Objective - Current config file is hard to extend ## Solution - Instead of an hard coded list of field, the file now has a list of `(frame, event)`, and will deal with know events (exiting or taking a screenshot), or send an event for others that can be dealt by third party plugins |
||
|
NiseVoid
|
abddbf2d95
|
Add Testing section to the PR template (#13166)
# Objective - Reviews could go smoother if reviewers know how a PR was tested, how they can test it, and if it needs more testing. ## Solution - Add a testing section |
||
|
dependabot[bot]
|
dae9e5407e
|
Bump crate-ci/typos from 1.20.9 to 1.20.10 (#13131)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.20.9 to 1.20.10. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.20.10</h2> <h2>[1.20.10] - 2024-04-23</h2> <h3>Fixes</h3> <ul> <li>Don't correct <code>doas</code>, the OpenBSD command</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.20.10] - 2024-04-23</h2> <h3>Fixes</h3> <ul> <li>Don't correct <code>doas</code>, the OpenBSD command</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Brezak
|
9d59e52bb0
|
Switch to ui_test in compile fail tests. (#12810)
# Objective Make compile fail tests less likely to break with new Rust versions. Closes #12627 ## Solution Switch from [`trybuild`](https://github.com/dtolnay/trybuild) to [`ui_test`](https://github.com/oli-obk/ui_test). ## TODO - [x] Update `bevy_ecs_compile_fail_tests` - [x] Update `bevy_macros_compile_fail_tests` - [x] Update `bevy_reflect_compile_fail_tests` --------- Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de> Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com> |
||
|
François Mockers
|
dcbdae003f
|
install rust target for arm ios simulator (#13077)
# Objective - GitHub action running iOS CI has been updated to use arm runner - This makes iOS test fail as it's not installing the correct rust target ## Solution - add the correct rust target, do not remove x86 targets for now as it may be some time for a partial rollout |
||
|
BD103
|
fcd87b2528
|
Small CI improvements (#13060)
# Objective - Some CI jobs specifically use `macos-14`, as compared to the default `macos-latest`. - `macos-latest` is equivalent to `macos-12`, but may be updated in the future. - The CI job that tests on the minimum supported Rust version (MSRV) uses environmental variables to save the toolchain version. - This specific usage is what step outputs were designed for. - Both do the same thing, but step outputs can be checked by the [Github Actions VSCode Extension](https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions). - Some workflows have a `NIGHTLY_TOOLCHAIN` variable that let us pin the nightly version, in case a new release breaks CI. ## Solution - Document why certain actions required `macos-14`. - Switch MSRV step to use step outputs. - Add a small comment documenting the purpose of the `NIGHTLY_TOOLCHAIN` environmental variable. |
||
|
Rob Parrett
|
e1ee6af275
|
Improve output of example showcase patches CI workflow (#12609)
# Objective Fixes #12539 Improve [this CI output](https://github.com/bevyengine/bevy/actions/runs/8367408952/job/22909715870#step:7:11). ## Solution - Don't stop after the first failure. - Print the filename of the patch(es) that failed. - Clean up an unused package install while we're at it. Tested over here: https://github.com/rparrett/bevy/pull/20 --------- Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com> |
||
|
dependabot[bot]
|
473577621d
|
Bump crate-ci/typos from 1.20.8 to 1.20.9 (#13061)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.20.8 to 1.20.9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.20.9</h2> <h2>[1.20.9] - 2024-04-16</h2> <h3>Fixes</h3> <ul> <li>Don't correct the unit <code>dBA</code> (as an identifier to limit to that case)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.20.9] - 2024-04-16</h2> <h3>Fixes</h3> <ul> <li>Don't correct the unit <code>dBA</code> (as an identifier to limit to that case)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
BD103
|
e9fb82ae7f
|
Remove unused nightly toolchain environmental variable (#13037)
# Objective - Many of our CI workflows contain a `NIGHTLY_TOOLCHAIN` environmental variable. - This specifies which nightly to use. If there is a bug in one of the nightlies, we can pin the toolchain to be an earlier version. - Both the daily and weekly workflows do not use the nightly compiler, but still have a `NIGHTLY_TOOLCHAIN` variable. ## Solution - Delete the unused variable. |
||
|
dependabot[bot]
|
409e409ee6
|
Bump crate-ci/typos from 1.20.4 to 1.20.8 (#12972)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.20.4 to 1.20.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.20.8</h2> <h2>[1.20.8] - 2024-04-12</h2> <h3>Fixes</h3> <ul> <li>Don't correct <code>kms</code></li> <li>Don't correct <code>inout</code></li> </ul> <h2>v1.20.7</h2> <h2>[1.20.7] - 2024-04-09</h2> <h3>Fixes</h3> <ul> <li>Treat <code>.pyi</code> files as Python</li> </ul> <h2>v1.20.6</h2> <h2>[1.20.6] - 2024-04-09</h2> <h3>Fixes</h3> <ul> <li>Don't correct <code>automations</code></li> </ul> <h2>v1.20.5</h2> <h2>[1.20.5] - 2024-04-09</h2> <h3>Fixes</h3> <ul> <li>Don't correct <code>hd</code></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.20.8] - 2024-04-12</h2> <h3>Fixes</h3> <ul> <li>Don't correct <code>kms</code></li> <li>Don't correct <code>inout</code></li> </ul> <h2>[1.20.7] - 2024-04-09</h2> <h3>Fixes</h3> <ul> <li>Treat <code>.pyi</code> files as Python</li> </ul> <h2>[1.20.6] - 2024-04-09</h2> <h3>Fixes</h3> <ul> <li>Don't correct <code>automations</code></li> </ul> <h2>[1.20.5] - 2024-04-09</h2> <h3>Fixes</h3> <ul> <li>Don't correct <code>hd</code></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
BD103
|
380b35cee6
|
Create custom action for installing Linux dependencies (#12850)
# Objective
- There are several occurrences where different actions install alsa,
udev, and various other libraries for Linux.
- This is repetitive and can be an issue if the dependencies required by
Bevy ever change.
## Solution
- Create a custom action for installing Linux dependencies.
- It can be used by adding `- uses:
./.github/actions/install-linux-deps`.
- It supports configuring which libraries are installed using the `with`
property.
- It does nothing if not run on Linux, so workflows don't need to worry
about adding `if: ${{ runner.os == 'linux' }}`.
## Discussion
- The only instance where this action is not used cleanly is for the
`run-examples-linux-vulkan` verification job. I need to investigate
further the flags and dependencies that it installs.
|
||
|
Brezak
|
627ad6d2cc
|
Fix strings not interpolating in weely ci run (#12906)
# Objective Fix invalid links in weekly CI workflow. ## Solution Replace env vars with direct evaluation. |
||
|
Martín Maita
|
3fc0c6869d
|
Bump crate-ci/typos from 1.19.0 to 1.20.4 (#12907)
# Objective - Adopting https://github.com/bevyengine/bevy/pull/12903. ## Solution - Bump crate-ci/typos from 1.19.0 to 1.20.4. - Fixed a typo in `crates/bevy_pbr/src/render/pbr_functions.wgsl` file. - Added "PNG", "iy" and "SME" as exceptions to prevent false positives. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> |
||
|
Brezak
|
9790c02e18
|
Fix wrong dependency in weekly ci (#12832)
# Objective Weekly Ci fails with a `Invalid workflow error` ## Solution Make `check-compiles` depend on a job that actually exists. |
||
|
Brezak
|
ec7755dcce
|
Check CI against Rust beta each week (#12763)
# Objective Get an early warning if any new rust lints will break CI. Closes #12625 ## Solution Test the main branch against the Rust beta every week. ## Additional Possibilities The action currently creates an issue if anything fails. The issue could use a label like `C-Weekly` but somebody with the ability to create issue labels would have to add it. Another possibility would be to use discord webhooks. That would need somebody with the access to create webhooks on discord and somebody with the rights to connect that webhook to this repo, |
||
|
Ian Kettlewell
|
b35974010b
|
Get Bevy building for WebAssembly with multithreading (#12205)
# Objective This gets Bevy building on Wasm when the `atomics` flag is enabled. This does not yet multithread Bevy itself, but it allows Bevy users to use a crate like `wasm_thread` to spawn their own threads and manually parallelize work. This is a first step towards resolving #4078 . Also fixes #9304. This provides a foothold so that Bevy contributors can begin to think about multithreaded Wasm's constraints and Bevy can work towards changes to get the engine itself multithreaded. Some flags need to be set on the Rust compiler when compiling for Wasm multithreading. Here's what my build script looks like, with the correct flags set, to test out Bevy examples on web: ```bash set -e RUSTFLAGS='-C target-feature=+atomics,+bulk-memory,+mutable-globals' \ cargo build --example breakout --target wasm32-unknown-unknown -Z build-std=std,panic_abort --release wasm-bindgen --out-name wasm_example \ --out-dir examples/wasm/target \ --target web target/wasm32-unknown-unknown/release/examples/breakout.wasm devserver --header Cross-Origin-Opener-Policy='same-origin' --header Cross-Origin-Embedder-Policy='require-corp' --path examples/wasm ``` A few notes: 1. `cpal` crashes immediately when the `atomics` flag is set. That is patched in https://github.com/RustAudio/cpal/pull/837, but not yet in the latest crates.io release. That can be temporarily worked around by patching Cpal like so: ```toml [patch.crates-io] cpal = { git = "https://github.com/RustAudio/cpal" } ``` 2. When testing out `wasm_thread` you need to enable the `es_modules` feature. ## Solution The largest obstacle to compiling Bevy with `atomics` on web is that `wgpu` types are _not_ Send and Sync. Longer term Bevy will need an approach to handle that, but in the near term Bevy is already configured to be single-threaded on web. Therefor it is enough to wrap `wgpu` types in a `send_wrapper::SendWrapper` that _is_ Send / Sync, but panics if accessed off the `wgpu` thread. --- ## Changelog - `wgpu` types that are not `Send` are wrapped in `send_wrapper::SendWrapper` on Wasm + 'atomics' - CommandBuffers are not generated in parallel on Wasm + 'atomics' ## Questions - Bevy should probably add CI checks to make sure this doesn't regress. Should that go in this PR or a separate PR? **Edit:** Added checks to build Wasm with atomics --------- Co-authored-by: François <mockersf@gmail.com> Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: daxpedda <daxpedda@gmail.com> Co-authored-by: François <francois.mockers@vleue.com> |
||
|
Ame
|
72c51cdab9
|
Make feature(doc_auto_cfg) work (#12642)
# Objective - In #12366 `![cfg_attr(docsrs, feature(doc_auto_cfg))] `was added. But to apply it it needs `--cfg=docsrs` in rustdoc-args. ## Solution - Apply `--cfg=docsrs` to all crates and CI. I also added `[package.metadata.docs.rs]` to all crates to avoid adding code behind a feature and forget adding the metadata. Before:  After:  |
||
|
François Mockers
|
39385be635
|
check that patches are not broken (#12457)
# Objective - Fixes #12441 - check that patches are still working ## Solution - Apply all patches then build Bevy |
||
|
François Mockers
|
d0f24aa902
|
Update funding link (#12425)
# Objective - Link to the donate page of the foundation ## Solution - Link to the donate page of the foundation |
||
|
dependabot[bot]
|
34a02d957d
|
Bump crate-ci/typos from 1.18.2 to 1.19.0 (#12291)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.18.2 to 1.19.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p> <blockquote> <h2>v1.19.0</h2> <h2>[1.19.0] - 2024-03-01</h2> <h3>Fixes</h3> <ul> <li>Updated the dictionary with the <a href="https://redirect.github.com/crate-ci/typos/issues/921">February 2024</a> changes</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/blob/master/CHANGELOG.md">crate-ci/typos's changelog</a>.</em></p> <blockquote> <h2>[1.19.0] - 2024-03-01</h2> <h3>Fixes</h3> <ul> <li>Updated the dictionary with the <a href="https://redirect.github.com/crate-ci/typos/issues/921">February 2024</a> changes</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |