History

Kanabenki 025e8e639c Fix `Ord` and `PartialOrd` differing for `FloatOrd` and optimize implementation (#12711 ) # Objective - `FloatOrd` currently has a different comparison behavior between its derived `PartialOrd` impl and manually implemented `Ord` impl (The [`Ord` doc](https://doc.rust-lang.org/std/cmp/trait.Ord.html) says this is a logic error). This might be a problem for some `std` containers/algorithms if they rely on both matching, and a footgun for Bevy users. ## Solution - Replace the `PartialEq` and `Ord` impls of `FloatOrd` with some equivalent ones producing [better assembly.](https://godbolt.org/z/jaWbjnMKx) - Manually derive `PartialOrd` with the same behavior as `Ord`, implement the comparison operators. - Add some tests. I first tried using a match-based implementation similar to the `PartialOrd` impl [of the std](https://doc.rust-lang.org/src/core/cmp.rs.html#1457) (with added NaN ordering) but I couldn't get it to produce non-branching assembly. The current implementation is based on [the one from the `ordered_float` crate](`3641f59e31/src/lib.rs (L121)`), adapted since it uses a different ordering. Should this be mentionned somewhere in the code? --- ## Changelog ### Fixed - `FloatOrd` now uses the same ordering for its `PartialOrd` and `Ord` implementations. ## Migration Guide - If you were depending on the `PartialOrd` behaviour of `FloatOrd`, it has changed from matching `f32` to matching `FloatOrd`'s `Ord` ordering, never returning `None`.		2024-03-27 00:26:56 +00:00
..
macros	Make `feature(doc_auto_cfg)` work (#12642 )	2024-03-23 02:22:52 +00:00
src	Fix `Ord` and `PartialOrd` differing for `FloatOrd` and optimize implementation (#12711 )	2024-03-27 00:26:56 +00:00
Cargo.toml	Make `feature(doc_auto_cfg)` work (#12642 )	2024-03-23 02:22:52 +00:00
Readme.md	add and fix shields in Readmes (#9993 )	2023-10-15 00:52:31 +00:00

Readme.md

Bevy Utils

A Collection of Utilities for the Bevy Engine.