 a64446b77e
			
		
	
	
		a64446b77e
		
			
		
	
	
	
	
		
			
			# Objective - Contributes to #16877 ## Solution - Initial creation of `bevy_platform_support` crate. - Moved `bevy_utils::Instant` into new `bevy_platform_support` crate. - Moved `portable-atomic`, `portable-atomic-util`, and `critical-section` into new `bevy_platform_support` crate. ## Testing - CI --- ## Showcase Instead of needing code like this to import an `Arc`: ```rust #[cfg(feature = "portable-atomic")] use portable_atomic_util::Arc; #[cfg(not(feature = "portable-atomic"))] use alloc::sync::Arc; ``` We can now use: ```rust use bevy_platform_support::sync::Arc; ``` This applies to many other types, but the goal is overall the same: allowing crates to use `std`-like types without the boilerplate of conditional compilation and platform-dependencies. ## Migration Guide - Replace imports of `bevy_utils::Instant` with `bevy_platform_support::time::Instant` - Replace imports of `bevy::utils::Instant` with `bevy::platform_support::time::Instant` ## Notes - `bevy_platform_support` hasn't been reserved on `crates.io` - ~~`bevy_platform_support` is not re-exported from `bevy` at this time. It may be worthwhile exporting this crate, but I am unsure of a reasonable name to export it under (`platform_support` may be a bit wordy for user-facing).~~ - I've included an implementation of `Instant` which is suitable for `no_std` platforms that are not Wasm for the sake of eliminating feature gates around its use. It may be a controversial inclusion, so I'm happy to remove it if required. - There are many other items (`spin`, `bevy_utils::Sync(Unsafe)Cell`, etc.) which should be added to this crate. I have kept the initial scope small to demonstrate utility without making this too unwieldy. --------- Co-authored-by: TimJentzsch <TimJentzsch@users.noreply.github.com> Co-authored-by: Chris Russell <8494645+chescock@users.noreply.github.com> Co-authored-by: François Mockers <francois.mockers@vleue.com>
		
			
				
	
	
		
			132 lines
		
	
	
		
			3.6 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			132 lines
		
	
	
		
			3.6 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
| use crate::{
 | |
|     attributes::{impl_custom_attribute_methods, CustomAttributes},
 | |
|     type_info::impl_type_methods,
 | |
|     MaybeTyped, PartialReflect, Type, TypeInfo, TypePath,
 | |
| };
 | |
| use bevy_platform_support::sync::Arc;
 | |
| 
 | |
| /// The named field of a reflected struct.
 | |
| #[derive(Clone, Debug)]
 | |
| pub struct NamedField {
 | |
|     name: &'static str,
 | |
|     type_info: fn() -> Option<&'static TypeInfo>,
 | |
|     ty: Type,
 | |
|     custom_attributes: Arc<CustomAttributes>,
 | |
|     #[cfg(feature = "documentation")]
 | |
|     docs: Option<&'static str>,
 | |
| }
 | |
| 
 | |
| impl NamedField {
 | |
|     /// Create a new [`NamedField`].
 | |
|     pub fn new<T: PartialReflect + MaybeTyped + TypePath>(name: &'static str) -> Self {
 | |
|         Self {
 | |
|             name,
 | |
|             type_info: T::maybe_type_info,
 | |
|             ty: Type::of::<T>(),
 | |
|             custom_attributes: Arc::new(CustomAttributes::default()),
 | |
|             #[cfg(feature = "documentation")]
 | |
|             docs: None,
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     /// Sets the docstring for this field.
 | |
|     #[cfg(feature = "documentation")]
 | |
|     pub fn with_docs(self, docs: Option<&'static str>) -> Self {
 | |
|         Self { docs, ..self }
 | |
|     }
 | |
| 
 | |
|     /// Sets the custom attributes for this field.
 | |
|     pub fn with_custom_attributes(self, custom_attributes: CustomAttributes) -> Self {
 | |
|         Self {
 | |
|             custom_attributes: Arc::new(custom_attributes),
 | |
|             ..self
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     /// The name of the field.
 | |
|     pub fn name(&self) -> &'static str {
 | |
|         self.name
 | |
|     }
 | |
| 
 | |
|     /// The [`TypeInfo`] of the field.
 | |
|     ///
 | |
|     ///
 | |
|     /// Returns `None` if the field does not contain static type information,
 | |
|     /// such as for dynamic types.
 | |
|     pub fn type_info(&self) -> Option<&'static TypeInfo> {
 | |
|         (self.type_info)()
 | |
|     }
 | |
| 
 | |
|     impl_type_methods!(ty);
 | |
| 
 | |
|     /// The docstring of this field, if any.
 | |
|     #[cfg(feature = "documentation")]
 | |
|     pub fn docs(&self) -> Option<&'static str> {
 | |
|         self.docs
 | |
|     }
 | |
| 
 | |
|     impl_custom_attribute_methods!(self.custom_attributes, "field");
 | |
| }
 | |
| 
 | |
| /// The unnamed field of a reflected tuple or tuple struct.
 | |
| #[derive(Clone, Debug)]
 | |
| pub struct UnnamedField {
 | |
|     index: usize,
 | |
|     type_info: fn() -> Option<&'static TypeInfo>,
 | |
|     ty: Type,
 | |
|     custom_attributes: Arc<CustomAttributes>,
 | |
|     #[cfg(feature = "documentation")]
 | |
|     docs: Option<&'static str>,
 | |
| }
 | |
| 
 | |
| impl UnnamedField {
 | |
|     pub fn new<T: PartialReflect + MaybeTyped + TypePath>(index: usize) -> Self {
 | |
|         Self {
 | |
|             index,
 | |
|             type_info: T::maybe_type_info,
 | |
|             ty: Type::of::<T>(),
 | |
|             custom_attributes: Arc::new(CustomAttributes::default()),
 | |
|             #[cfg(feature = "documentation")]
 | |
|             docs: None,
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     /// Sets the docstring for this field.
 | |
|     #[cfg(feature = "documentation")]
 | |
|     pub fn with_docs(self, docs: Option<&'static str>) -> Self {
 | |
|         Self { docs, ..self }
 | |
|     }
 | |
| 
 | |
|     /// Sets the custom attributes for this field.
 | |
|     pub fn with_custom_attributes(self, custom_attributes: CustomAttributes) -> Self {
 | |
|         Self {
 | |
|             custom_attributes: Arc::new(custom_attributes),
 | |
|             ..self
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     /// Returns the index of the field.
 | |
|     pub fn index(&self) -> usize {
 | |
|         self.index
 | |
|     }
 | |
| 
 | |
|     /// The [`TypeInfo`] of the field.
 | |
|     ///
 | |
|     ///
 | |
|     /// Returns `None` if the field does not contain static type information,
 | |
|     /// such as for dynamic types.
 | |
|     pub fn type_info(&self) -> Option<&'static TypeInfo> {
 | |
|         (self.type_info)()
 | |
|     }
 | |
| 
 | |
|     impl_type_methods!(ty);
 | |
| 
 | |
|     /// The docstring of this field, if any.
 | |
|     #[cfg(feature = "documentation")]
 | |
|     pub fn docs(&self) -> Option<&'static str> {
 | |
|         self.docs
 | |
|     }
 | |
| 
 | |
|     impl_custom_attribute_methods!(self.custom_attributes, "field");
 | |
| }
 |