bevy/crates
Zachary Harrold 0403948aa2
Remove Implicit std Prelude from no_std Crates (#17086)
# Background

In `no_std` compatible crates, there is often an `std` feature which
will allow access to the standard library. Currently, with the `std`
feature _enabled_, the
[`std::prelude`](https://doc.rust-lang.org/std/prelude/index.html) is
implicitly imported in all modules. With the feature _disabled_, instead
the [`core::prelude`](https://doc.rust-lang.org/core/prelude/index.html)
is implicitly imported. This creates a subtle and pervasive issue where
`alloc` items _may_ be implicitly included (if `std` is enabled), or
must be explicitly included (if `std` is not enabled).

# Objective

- Make the implicit imports for `no_std` crates consistent regardless of
what features are/not enabled.

## Solution

- Replace the `cfg_attr` "double negative" `no_std` attribute with
conditional compilation to _include_ `std` as an external crate.
```rust
// Before
#![cfg_attr(not(feature = "std"), no_std)]

// After
#![no_std]

#[cfg(feature = "std")]
extern crate std;
```
- Fix imports that are currently broken but are only now visible with
the above fix.

## Testing

- CI

## Notes

I had previously used the "double negative" version of `no_std` based on
general consensus that it was "cleaner" within the Rust embedded
community. However, this implicit prelude issue likely was considered
when forming this consensus. I believe the reason why is the items most
affected by this issue are provided by the `alloc` crate, which is
rarely used within embedded but extensively used within Bevy.
2025-01-03 01:58:43 +00:00
..
bevy_a11y bevy_a11y: Apply #[deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] (#17093) 2025-01-02 18:45:19 +00:00
bevy_animation bevy_animation: Apply #[deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] (#17094) 2025-01-02 18:45:05 +00:00
bevy_app Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_asset Do not lowercase asset file extensions (#17065) 2025-01-01 00:42:56 +00:00
bevy_audio Prefer Display over Debug (#16112) 2024-12-27 00:40:06 +00:00
bevy_color Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_core_pipeline Refactor and simplify custom projections (#17063) 2025-01-01 20:44:24 +00:00
bevy_derive Add benchmarks and compile_fail tests back to workspace (#16858) 2024-12-21 22:30:29 +00:00
bevy_dev_tools Draw the UI debug overlay using the UI renderer (#16693) 2024-12-11 00:49:47 +00:00
bevy_diagnostic Remove bevy_core (#16897) 2024-12-19 18:36:51 +00:00
bevy_dylib Generate links to definition in source code pages on docs.rs and dev-docs.bevyengine.org (#12965) 2024-07-29 23:10:16 +00:00
bevy_ecs Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_encase_derive Rust 1.83, allow -> expect (missing_docs) (#16561) 2024-12-16 23:27:57 +00:00
bevy_gilrs Deny derive_more error feature and replace it with thiserror (#16684) 2024-12-06 17:03:55 +00:00
bevy_gizmos Refactor non-core Curve methods into extension traits (#16930) 2024-12-29 19:26:49 +00:00
bevy_gltf Prefer Display over Debug (#16112) 2024-12-27 00:40:06 +00:00
bevy_hierarchy Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_image Rust 1.83, allow -> expect (missing_docs) (#16561) 2024-12-16 23:27:57 +00:00
bevy_input Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_input_focus Return Result from tab navigation API (#17071) 2025-01-01 04:05:48 +00:00
bevy_internal Rename track_change_detection flag to track_location (#17075) 2025-01-01 18:43:47 +00:00
bevy_log Basic filtering examples for users of the bevy_log. (#16455) 2024-12-29 22:56:40 +00:00
bevy_macro_utils Use one BevyManifest instance in proc macros (#16766) 2024-12-15 15:00:05 +00:00
bevy_math Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_mesh Rust 1.83, allow -> expect (missing_docs) (#16561) 2024-12-16 23:27:57 +00:00
bevy_mikktspace Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_pbr Fix clippy::precedence (#17080) 2025-01-01 22:11:22 +00:00
bevy_picking Replace map + unwrap_or(false) with is_some_and (#17067) 2024-12-31 20:28:02 +00:00
bevy_ptr Fix MSRVs for standalone crates (#16333) 2024-11-17 09:38:13 +00:00
bevy_reflect Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_remote show these 'fully qualified paths' for bevy_remote's rpc (#16944) 2024-12-31 00:29:27 +00:00
bevy_render Refactor and simplify custom projections (#17063) 2025-01-01 20:44:24 +00:00
bevy_scene Replace map + unwrap_or(true) with is_none_or (#17070) 2024-12-31 20:17:03 +00:00
bevy_sprite Refactor and simplify custom projections (#17063) 2025-01-01 20:44:24 +00:00
bevy_state Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_tasks Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_text Fix sprite performance regression since retained render world (#17078) 2025-01-01 18:40:11 +00:00
bevy_time Use en-us locale for typos (#16037) 2024-10-20 18:55:17 +00:00
bevy_transform Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_ui UI Debug Overlay show_hidden and show_clipped options (#17097) 2025-01-02 18:43:14 +00:00
bevy_utils Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_window Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_winit Simplify sort/max_by calls (#17048) 2024-12-30 22:59:36 +00:00