
# Objective - Fixes #6370 - Closes #6581 ## Solution - Added the following lints to the workspace: - `std_instead_of_core` - `std_instead_of_alloc` - `alloc_instead_of_core` - Used `cargo +nightly fmt` with [item level use formatting](https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=#Item%5C%3A) to split all `use` statements into single items. - Used `cargo clippy --workspace --all-targets --all-features --fix --allow-dirty` to _attempt_ to resolve the new linting issues, and intervened where the lint was unable to resolve the issue automatically (usually due to needing an `extern crate alloc;` statement in a crate root). - Manually removed certain uses of `std` where negative feature gating prevented `--all-features` from finding the offending uses. - Used `cargo +nightly fmt` with [crate level use formatting](https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=#Crate%5C%3A) to re-merge all `use` statements matching Bevy's previous styling. - Manually fixed cases where the `fmt` tool could not re-merge `use` statements due to conditional compilation attributes. ## Testing - Ran CI locally ## Migration Guide The MSRV is now 1.81. Please update to this version or higher. ## Notes - This is a _massive_ change to try and push through, which is why I've outlined the semi-automatic steps I used to create this PR, in case this fails and someone else tries again in the future. - Making this change has no impact on user code, but does mean Bevy contributors will be warned to use `core` and `alloc` instead of `std` where possible. - This lint is a critical first step towards investigating `no_std` options for Bevy. --------- Co-authored-by: François Mockers <francois.mockers@vleue.com>
39 lines
940 B
Rust
39 lines
940 B
Rust
use crate::{AudioSourceBundle, Decodable};
|
|
use bevy_asset::Asset;
|
|
use bevy_reflect::TypePath;
|
|
use rodio::{
|
|
source::{SineWave, TakeDuration},
|
|
Source,
|
|
};
|
|
|
|
/// A source of sine wave sound
|
|
#[derive(Asset, Debug, Clone, TypePath)]
|
|
pub struct Pitch {
|
|
/// Frequency at which sound will be played
|
|
pub frequency: f32,
|
|
/// Duration for which sound will be played
|
|
pub duration: core::time::Duration,
|
|
}
|
|
|
|
impl Pitch {
|
|
/// Creates a new note
|
|
pub fn new(frequency: f32, duration: core::time::Duration) -> Self {
|
|
Pitch {
|
|
frequency,
|
|
duration,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl Decodable for Pitch {
|
|
type DecoderItem = <SineWave as Iterator>::Item;
|
|
type Decoder = TakeDuration<SineWave>;
|
|
|
|
fn decoder(&self) -> Self::Decoder {
|
|
SineWave::new(self.frequency).take_duration(self.duration)
|
|
}
|
|
}
|
|
|
|
/// Bundle for playing a bevy note sound
|
|
pub type PitchBundle = AudioSourceBundle<Pitch>;
|