 4847f7e3ad
			
		
	
	
		4847f7e3ad
		
	
	
	
	
		
			
			Remove unnecessary calls to `iter()`/`iter_mut()`.
Mainly updates the use of queries in our code, docs, and examples.
```rust
// From
for _ in list.iter() {
for _ in list.iter_mut() {
// To
for _ in &list {
for _ in &mut list {
```
We already enable the pedantic lint [clippy::explicit_iter_loop](https://rust-lang.github.io/rust-clippy/stable/) inside of Bevy. However, this only warns for a few known types from the standard library.
## Note for reviewers
As you can see the additions and deletions are exactly equal.
Maybe give it a quick skim to check I didn't sneak in a crypto miner, but you don't have to torture yourself by reading every line.
I already experienced enough pain making this PR :) 
Co-authored-by: devil-ira <justthecooldude@gmail.com>
		
	
			
		
			
				
	
	
		
			94 lines
		
	
	
		
			2.8 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			94 lines
		
	
	
		
			2.8 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
| //! How to use an external thread to run an infinite task and communicate with a channel.
 | |
| 
 | |
| use bevy::prelude::*;
 | |
| // Using crossbeam_channel instead of std as std `Receiver` is `!Sync`
 | |
| use crossbeam_channel::{bounded, Receiver};
 | |
| use rand::Rng;
 | |
| use std::time::{Duration, Instant};
 | |
| 
 | |
| fn main() {
 | |
|     App::new()
 | |
|         .add_event::<StreamEvent>()
 | |
|         .add_plugins(DefaultPlugins)
 | |
|         .add_startup_system(setup)
 | |
|         .add_system(read_stream)
 | |
|         .add_system(spawn_text)
 | |
|         .add_system(move_text)
 | |
|         .run();
 | |
| }
 | |
| 
 | |
| #[derive(Deref)]
 | |
| struct StreamReceiver(Receiver<u32>);
 | |
| struct StreamEvent(u32);
 | |
| 
 | |
| #[derive(Deref)]
 | |
| struct LoadedFont(Handle<Font>);
 | |
| 
 | |
| fn setup(mut commands: Commands, asset_server: Res<AssetServer>) {
 | |
|     commands.spawn_bundle(Camera2dBundle::default());
 | |
| 
 | |
|     let (tx, rx) = bounded::<u32>(10);
 | |
|     std::thread::spawn(move || loop {
 | |
|         // Everything here happens in another thread
 | |
|         // This is where you could connect to an external data source
 | |
|         let mut rng = rand::thread_rng();
 | |
|         let start_time = Instant::now();
 | |
|         let duration = Duration::from_secs_f32(rng.gen_range(0.0..0.2));
 | |
|         while start_time.elapsed() < duration {
 | |
|             // Spinning for 'duration', simulating doing hard work!
 | |
|         }
 | |
| 
 | |
|         tx.send(rng.gen_range(0..2000)).unwrap();
 | |
|     });
 | |
| 
 | |
|     commands.insert_resource(StreamReceiver(rx));
 | |
|     commands.insert_resource(LoadedFont(asset_server.load("fonts/FiraSans-Bold.ttf")));
 | |
| }
 | |
| 
 | |
| // This system reads from the receiver and sends events to Bevy
 | |
| fn read_stream(receiver: ResMut<StreamReceiver>, mut events: EventWriter<StreamEvent>) {
 | |
|     for from_stream in receiver.try_iter() {
 | |
|         events.send(StreamEvent(from_stream));
 | |
|     }
 | |
| }
 | |
| 
 | |
| fn spawn_text(
 | |
|     mut commands: Commands,
 | |
|     mut reader: EventReader<StreamEvent>,
 | |
|     loaded_font: Res<LoadedFont>,
 | |
| ) {
 | |
|     let text_style = TextStyle {
 | |
|         font: loaded_font.clone(),
 | |
|         font_size: 20.0,
 | |
|         color: Color::WHITE,
 | |
|     };
 | |
|     let text_alignment = TextAlignment {
 | |
|         vertical: VerticalAlign::Center,
 | |
|         horizontal: HorizontalAlign::Center,
 | |
|     };
 | |
|     for (per_frame, event) in reader.iter().enumerate() {
 | |
|         commands.spawn_bundle(Text2dBundle {
 | |
|             text: Text::with_section(format!("{}", event.0), text_style.clone(), text_alignment),
 | |
|             transform: Transform::from_xyz(
 | |
|                 per_frame as f32 * 100.0 + rand::thread_rng().gen_range(-40.0..40.0),
 | |
|                 300.0,
 | |
|                 0.0,
 | |
|             ),
 | |
|             ..default()
 | |
|         });
 | |
|     }
 | |
| }
 | |
| 
 | |
| fn move_text(
 | |
|     mut commands: Commands,
 | |
|     mut texts: Query<(Entity, &mut Transform), With<Text>>,
 | |
|     time: Res<Time>,
 | |
| ) {
 | |
|     for (entity, mut position) in &mut texts {
 | |
|         position.translation -= Vec3::new(0.0, 100.0 * time.delta_seconds(), 0.0);
 | |
|         if position.translation.y < -300.0 {
 | |
|             commands.entity(entity).despawn();
 | |
|         }
 | |
|     }
 | |
| }
 |