bevy/crates/bevy_core_pipeline/src
Lennard cd2d14c0fd
Fix blending for CameraOutputMode::Skip (#16157)
# Objective

Currently, if we have two cameras with the same output texture, one with
`CameraOutputMode::Write` and one with `CameraOutputMode::Skip`, it is
possible for the `CameraOutputMode::Write` camera to be assigned alpha
blending (which is the fallback blending when multiple cameras write to
the same output texture), although it is the only camera writing to the
output texture. This may or may not happen every restart of the app,
because the camera iteration order in prepare_view_upscaling_pipelines
isn't consistent. Since this is random behaviour I consider this a bug
and didn't add a migration guide.

## Solution

In `prepare_view_upscaling_pipelines` make sure we don't consider
cameras with CameraOutputMode::Skip to be outputting something to the
output texture.

## Testing

I ran a few examples to make sure nothing obvious is broken. There is no
example using CameraOutputMode::Skip, so I only tested the change in my
own App where this was relevant, which however isn't public.
2024-11-04 15:26:42 +00:00
..
auto_exposure Implement WorldQuery for MainWorld and RenderWorld components (#15745) 2024-10-13 20:58:46 +00:00
blit
bloom fix: Skip some rendering logics when the viewport width or height is zero (#15654) 2024-10-08 22:52:19 +00:00
contrast_adaptive_sharpening Simpler lint fixes: makes ci lints work but disables a lint for now (#15376) 2024-09-24 11:42:59 +00:00
core_2d Implement WorldQuery for MainWorld and RenderWorld components (#15745) 2024-10-13 20:58:46 +00:00
core_3d Implement WorldQuery for MainWorld and RenderWorld components (#15745) 2024-10-13 20:58:46 +00:00
deferred Type safe retained render world (#15756) 2024-10-10 18:47:04 +00:00
dof Remove components if not extracted (#15948) 2024-10-19 15:13:39 +00:00
fullscreen_vertex_shader
fxaa Simpler lint fixes: makes ci lints work but disables a lint for now (#15376) 2024-09-24 11:42:59 +00:00
motion_blur Use en-us locale for typos (#16037) 2024-10-20 18:55:17 +00:00
oit Adding alpha_threshold to OrderIndependentTransparencySettings for user-level optimization (#16090) 2024-10-27 19:08:34 +00:00
post_process Start a built-in postprocessing stack, and implement chromatic aberration in it. (#13695) 2024-07-15 13:59:02 +00:00
prepass Type safe retained render world (#15756) 2024-10-10 18:47:04 +00:00
skybox Allow to expect (adopted) (#15301) 2024-09-20 19:16:42 +00:00
smaa Rename rendering components for improved consistency and clarity (#15035) 2024-09-10 01:11:46 +00:00
taa Remove components if not extracted (#15948) 2024-10-19 15:13:39 +00:00
tonemapping Migrate cameras to required components (#15641) 2024-10-05 01:59:52 +00:00
upscaling Fix blending for CameraOutputMode::Skip (#16157) 2024-11-04 15:26:42 +00:00
lib.rs Fix oit webgl (#15728) 2024-10-08 14:50:35 +00:00
msaa_writeback.rs Simpler lint fixes: makes ci lints work but disables a lint for now (#15376) 2024-09-24 11:42:59 +00:00