# Objective Yet another PR for migrating stuff to required components. This time, cameras! ## Solution As per the [selected proposal](https://hackmd.io/tsYID4CGRiWxzsgawzxG_g#Combined-Proposal-1-Selected), deprecate `Camera2dBundle` and `Camera3dBundle` in favor of `Camera2d` and `Camera3d`. Adding a `Camera` without `Camera2d` or `Camera3d` now logs a warning, as suggested by Cart [on Discord](https://discord.com/channels/691052431525675048/1264881140007702558/1291506402832945273). I would personally like cameras to work a bit differently and be split into a few more components, to avoid some footguns and confusing semantics, but that is more controversial, and shouldn't block this core migration. ## Testing I ran a few 2D and 3D examples, and tried cameras with and without render graphs. --- ## Migration Guide `Camera2dBundle` and `Camera3dBundle` have been deprecated in favor of `Camera2d` and `Camera3d`. Inserting them will now also insert the other components required by them automatically.
		
			
				
	
	
		
			64 lines
		
	
	
		
			1.9 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			64 lines
		
	
	
		
			1.9 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
//! Rendering a scene with baked lightmaps.
 | 
						|
 | 
						|
use bevy::{pbr::Lightmap, prelude::*};
 | 
						|
 | 
						|
fn main() {
 | 
						|
    App::new()
 | 
						|
        .add_plugins(DefaultPlugins)
 | 
						|
        .insert_resource(AmbientLight::NONE)
 | 
						|
        .add_systems(Startup, setup)
 | 
						|
        .add_systems(Update, add_lightmaps_to_meshes)
 | 
						|
        .run();
 | 
						|
}
 | 
						|
 | 
						|
fn setup(mut commands: Commands, asset_server: Res<AssetServer>) {
 | 
						|
    commands.spawn(SceneRoot(asset_server.load(
 | 
						|
        GltfAssetLabel::Scene(0).from_asset("models/CornellBox/CornellBox.glb"),
 | 
						|
    )));
 | 
						|
 | 
						|
    commands.spawn((
 | 
						|
        Camera3d::default(),
 | 
						|
        Transform::from_xyz(-278.0, 273.0, 800.0),
 | 
						|
    ));
 | 
						|
}
 | 
						|
 | 
						|
fn add_lightmaps_to_meshes(
 | 
						|
    mut commands: Commands,
 | 
						|
    asset_server: Res<AssetServer>,
 | 
						|
    mut materials: ResMut<Assets<StandardMaterial>>,
 | 
						|
    meshes: Query<
 | 
						|
        (Entity, &Name, &MeshMaterial3d<StandardMaterial>),
 | 
						|
        (With<Mesh3d>, Without<Lightmap>),
 | 
						|
    >,
 | 
						|
) {
 | 
						|
    let exposure = 250.0;
 | 
						|
    for (entity, name, material) in meshes.iter() {
 | 
						|
        if &**name == "large_box" {
 | 
						|
            materials.get_mut(material).unwrap().lightmap_exposure = exposure;
 | 
						|
            commands.entity(entity).insert(Lightmap {
 | 
						|
                image: asset_server.load("lightmaps/CornellBox-Large.zstd.ktx2"),
 | 
						|
                ..default()
 | 
						|
            });
 | 
						|
            continue;
 | 
						|
        }
 | 
						|
 | 
						|
        if &**name == "small_box" {
 | 
						|
            materials.get_mut(material).unwrap().lightmap_exposure = exposure;
 | 
						|
            commands.entity(entity).insert(Lightmap {
 | 
						|
                image: asset_server.load("lightmaps/CornellBox-Small.zstd.ktx2"),
 | 
						|
                ..default()
 | 
						|
            });
 | 
						|
            continue;
 | 
						|
        }
 | 
						|
 | 
						|
        if name.starts_with("cornell_box") {
 | 
						|
            materials.get_mut(material).unwrap().lightmap_exposure = exposure;
 | 
						|
            commands.entity(entity).insert(Lightmap {
 | 
						|
                image: asset_server.load("lightmaps/CornellBox-Box.zstd.ktx2"),
 | 
						|
                ..default()
 | 
						|
            });
 | 
						|
            continue;
 | 
						|
        }
 | 
						|
    }
 | 
						|
}
 |