# Objective
Currently text is recomputed unnecessarily on any changes to its color,
which is extremely expensive.
## Solution
Split up `TextStyle` into two separate components `TextFont` and
`TextColor`.
## Testing
I added this system to `many_buttons`:
```rust
fn set_text_colors_changed(mut colors: Query<&mut TextColor>) {
    for mut text_color in colors.iter_mut() {
        text_color.set_changed();
    }
}
```
reports ~4fps on main, ~50fps with this PR.
## Migration Guide
`TextStyle` has been renamed to `TextFont` and its `color` field has
been moved to a separate component named `TextColor` which newtypes
`Color`.
		
	
			
		
			
				
	
	
		
			102 lines
		
	
	
		
			3.6 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			102 lines
		
	
	
		
			3.6 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
//! This example illustrates how to create buttons with their textures sliced
 | 
						|
//! and kept in proportion instead of being stretched by the button dimensions
 | 
						|
 | 
						|
use bevy::{
 | 
						|
    color::palettes::css::{GOLD, ORANGE},
 | 
						|
    prelude::*,
 | 
						|
    winit::WinitSettings,
 | 
						|
};
 | 
						|
 | 
						|
fn main() {
 | 
						|
    App::new()
 | 
						|
        .add_plugins(DefaultPlugins)
 | 
						|
        // Only run the app when there is user input. This will significantly reduce CPU/GPU use.
 | 
						|
        .insert_resource(WinitSettings::desktop_app())
 | 
						|
        .add_systems(Startup, setup)
 | 
						|
        .add_systems(Update, button_system)
 | 
						|
        .run();
 | 
						|
}
 | 
						|
 | 
						|
fn button_system(
 | 
						|
    mut interaction_query: Query<
 | 
						|
        (&Interaction, &Children, &mut UiImage),
 | 
						|
        (Changed<Interaction>, With<Button>),
 | 
						|
    >,
 | 
						|
    mut text_query: Query<&mut Text>,
 | 
						|
) {
 | 
						|
    for (interaction, children, mut image) in &mut interaction_query {
 | 
						|
        let mut text = text_query.get_mut(children[0]).unwrap();
 | 
						|
        match *interaction {
 | 
						|
            Interaction::Pressed => {
 | 
						|
                **text = "Press".to_string();
 | 
						|
                image.color = GOLD.into();
 | 
						|
            }
 | 
						|
            Interaction::Hovered => {
 | 
						|
                **text = "Hover".to_string();
 | 
						|
                image.color = ORANGE.into();
 | 
						|
            }
 | 
						|
            Interaction::None => {
 | 
						|
                **text = "Button".to_string();
 | 
						|
                image.color = Color::WHITE;
 | 
						|
            }
 | 
						|
        }
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
fn setup(mut commands: Commands, asset_server: Res<AssetServer>) {
 | 
						|
    let image = asset_server.load("textures/fantasy_ui_borders/panel-border-010.png");
 | 
						|
 | 
						|
    let slicer = TextureSlicer {
 | 
						|
        border: BorderRect::square(22.0),
 | 
						|
        center_scale_mode: SliceScaleMode::Stretch,
 | 
						|
        sides_scale_mode: SliceScaleMode::Stretch,
 | 
						|
        max_corner_scale: 1.0,
 | 
						|
    };
 | 
						|
    // ui camera
 | 
						|
    commands.spawn(Camera2d);
 | 
						|
    commands
 | 
						|
        .spawn(NodeBundle {
 | 
						|
            style: Style {
 | 
						|
                width: Val::Percent(100.0),
 | 
						|
                height: Val::Percent(100.0),
 | 
						|
                align_items: AlignItems::Center,
 | 
						|
                justify_content: JustifyContent::Center,
 | 
						|
                ..default()
 | 
						|
            },
 | 
						|
            ..default()
 | 
						|
        })
 | 
						|
        .with_children(|parent| {
 | 
						|
            for [w, h] in [[150.0, 150.0], [300.0, 150.0], [150.0, 300.0]] {
 | 
						|
                parent
 | 
						|
                    .spawn((
 | 
						|
                        ButtonBundle {
 | 
						|
                            style: Style {
 | 
						|
                                width: Val::Px(w),
 | 
						|
                                height: Val::Px(h),
 | 
						|
                                // horizontally center child text
 | 
						|
                                justify_content: JustifyContent::Center,
 | 
						|
                                // vertically center child text
 | 
						|
                                align_items: AlignItems::Center,
 | 
						|
                                margin: UiRect::all(Val::Px(20.0)),
 | 
						|
                                ..default()
 | 
						|
                            },
 | 
						|
                            image: image.clone().into(),
 | 
						|
                            ..default()
 | 
						|
                        },
 | 
						|
                        ImageScaleMode::Sliced(slicer.clone()),
 | 
						|
                    ))
 | 
						|
                    .with_children(|parent| {
 | 
						|
                        parent.spawn((
 | 
						|
                            Text::new("Button"),
 | 
						|
                            TextFont {
 | 
						|
                                font: asset_server.load("fonts/FiraSans-Bold.ttf"),
 | 
						|
                                font_size: 33.0,
 | 
						|
                                ..default()
 | 
						|
                            },
 | 
						|
                            TextColor(Color::srgb(0.9, 0.9, 0.9)),
 | 
						|
                        ));
 | 
						|
                    });
 | 
						|
            }
 | 
						|
        });
 | 
						|
}
 |