Kristoffer Søholm 3928d01841 Ignore query parameters in AssetPaths when determining the extension (#12828) ... # Objective A help thread on discord asked how to use signed URLs for assets. This currently fails because the query parameters are included in the extension, which causes no suitable loader to be found: ``` Failed to load asset 'http://localhost:4566/dev/1711921849174.jpeg?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=%2F20240331%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240331T230145Z&X-Amz-Expires=900&X-Amz-Signature=64855e731c279fa01063568e37095562ef74e09387c881bd3e3604181d0cc108&X-Amz-SignedHeaders=host&x-id=GetObject' with asset loader 'bevy_render::texture::image_loader::ImageLoader': Could not load texture file: Error reading image file localhost:4566/dev/1711921849174.jpeg?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=%2F20240331%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240331T230145Z&X-Amz-Expires=900&X-Amz-Signature=64855e731c279fa01063568e37095562ef74e09387c881bd3e3604181d0cc108&X-Amz-SignedHeaders=host&x-id=GetObject: invalid image extension: jpeg?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=%2F20240331%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240331T230145Z&X-Amz-Expires=900&X-Amz-Signature=64855e731c279fa01063568e37095562ef74e09387c881bd3e3604181d0cc108&X-Amz-SignedHeaders=host&x-id=GetObject, this is an error in `bevy_render`. ``` ## Solution Make `get_full_extension` remove everything after the first `?` character. If this is accepted then it should also be documented in `AssetPath` that extensions cannot include question marks. An alternative is to special case this handling only for wasm, but that would be annoying for the [bevy_web_asset](https://github.com/johanhelsing/bevy_web_asset) plugin, and in my opinion also just more confusing overall.		2024-04-03 18:57:03 +00:00
..
io	Refactor App and SubApp internals for better separation (#9202)	2024-03-31 03:16:10 +00:00
processor	Add AsyncSeek trait to Reader to be able to seek inside asset loaders (#12547)	2024-03-30 22:26:30 +00:00
server	Fix get_asset_paths not properly deleting empty folders (& recursive async functions) (#12638)	2024-03-23 03:35:51 +00:00
assets.rs	send Unused event when asset is actually unused (#12459)	2024-03-17 21:37:34 +00:00
direct_access_ext.rs	Add methods to directly load assets from World (#12023)	2024-02-27 00:28:26 +00:00
event.rs	Added AssetLoadFailedEvent, UntypedAssetLoadFailedEvent (#11369)	2024-01-17 21:12:00 +00:00
folder.rs	Bevy Asset V2 (#8624)	2023-09-07 02:07:27 +00:00
handle.rs	Allow converting mutable handle borrows to AssetId. (#12759)	2024-03-28 15:53:26 +00:00
id.rs	Implement the AnimationGraph, allowing for multiple animations to be blended together. (#11989)	2024-03-07 20:22:42 +00:00
lib.rs	Refactor App and SubApp internals for better separation (#9202)	2024-03-31 03:16:10 +00:00
loader.rs	Use async-fn in traits rather than BoxedFuture (#12550)	2024-03-18 17:56:57 +00:00
meta.rs	Use async-fn in traits rather than BoxedFuture (#12550)	2024-03-18 17:56:57 +00:00
path.rs	Ignore query parameters in AssetPaths when determining the extension (#12828)	2024-04-03 18:57:03 +00:00
reflect.rs	Refactor App and SubApp internals for better separation (#9202)	2024-03-31 03:16:10 +00:00
saver.rs	Use async-fn in traits rather than BoxedFuture (#12550)	2024-03-18 17:56:57 +00:00
transformer.rs	Use async-fn in traits rather than BoxedFuture (#12550)	2024-03-18 17:56:57 +00:00