bevy/crates/bevy_pbr/src
Alice Cecile 4ac2a63556
Remove all existing system order ambiguities in DefaultPlugins (#15031)
# Objective

As discussed in https://github.com/bevyengine/bevy/issues/7386, system
order ambiguities within `DefaultPlugins` are a source of bugs in the
engine and badly pollute diagnostic output for users.

We should eliminate them!

This PR is an alternative to #15027: with all external ambiguities
silenced, this should be much less prone to merge conflicts and the test
output should be much easier for authors to understand.

Note that system order ambiguities are still permitted in the
`RenderApp`: these need a bit of thought in terms of how to test them,
and will be fairly involved to fix. While these aren't *good*, they'll
generally only cause graphical bugs, not logic ones.

## Solution

All remaining system order ambiguities have been resolved.
Review this PR commit-by-commit to see how each of these problems were
fixed.

## Testing

`cargo run --example ambiguity_detection` passes with no panics or
logging!
2024-09-03 20:24:34 +00:00
..
cluster Migrated NonZero* to NonZero<*> (#14978) 2024-08-30 02:37:47 +00:00
deferred Add support for environment map transformation (#14290) 2024-07-19 15:00:50 +00:00
light Remove all existing system order ambiguities in DefaultPlugins (#15031) 2024-09-03 20:24:34 +00:00
light_probe Migrated NonZero* to NonZero<*> (#14978) 2024-08-30 02:37:47 +00:00
lightmap Pack multiple vertex and index arrays together into growable buffers. (#14257) 2024-07-16 20:33:15 +00:00
meshlet Migrated NonZero* to NonZero<*> (#14978) 2024-08-30 02:37:47 +00:00
prepass Remove unnecessary muts in RenderSet::QueueMeshes (#14953) 2024-08-28 11:38:38 +00:00
render Migrated NonZero* to NonZero<*> (#14978) 2024-08-30 02:37:47 +00:00
ssao Move Msaa to component (#14273) 2024-07-22 18:28:23 +00:00
ssr Add support for environment map transformation (#14290) 2024-07-19 15:00:50 +00:00
volumetric_fog Fix fog density texture offset seam (#14900) 2024-08-24 00:56:39 +00:00
bundle.rs Lighting Should Only hold Vec<Entity> instead of TypeId<Vec<Entity>> (#14073) 2024-07-14 17:00:54 +00:00
extended_material.rs Refactor AsBindGroup to use a associated SystemParam. (#14909) 2024-08-25 20:16:34 +00:00
fog.rs Fix lints introduced in Rust beta 1.80 (#13899) 2024-06-17 17:22:01 +00:00
lib.rs Remove all existing system order ambiguities in DefaultPlugins (#15031) 2024-09-03 20:24:34 +00:00
material.rs Migrated NonZero* to NonZero<*> (#14978) 2024-08-30 02:37:47 +00:00
parallax.rs bevy_reflect: FromReflect Ergonomics Implementation (#6056) 2023-06-29 01:31:34 +00:00
pbr_material.rs Fix intra-doc links and make CI test them (#14076) 2024-07-11 13:08:31 +00:00
wireframe.rs Have EntityCommands methods consume self for easier chaining (#14897) 2024-08-26 18:24:59 +00:00