320ac65a9e
# Objective Implements #9216 ## Solution - Replace `DiagnosticId` by `DiagnosticPath`. It's pre-hashed using `const-fnv1a-hash` crate, so it's possible to create path in const contexts. --- ## Changelog - Replaced `DiagnosticId` by `DiagnosticPath` - Set default history length to 120 measurements (2 seconds on 60 fps). I've noticed hardcoded constant 20 everywhere and decided to change it to `DEFAULT_MAX_HISTORY_LENGTH` , which is set to new diagnostics by default. To override it, use `with_max_history_length`. ## Migration Guide ```diff - const UNIQUE_DIAG_ID: DiagnosticId = DiagnosticId::from_u128(42); + const UNIQUE_DIAG_PATH: DiagnosticPath = DiagnosticPath::const_new("foo/bar"); - Diagnostic::new(UNIQUE_DIAG_ID, "example", 10) + Diagnostic::new(UNIQUE_DIAG_PATH).with_max_history_length(10) - diagnostics.add_measurement(UNIQUE_DIAG_ID, || 42); + diagnostics.add_measurement(&UNIQUE_DIAG_ID, || 42); ```
28 lines
880 B
Rust
28 lines
880 B
Rust
use bevy_app::prelude::*;
|
|
use bevy_ecs::entity::Entities;
|
|
|
|
use crate::{Diagnostic, DiagnosticPath, Diagnostics, RegisterDiagnostic};
|
|
|
|
/// Adds "entity count" diagnostic to an App.
|
|
///
|
|
/// # See also
|
|
///
|
|
/// [`LogDiagnosticsPlugin`](crate::LogDiagnosticsPlugin) to output diagnostics to the console.
|
|
#[derive(Default)]
|
|
pub struct EntityCountDiagnosticsPlugin;
|
|
|
|
impl Plugin for EntityCountDiagnosticsPlugin {
|
|
fn build(&self, app: &mut App) {
|
|
app.register_diagnostic(Diagnostic::new(Self::ENTITY_COUNT))
|
|
.add_systems(Update, Self::diagnostic_system);
|
|
}
|
|
}
|
|
|
|
impl EntityCountDiagnosticsPlugin {
|
|
pub const ENTITY_COUNT: DiagnosticPath = DiagnosticPath::const_new("entity_count");
|
|
|
|
pub fn diagnostic_system(mut diagnostics: Diagnostics, entities: &Entities) {
|
|
diagnostics.add_measurement(&Self::ENTITY_COUNT, || entities.len() as f64);
|
|
}
|
|
}
|