efda7f3f9c
Takes the first two commits from #15375 and adds suggestions from this comment: https://github.com/bevyengine/bevy/pull/15375#issuecomment-2366968300 See #15375 for more reasoning/motivation. ## Rebasing (rerunning) ```rust git switch simpler-lint-fixes git reset --hard main cargo fmt --all -- --unstable-features --config normalize_comments=true,imports_granularity=Crate cargo fmt --all git add --update git commit --message "rustfmt" cargo clippy --workspace --all-targets --all-features --fix cargo fmt --all -- --unstable-features --config normalize_comments=true,imports_granularity=Crate cargo fmt --all git add --update git commit --message "clippy" git cherry-pick e6c0b94f6795222310fb812fa5c4512661fc7887 ```
109 lines
3.7 KiB
Rust
109 lines
3.7 KiB
Rust
use crate::{
|
|
render_resource::{Texture, TextureView},
|
|
renderer::RenderDevice,
|
|
};
|
|
use bevy_ecs::{prelude::ResMut, system::Resource};
|
|
use bevy_utils::{Entry, HashMap};
|
|
use wgpu::{TextureDescriptor, TextureViewDescriptor};
|
|
|
|
/// The internal representation of a [`CachedTexture`] used to track whether it was recently used
|
|
/// and is currently taken.
|
|
struct CachedTextureMeta {
|
|
texture: Texture,
|
|
default_view: TextureView,
|
|
taken: bool,
|
|
frames_since_last_use: usize,
|
|
}
|
|
|
|
/// A cached GPU [`Texture`] with corresponding [`TextureView`].
|
|
///
|
|
/// This is useful for textures that are created repeatedly (each frame) in the rendering process
|
|
/// to reduce the amount of GPU memory allocations.
|
|
#[derive(Clone)]
|
|
pub struct CachedTexture {
|
|
pub texture: Texture,
|
|
pub default_view: TextureView,
|
|
}
|
|
|
|
/// This resource caches textures that are created repeatedly in the rendering process and
|
|
/// are only required for one frame.
|
|
#[derive(Resource, Default)]
|
|
pub struct TextureCache {
|
|
textures: HashMap<TextureDescriptor<'static>, Vec<CachedTextureMeta>>,
|
|
}
|
|
|
|
impl TextureCache {
|
|
/// Retrieves a texture that matches the `descriptor`. If no matching one is found a new
|
|
/// [`CachedTexture`] is created.
|
|
pub fn get(
|
|
&mut self,
|
|
render_device: &RenderDevice,
|
|
descriptor: TextureDescriptor<'static>,
|
|
) -> CachedTexture {
|
|
match self.textures.entry(descriptor) {
|
|
Entry::Occupied(mut entry) => {
|
|
for texture in entry.get_mut().iter_mut() {
|
|
if !texture.taken {
|
|
texture.frames_since_last_use = 0;
|
|
texture.taken = true;
|
|
return CachedTexture {
|
|
texture: texture.texture.clone(),
|
|
default_view: texture.default_view.clone(),
|
|
};
|
|
}
|
|
}
|
|
|
|
let texture = render_device.create_texture(&entry.key().clone());
|
|
let default_view = texture.create_view(&TextureViewDescriptor::default());
|
|
entry.get_mut().push(CachedTextureMeta {
|
|
texture: texture.clone(),
|
|
default_view: default_view.clone(),
|
|
frames_since_last_use: 0,
|
|
taken: true,
|
|
});
|
|
CachedTexture {
|
|
texture,
|
|
default_view,
|
|
}
|
|
}
|
|
Entry::Vacant(entry) => {
|
|
let texture = render_device.create_texture(entry.key());
|
|
let default_view = texture.create_view(&TextureViewDescriptor::default());
|
|
entry.insert(vec![CachedTextureMeta {
|
|
texture: texture.clone(),
|
|
default_view: default_view.clone(),
|
|
taken: true,
|
|
frames_since_last_use: 0,
|
|
}]);
|
|
CachedTexture {
|
|
texture,
|
|
default_view,
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Returns `true` if the texture cache contains no textures.
|
|
pub fn is_empty(&self) -> bool {
|
|
self.textures.is_empty()
|
|
}
|
|
|
|
/// Updates the cache and only retains recently used textures.
|
|
pub fn update(&mut self) {
|
|
self.textures.retain(|_, textures| {
|
|
for texture in textures.iter_mut() {
|
|
texture.frames_since_last_use += 1;
|
|
texture.taken = false;
|
|
}
|
|
|
|
textures.retain(|texture| texture.frames_since_last_use < 3);
|
|
!textures.is_empty()
|
|
});
|
|
}
|
|
}
|
|
|
|
/// Updates the [`TextureCache`] to only retains recently used textures.
|
|
pub fn update_texture_cache_system(mut texture_cache: ResMut<TextureCache>) {
|
|
texture_cache.update();
|
|
}
|