0403948aa2
# Background In `no_std` compatible crates, there is often an `std` feature which will allow access to the standard library. Currently, with the `std` feature _enabled_, the [`std::prelude`](https://doc.rust-lang.org/std/prelude/index.html) is implicitly imported in all modules. With the feature _disabled_, instead the [`core::prelude`](https://doc.rust-lang.org/core/prelude/index.html) is implicitly imported. This creates a subtle and pervasive issue where `alloc` items _may_ be implicitly included (if `std` is enabled), or must be explicitly included (if `std` is not enabled). # Objective - Make the implicit imports for `no_std` crates consistent regardless of what features are/not enabled. ## Solution - Replace the `cfg_attr` "double negative" `no_std` attribute with conditional compilation to _include_ `std` as an external crate. ```rust // Before #![cfg_attr(not(feature = "std"), no_std)] // After #![no_std] #[cfg(feature = "std")] extern crate std; ``` - Fix imports that are currently broken but are only now visible with the above fix. ## Testing - CI ## Notes I had previously used the "double negative" version of `no_std` based on general consensus that it was "cleaner" within the Rust embedded community. However, this implicit prelude issue likely was considered when forming this consensus. I believe the reason why is the items most affected by this issue are provided by the `alloc` crate, which is rarely used within embedded but extensively used within Bevy.
17 lines
650 B
Diff
17 lines
650 B
Diff
diff --git a/crates/bevy_window/src/window.rs b/crates/bevy_window/src/window.rs
|
|
index ccc861a78..0cae580cd 100644
|
|
--- a/crates/bevy_window/src/window.rs
|
|
+++ b/crates/bevy_window/src/window.rs
|
|
@@ -293,9 +293,9 @@ impl Default for Window {
|
|
transparent: false,
|
|
focused: true,
|
|
window_level: Default::default(),
|
|
- fit_canvas_to_parent: false,
|
|
+ fit_canvas_to_parent: true,
|
|
prevent_default_event_handling: true,
|
|
- canvas: None,
|
|
+ canvas: Some("#bevy".to_owned()),
|
|
window_theme: None,
|
|
visible: true,
|
|
skip_taskbar: false,
|