forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5f5876b1c9
bevy/crates
History
MichiRecRoom 5f5876b1c9
Change bevy_reflect::RegisterForReflection::__register() to expect unused variables, rather than putting underscores on the parameter names (#17171) 
# Objective
While checking over https://github.com/bevyengine/bevy/pull/17160, it
occurred to me that rust-analyzer will copy the method signature
exactly, when using tab completion trait methods. This includes provided
trait methods that use underscores to silence the `unused_variables`
lint. This probably isn't good for users, seeing as how they'll have to
remove the underscore if they want to use the parameters.

(I mean, they technically don't have to remove the underscore... but
usually you don't keep a leading underscore on parameters you're using.)

## Solution
Changes `bevy_reflect::RegisterForReflection::__register()` to
`#[expect(unused_variables)]`, and removes the underscores from its
parameter names.

## Testing
N/A
2025-01-05 20:27:20 +00:00
..
bevy_a11y bevy_a11y: Apply #[deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] (#17093) 2025-01-02 18:45:19 +00:00
bevy_animation bevy_animation: Apply #[deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] (#17094) 2025-01-02 18:45:05 +00:00
bevy_app Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_asset Do not lowercase asset file extensions (#17065) 2025-01-01 00:42:56 +00:00
bevy_audio Derived Default for all public unit components. (#17139) 2025-01-05 02:45:09 +00:00
bevy_color bevy_color: Apply #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] (#17090) 2025-01-05 02:01:20 +00:00
bevy_core_pipeline Update typos (#17126) 2025-01-03 17:44:26 +00:00
bevy_derive Add benchmarks and compile_fail tests back to workspace (#16858) 2024-12-21 22:30:29 +00:00
bevy_dev_tools Draw the UI debug overlay using the UI renderer (#16693) 2024-12-11 00:49:47 +00:00
bevy_diagnostic More combinator cleanup (#17148) 2025-01-05 02:44:29 +00:00
bevy_dylib Generate links to definition in source code pages on docs.rs and dev-docs.bevyengine.org (#12965) 2024-07-29 23:10:16 +00:00
bevy_ecs Optimize Entities::entity_does_not_exist_error_details_message, remove UnsafeWorldCell from error (#17115) 2025-01-05 02:01:01 +00:00
bevy_encase_derive Rust 1.83, allow -> expect (missing_docs) (#16561) 2024-12-16 23:27:57 +00:00
bevy_gilrs Deny derive_more error feature and replace it with thiserror (#16684) 2024-12-06 17:03:55 +00:00
bevy_gizmos Fix 2D Gizmos not always drawn on top (#17085) 2025-01-05 02:02:30 +00:00
bevy_gltf Prefer Display over Debug (#16112) 2024-12-27 00:40:06 +00:00
bevy_hierarchy Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_image Rust 1.83, allow -> expect (missing_docs) (#16561) 2024-12-16 23:27:57 +00:00
bevy_input Scale input to account for deadzones (#17015) 2025-01-03 22:27:59 +00:00
bevy_input_focus Return Result from tab navigation API (#17071) 2025-01-01 04:05:48 +00:00
bevy_internal Rename track_change_detection flag to track_location (#17075) 2025-01-01 18:43:47 +00:00
bevy_log Basic filtering examples for users of the bevy_log. (#16455) 2024-12-29 22:56:40 +00:00
bevy_macro_utils Use one BevyManifest instance in proc macros (#16766) 2024-12-15 15:00:05 +00:00
bevy_math Update typos (#17126) 2025-01-03 17:44:26 +00:00
bevy_mesh Rust 1.83, allow -> expect (missing_docs) (#16561) 2024-12-16 23:27:57 +00:00
bevy_mikktspace Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_pbr Derived Default for all public unit components. (#17139) 2025-01-05 02:45:09 +00:00
bevy_picking Update typos (#17126) 2025-01-03 17:44:26 +00:00
bevy_ptr Fix MSRVs for standalone crates (#16333) 2024-11-17 09:38:13 +00:00
bevy_reflect Change bevy_reflect::RegisterForReflection::__register() to expect unused variables, rather than putting underscores on the parameter names (#17171) 2025-01-05 20:27:20 +00:00
bevy_remote show these 'fully qualified paths' for bevy_remote's rpc (#16944) 2024-12-31 00:29:27 +00:00
bevy_render Derived Default for all public unit components. (#17139) 2025-01-05 02:45:09 +00:00
bevy_scene Replace map + unwrap_or(true) with is_none_or (#17070) 2024-12-31 20:17:03 +00:00
bevy_sprite Derived Default for all public unit components. (#17139) 2025-01-05 02:45:09 +00:00
bevy_state Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_tasks Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_text Revert "Fix sprite performance regression since retained render world (#17078)" (#17123) 2025-01-04 00:22:18 +00:00
bevy_time Use en-us locale for typos (#16037) 2024-10-20 18:55:17 +00:00
bevy_transform Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_ui Derived Default for all public unit components. (#17139) 2025-01-05 02:45:09 +00:00
bevy_utils Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
bevy_window Derived Default for all public unit components. (#17139) 2025-01-05 02:45:09 +00:00
bevy_winit Simplify sort/max_by calls (#17048) 2024-12-30 22:59:36 +00:00