
This pr uses the `extern crate self as` trick to make proc macros behave the same way inside and outside bevy. # Objective - Removes noise introduced by `crate as` in the whole bevy repo. - Fixes #17004. - Hardens proc macro path resolution. ## TODO - [x] `BevyManifest` needs cleanup. - [x] Cleanup remaining `crate as`. - [x] Add proper integration tests to the ci. ## Notes - `cargo-manifest-proc-macros` is written by me and based/inspired by the old `BevyManifest` implementation and [`bkchr/proc-macro-crate`](https://github.com/bkchr/proc-macro-crate). - What do you think about the new integration test machinery I added to the `ci`? More and better integration tests can be added at a later stage. The goal of these integration tests is to simulate an actual separate crate that uses bevy. Ideally they would lightly touch all bevy crates. ## Testing - Needs RA test - Needs testing from other users - Others need to run at least `cargo run -p ci integration-test` and verify that they work. --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
94 lines
4.5 KiB
Rust
94 lines
4.5 KiB
Rust
use bevy_macro_utils::fq_std::{FQClone, FQOption, FQResult};
|
|
use proc_macro::TokenStream;
|
|
use quote::quote;
|
|
use syn::{parse::Parse, parse_macro_input, Attribute, ItemTrait, Token};
|
|
|
|
pub(crate) struct TraitInfo {
|
|
item_trait: ItemTrait,
|
|
}
|
|
|
|
impl Parse for TraitInfo {
|
|
fn parse(input: syn::parse::ParseStream) -> syn::Result<Self> {
|
|
let attrs = input.call(Attribute::parse_outer)?;
|
|
let lookahead = input.lookahead1();
|
|
if lookahead.peek(Token![pub]) || lookahead.peek(Token![trait]) {
|
|
let mut item_trait: ItemTrait = input.parse()?;
|
|
item_trait.attrs = attrs;
|
|
Ok(TraitInfo { item_trait })
|
|
} else {
|
|
Err(lookahead.error())
|
|
}
|
|
}
|
|
}
|
|
|
|
/// A trait attribute macro that allows a reflected type to be downcast to a trait object.
|
|
///
|
|
/// This generates a struct that takes the form `ReflectMyTrait`. An instance of this struct can then be
|
|
/// used to perform the conversion.
|
|
pub(crate) fn reflect_trait(_args: &TokenStream, input: TokenStream) -> TokenStream {
|
|
let trait_info = parse_macro_input!(input as TraitInfo);
|
|
let item_trait = &trait_info.item_trait;
|
|
let trait_ident = &item_trait.ident;
|
|
let trait_vis = &item_trait.vis;
|
|
let reflect_trait_ident = crate::ident::get_reflect_ident(&item_trait.ident.to_string());
|
|
let bevy_reflect_path = crate::meta::get_bevy_reflect_path();
|
|
|
|
let struct_doc = format!(
|
|
" A type generated by the #[reflect_trait] macro for the `{trait_ident}` trait.\n\n This allows casting from `dyn Reflect` to `dyn {trait_ident}`.",
|
|
);
|
|
let get_doc = format!(
|
|
" Downcast a `&dyn Reflect` type to `&dyn {trait_ident}`.\n\n If the type cannot be downcast, `None` is returned.",
|
|
);
|
|
let get_mut_doc = format!(
|
|
" Downcast a `&mut dyn Reflect` type to `&mut dyn {trait_ident}`.\n\n If the type cannot be downcast, `None` is returned.",
|
|
);
|
|
let get_box_doc = format!(
|
|
" Downcast a `Box<dyn Reflect>` type to `Box<dyn {trait_ident}>`.\n\n If the type cannot be downcast, this will return `Err(Box<dyn Reflect>)`.",
|
|
);
|
|
|
|
TokenStream::from(quote! {
|
|
#item_trait
|
|
|
|
#[doc = #struct_doc]
|
|
#[derive(#FQClone)]
|
|
#trait_vis struct #reflect_trait_ident {
|
|
get_func: fn(&dyn #bevy_reflect_path::Reflect) -> #FQOption<&dyn #trait_ident>,
|
|
get_mut_func: fn(&mut dyn #bevy_reflect_path::Reflect) -> #FQOption<&mut dyn #trait_ident>,
|
|
get_boxed_func: fn(#bevy_reflect_path::__macro_exports::alloc_utils::Box<dyn #bevy_reflect_path::Reflect>) -> #FQResult<#bevy_reflect_path::__macro_exports::alloc_utils::Box<dyn #trait_ident>, #bevy_reflect_path::__macro_exports::alloc_utils::Box<dyn #bevy_reflect_path::Reflect>>,
|
|
}
|
|
|
|
impl #reflect_trait_ident {
|
|
#[doc = #get_doc]
|
|
pub fn get<'a>(&self, reflect_value: &'a dyn #bevy_reflect_path::Reflect) -> #FQOption<&'a dyn #trait_ident> {
|
|
(self.get_func)(reflect_value)
|
|
}
|
|
|
|
#[doc = #get_mut_doc]
|
|
pub fn get_mut<'a>(&self, reflect_value: &'a mut dyn #bevy_reflect_path::Reflect) -> #FQOption<&'a mut dyn #trait_ident> {
|
|
(self.get_mut_func)(reflect_value)
|
|
}
|
|
|
|
#[doc = #get_box_doc]
|
|
pub fn get_boxed(&self, reflect_value: #bevy_reflect_path::__macro_exports::alloc_utils::Box<dyn #bevy_reflect_path::Reflect>) -> #FQResult<#bevy_reflect_path::__macro_exports::alloc_utils::Box<dyn #trait_ident>, #bevy_reflect_path::__macro_exports::alloc_utils::Box<dyn #bevy_reflect_path::Reflect>> {
|
|
(self.get_boxed_func)(reflect_value)
|
|
}
|
|
}
|
|
|
|
impl<T: #trait_ident + #bevy_reflect_path::Reflect> #bevy_reflect_path::FromType<T> for #reflect_trait_ident {
|
|
fn from_type() -> Self {
|
|
Self {
|
|
get_func: |reflect_value| {
|
|
<dyn #bevy_reflect_path::Reflect>::downcast_ref::<T>(reflect_value).map(|value| value as &dyn #trait_ident)
|
|
},
|
|
get_mut_func: |reflect_value| {
|
|
<dyn #bevy_reflect_path::Reflect>::downcast_mut::<T>(reflect_value).map(|value| value as &mut dyn #trait_ident)
|
|
},
|
|
get_boxed_func: |reflect_value| {
|
|
<dyn #bevy_reflect_path::Reflect>::downcast::<T>(reflect_value).map(|value| value as #bevy_reflect_path::__macro_exports::alloc_utils::Box<dyn #trait_ident>)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
})
|
|
}
|