# Objective - There are several redundant imports in the tests and examples that are not caught by CI because additional flags need to be passed. ## Solution - Run `cargo check --workspace --tests` and `cargo check --workspace --examples`, then fix all warnings. - Add `test-check` to CI, which will be run in the check-compiles job. This should catch future warnings for tests. Examples are already checked, but I'm not yet sure why they weren't caught. ## Discussion - Should the `--tests` and `--examples` flags be added to CI, so this is caught in the future? - If so, #12818 will need to be merged first. It was also a warning raised by checking the examples, but I chose to split off into a separate PR. --------- Co-authored-by: François Mockers <francois.mockers@vleue.com>
		
			
				
	
	
		
			74 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			74 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
//! Skinned mesh example with mesh and joints data loaded from a glTF file.
 | 
						|
//! Example taken from <https://github.com/KhronosGroup/glTF-Tutorials/blob/master/gltfTutorial/gltfTutorial_019_SimpleSkin.md>
 | 
						|
 | 
						|
use std::f32::consts::*;
 | 
						|
 | 
						|
use bevy::{prelude::*, render::mesh::skinning::SkinnedMesh};
 | 
						|
 | 
						|
fn main() {
 | 
						|
    App::new()
 | 
						|
        .add_plugins(DefaultPlugins)
 | 
						|
        .insert_resource(AmbientLight {
 | 
						|
            brightness: 750.0,
 | 
						|
            ..default()
 | 
						|
        })
 | 
						|
        .add_systems(Startup, setup)
 | 
						|
        .add_systems(Update, joint_animation)
 | 
						|
        .run();
 | 
						|
}
 | 
						|
 | 
						|
fn setup(mut commands: Commands, asset_server: Res<AssetServer>) {
 | 
						|
    // Create a camera
 | 
						|
    commands.spawn(Camera3dBundle {
 | 
						|
        transform: Transform::from_xyz(-2.0, 2.5, 5.0)
 | 
						|
            .looking_at(Vec3::new(0.0, 1.0, 0.0), Vec3::Y),
 | 
						|
        ..default()
 | 
						|
    });
 | 
						|
 | 
						|
    // Spawn the first scene in `models/SimpleSkin/SimpleSkin.gltf`
 | 
						|
    commands.spawn(SceneBundle {
 | 
						|
        scene: asset_server.load("models/SimpleSkin/SimpleSkin.gltf#Scene0"),
 | 
						|
        ..default()
 | 
						|
    });
 | 
						|
}
 | 
						|
 | 
						|
/// The scene hierarchy currently looks somewhat like this:
 | 
						|
///
 | 
						|
/// ```text
 | 
						|
/// <Parent entity>
 | 
						|
///   + Mesh node (without `PbrBundle` or `SkinnedMesh` component)
 | 
						|
///     + Skinned mesh entity (with `PbrBundle` and `SkinnedMesh` component, created by glTF loader)
 | 
						|
///     + First joint
 | 
						|
///       + Second joint
 | 
						|
/// ```
 | 
						|
///
 | 
						|
/// In this example, we want to get and animate the second joint.
 | 
						|
/// It is similar to the animation defined in `models/SimpleSkin/SimpleSkin.gltf`.
 | 
						|
fn joint_animation(
 | 
						|
    time: Res<Time>,
 | 
						|
    parent_query: Query<&Parent, With<SkinnedMesh>>,
 | 
						|
    children_query: Query<&Children>,
 | 
						|
    mut transform_query: Query<&mut Transform>,
 | 
						|
) {
 | 
						|
    // Iter skinned mesh entity
 | 
						|
    for skinned_mesh_parent in &parent_query {
 | 
						|
        // Mesh node is the parent of the skinned mesh entity.
 | 
						|
        let mesh_node_entity = skinned_mesh_parent.get();
 | 
						|
        // Get `Children` in the mesh node.
 | 
						|
        let mesh_node_children = children_query.get(mesh_node_entity).unwrap();
 | 
						|
 | 
						|
        // First joint is the second child of the mesh node.
 | 
						|
        let first_joint_entity = mesh_node_children[1];
 | 
						|
        // Get `Children` in the first joint.
 | 
						|
        let first_joint_children = children_query.get(first_joint_entity).unwrap();
 | 
						|
 | 
						|
        // Second joint is the first child of the first joint.
 | 
						|
        let second_joint_entity = first_joint_children[0];
 | 
						|
        // Get `Transform` in the second joint.
 | 
						|
        let mut second_joint_transform = transform_query.get_mut(second_joint_entity).unwrap();
 | 
						|
 | 
						|
        second_joint_transform.rotation =
 | 
						|
            Quat::from_rotation_z(FRAC_PI_2 * time.elapsed_seconds().sin());
 | 
						|
    }
 | 
						|
}
 |