#14143 - fix bevy_ui padding (#14777)
# Objective
fixes #14143
## Solution
- removed the temporary blocker if statement when setting padding in
`Style`
- adjusted the `layout_location` and `layout_size` so they use
`layout.padding` which we already get from Taffy
## Testing
- this is the test code I used:
```rust
use bevy::prelude::*;
fn main() {
App::new()
.add_plugins(DefaultPlugins)
.add_systems(Startup, setup)
.run();
}
fn setup(
mut commands: Commands,
asset_server: Res<AssetServer>,
){
let font = asset_server.load("fonts/FiraSans-Bold.ttf");
commands.spawn(Camera2dBundle::default());
commands
.spawn(NodeBundle {
style: Style {
width: Val::Px(200.),
height: Val::Px(100.),
align_items: AlignItems::Center,
justify_content: JustifyContent::Center,
align_self: AlignSelf::Center,
justify_self: JustifySelf::Center,
..Default::default()
},
background_color: BackgroundColor(Color::srgb(0.,1., 1.)),
..Default::default()
})
.with_children(|builder| {
builder.spawn((TextBundle::from_section(
"Hello World",
TextStyle {
font,
font_size: 32.0,
color: Color::WHITE,
},
).with_style(Style {
padding: UiRect::all(Val::Px(10.)),
width: Val::Px(100.),
height: Val::Px(100.),
..Default::default()
}).with_background_color(Color::srgb(1.,0., 0.)),
));
// spawn an image bundle
builder.spawn(ImageBundle {
style: Style {
padding: UiRect::all(Val::Px(10.)),
width: Val::Px(100.),
height: Val::Px(100.),
..Default::default()
},
image: asset_server.load("square.png").into(),
..Default::default()
});
});
}
```
- I tested 5 cases: 10px padding from all sides, and 10px padding from
left, right, bottom, and top separately
- **For reviewers**: please check more cases or try to run it on some
more complicated real-world UI
## Showcase
<img width="374" alt="Screenshot 2024-08-16 at 09 28 04"
src="https://github.com/user-attachments/assets/59b85b00-e255-4669-be13-a287ef35d4d9">
<img width="288" alt="Screenshot 2024-08-16 at 09 28 47"
src="https://github.com/user-attachments/assets/170a79b1-ec9c-45f9-82f5-ba7fa4029334">
<img width="274" alt="Screenshot 2024-08-16 at 09 45 16"
src="https://github.com/user-attachments/assets/e3fd9b59-b41f-427d-8c07-5acdf1dc5ecf">
<img width="292" alt="Screenshot 2024-08-16 at 09 45 36"
src="https://github.com/user-attachments/assets/c4f708aa-3f0d-4ff3-b779-0d4ed5f6ba73">
<img width="261" alt="Screenshot 2024-08-16 at 09 45 58"
src="https://github.com/user-attachments/assets/eba1e26f-04ca-4178-87c8-3a79daff3a9a">
---------
Co-authored-by: dpeke <dpekelis@funstage.com>
6a4b48ba6b