# Objective
Replace instances of
```rust
for x in collection.iter{_mut}() {
```
with
```rust
for x in &{mut} collection {
```
This also changes CI to no longer suppress this lint. Note that since
this lint only shows up when using clippy in pedantic mode, it was
probably unnecessary to suppress this lint in the first place.
258 lines
9.7 KiB
Rust
258 lines
9.7 KiB
Rust
use bevy_asset::{AssetId, Assets};
|
|
use bevy_log::{debug, error, warn};
|
|
use bevy_math::{Rect, UVec2, Vec2};
|
|
use bevy_render::{
|
|
render_resource::{Extent3d, TextureDimension, TextureFormat},
|
|
texture::{Image, TextureFormatPixelInfo},
|
|
};
|
|
use bevy_utils::HashMap;
|
|
use rectangle_pack::{
|
|
contains_smallest_box, pack_rects, volume_heuristic, GroupedRectsToPlace, PackedLocation,
|
|
RectToInsert, TargetBin,
|
|
};
|
|
use thiserror::Error;
|
|
|
|
use crate::texture_atlas::TextureAtlas;
|
|
|
|
#[derive(Debug, Error)]
|
|
pub enum TextureAtlasBuilderError {
|
|
#[error("could not pack textures into an atlas within the given bounds")]
|
|
NotEnoughSpace,
|
|
#[error("added a texture with the wrong format in an atlas")]
|
|
WrongFormat,
|
|
}
|
|
|
|
#[derive(Debug)]
|
|
#[must_use]
|
|
/// A builder which is used to create a texture atlas from many individual
|
|
/// sprites.
|
|
pub struct TextureAtlasBuilder {
|
|
/// The grouped rects which must be placed with a key value pair of a
|
|
/// texture handle to an index.
|
|
rects_to_place: GroupedRectsToPlace<AssetId<Image>>,
|
|
/// The initial atlas size in pixels.
|
|
initial_size: Vec2,
|
|
/// The absolute maximum size of the texture atlas in pixels.
|
|
max_size: Vec2,
|
|
/// The texture format for the textures that will be loaded in the atlas.
|
|
format: TextureFormat,
|
|
/// Enable automatic format conversion for textures if they are not in the atlas format.
|
|
auto_format_conversion: bool,
|
|
/// The amount of padding in pixels to add along the right and bottom edges of the texture rects.
|
|
padding: UVec2,
|
|
}
|
|
|
|
impl Default for TextureAtlasBuilder {
|
|
fn default() -> Self {
|
|
Self {
|
|
rects_to_place: GroupedRectsToPlace::new(),
|
|
initial_size: Vec2::new(256., 256.),
|
|
max_size: Vec2::new(2048., 2048.),
|
|
format: TextureFormat::Rgba8UnormSrgb,
|
|
auto_format_conversion: true,
|
|
padding: UVec2::ZERO,
|
|
}
|
|
}
|
|
}
|
|
|
|
pub type TextureAtlasBuilderResult<T> = Result<T, TextureAtlasBuilderError>;
|
|
|
|
impl TextureAtlasBuilder {
|
|
/// Sets the initial size of the atlas in pixels.
|
|
pub fn initial_size(mut self, size: Vec2) -> Self {
|
|
self.initial_size = size;
|
|
self
|
|
}
|
|
|
|
/// Sets the max size of the atlas in pixels.
|
|
pub fn max_size(mut self, size: Vec2) -> Self {
|
|
self.max_size = size;
|
|
self
|
|
}
|
|
|
|
/// Sets the texture format for textures in the atlas.
|
|
pub fn format(mut self, format: TextureFormat) -> Self {
|
|
self.format = format;
|
|
self
|
|
}
|
|
|
|
/// Control whether the added texture should be converted to the atlas format, if different.
|
|
pub fn auto_format_conversion(mut self, auto_format_conversion: bool) -> Self {
|
|
self.auto_format_conversion = auto_format_conversion;
|
|
self
|
|
}
|
|
|
|
/// Adds a texture to be copied to the texture atlas.
|
|
pub fn add_texture(&mut self, image_id: AssetId<Image>, texture: &Image) {
|
|
self.rects_to_place.push_rect(
|
|
image_id,
|
|
None,
|
|
RectToInsert::new(
|
|
texture.texture_descriptor.size.width + self.padding.x,
|
|
texture.texture_descriptor.size.height + self.padding.y,
|
|
1,
|
|
),
|
|
);
|
|
}
|
|
|
|
/// Sets the amount of padding in pixels to add between the textures in the texture atlas.
|
|
///
|
|
/// The `x` value provide will be added to the right edge, while the `y` value will be added to the bottom edge.
|
|
pub fn padding(mut self, padding: UVec2) -> Self {
|
|
self.padding = padding;
|
|
self
|
|
}
|
|
|
|
fn copy_texture_to_atlas(
|
|
atlas_texture: &mut Image,
|
|
texture: &Image,
|
|
packed_location: &PackedLocation,
|
|
padding: UVec2,
|
|
) {
|
|
let rect_width = (packed_location.width() - padding.x) as usize;
|
|
let rect_height = (packed_location.height() - padding.y) as usize;
|
|
let rect_x = packed_location.x() as usize;
|
|
let rect_y = packed_location.y() as usize;
|
|
let atlas_width = atlas_texture.texture_descriptor.size.width as usize;
|
|
let format_size = atlas_texture.texture_descriptor.format.pixel_size();
|
|
|
|
for (texture_y, bound_y) in (rect_y..rect_y + rect_height).enumerate() {
|
|
let begin = (bound_y * atlas_width + rect_x) * format_size;
|
|
let end = begin + rect_width * format_size;
|
|
let texture_begin = texture_y * rect_width * format_size;
|
|
let texture_end = texture_begin + rect_width * format_size;
|
|
atlas_texture.data[begin..end]
|
|
.copy_from_slice(&texture.data[texture_begin..texture_end]);
|
|
}
|
|
}
|
|
|
|
fn copy_converted_texture(
|
|
&self,
|
|
atlas_texture: &mut Image,
|
|
texture: &Image,
|
|
packed_location: &PackedLocation,
|
|
) {
|
|
if self.format == texture.texture_descriptor.format {
|
|
Self::copy_texture_to_atlas(atlas_texture, texture, packed_location, self.padding);
|
|
} else if let Some(converted_texture) = texture.convert(self.format) {
|
|
debug!(
|
|
"Converting texture from '{:?}' to '{:?}'",
|
|
texture.texture_descriptor.format, self.format
|
|
);
|
|
Self::copy_texture_to_atlas(
|
|
atlas_texture,
|
|
&converted_texture,
|
|
packed_location,
|
|
self.padding,
|
|
);
|
|
} else {
|
|
error!(
|
|
"Error converting texture from '{:?}' to '{:?}', ignoring",
|
|
texture.texture_descriptor.format, self.format
|
|
);
|
|
}
|
|
}
|
|
|
|
/// Consumes the builder and returns a result with a new texture atlas.
|
|
///
|
|
/// Internally it copies all rectangles from the textures and copies them
|
|
/// into a new texture which the texture atlas will use. It is not useful to
|
|
/// hold a strong handle to the texture afterwards else it will exist twice
|
|
/// in memory.
|
|
///
|
|
/// # Errors
|
|
///
|
|
/// If there is not enough space in the atlas texture, an error will
|
|
/// be returned. It is then recommended to make a larger sprite sheet.
|
|
pub fn finish(
|
|
self,
|
|
textures: &mut Assets<Image>,
|
|
) -> Result<TextureAtlas, TextureAtlasBuilderError> {
|
|
let initial_width = self.initial_size.x as u32;
|
|
let initial_height = self.initial_size.y as u32;
|
|
let max_width = self.max_size.x as u32;
|
|
let max_height = self.max_size.y as u32;
|
|
|
|
let mut current_width = initial_width;
|
|
let mut current_height = initial_height;
|
|
let mut rect_placements = None;
|
|
let mut atlas_texture = Image::default();
|
|
|
|
while rect_placements.is_none() {
|
|
if current_width > max_width || current_height > max_height {
|
|
break;
|
|
}
|
|
|
|
let last_attempt = current_height == max_height && current_width == max_width;
|
|
|
|
let mut target_bins = std::collections::BTreeMap::new();
|
|
target_bins.insert(0, TargetBin::new(current_width, current_height, 1));
|
|
rect_placements = match pack_rects(
|
|
&self.rects_to_place,
|
|
&mut target_bins,
|
|
&volume_heuristic,
|
|
&contains_smallest_box,
|
|
) {
|
|
Ok(rect_placements) => {
|
|
atlas_texture = Image::new(
|
|
Extent3d {
|
|
width: current_width,
|
|
height: current_height,
|
|
depth_or_array_layers: 1,
|
|
},
|
|
TextureDimension::D2,
|
|
vec![
|
|
0;
|
|
self.format.pixel_size() * (current_width * current_height) as usize
|
|
],
|
|
self.format,
|
|
);
|
|
Some(rect_placements)
|
|
}
|
|
Err(rectangle_pack::RectanglePackError::NotEnoughBinSpace) => {
|
|
current_height = (current_height * 2).clamp(0, max_height);
|
|
current_width = (current_width * 2).clamp(0, max_width);
|
|
None
|
|
}
|
|
};
|
|
|
|
if last_attempt {
|
|
break;
|
|
}
|
|
}
|
|
|
|
let rect_placements = rect_placements.ok_or(TextureAtlasBuilderError::NotEnoughSpace)?;
|
|
|
|
let mut texture_rects = Vec::with_capacity(rect_placements.packed_locations().len());
|
|
let mut texture_ids = HashMap::default();
|
|
for (image_id, (_, packed_location)) in rect_placements.packed_locations() {
|
|
let texture = textures.get(*image_id).unwrap();
|
|
let min = Vec2::new(packed_location.x() as f32, packed_location.y() as f32);
|
|
let max = min
|
|
+ Vec2::new(
|
|
(packed_location.width() - self.padding.x) as f32,
|
|
(packed_location.height() - self.padding.y) as f32,
|
|
);
|
|
texture_ids.insert(*image_id, texture_rects.len());
|
|
texture_rects.push(Rect { min, max });
|
|
if texture.texture_descriptor.format != self.format && !self.auto_format_conversion {
|
|
warn!(
|
|
"Loading a texture of format '{:?}' in an atlas with format '{:?}'",
|
|
texture.texture_descriptor.format, self.format
|
|
);
|
|
return Err(TextureAtlasBuilderError::WrongFormat);
|
|
}
|
|
self.copy_converted_texture(&mut atlas_texture, texture, packed_location);
|
|
}
|
|
Ok(TextureAtlas {
|
|
size: Vec2::new(
|
|
atlas_texture.texture_descriptor.size.width as f32,
|
|
atlas_texture.texture_descriptor.size.height as f32,
|
|
),
|
|
texture: textures.add(atlas_texture),
|
|
textures: texture_rects,
|
|
texture_handles: Some(texture_ids),
|
|
})
|
|
}
|
|
}
|