
`ArchetypeAccess` was tracking `immutable` and `mutable` separately. This means that checking is_compatible requires three checks: m+m, m+i, i+m. Instead, continue tracking `mutable` accesses, but instead of `immutable` track `immutable | mutable` as another `accessed` bit mask. This drops the comparisons to two (m+a, a+m) and turns out to be what the rest of the code base wants too, unifying various duplicated checks and loops.
483 lines
15 KiB
Rust
483 lines
15 KiB
Rust
use crate::ArchetypeAccess;
|
|
use bevy_hecs::{
|
|
Archetype, Component, ComponentError, Entity, Fetch, Query as HecsQuery, Ref, RefMut, With,
|
|
Without, World,
|
|
};
|
|
use bevy_tasks::ParallelIterator;
|
|
use std::{fmt, marker::PhantomData};
|
|
|
|
/// Provides scoped access to a World according to a given [HecsQuery]
|
|
#[derive(Debug)]
|
|
pub struct Query<'a, Q: HecsQuery> {
|
|
pub(crate) world: &'a World,
|
|
pub(crate) archetype_access: &'a ArchetypeAccess,
|
|
_marker: PhantomData<Q>,
|
|
}
|
|
|
|
/// An error that occurs when using a [Query]
|
|
#[derive(Debug)]
|
|
pub enum QueryError {
|
|
CannotReadArchetype,
|
|
CannotWriteArchetype,
|
|
ComponentError(ComponentError),
|
|
NoSuchEntity,
|
|
}
|
|
|
|
impl<'a, Q: HecsQuery> Query<'a, Q> {
|
|
#[inline]
|
|
pub fn new(world: &'a World, archetype_access: &'a ArchetypeAccess) -> Self {
|
|
Self {
|
|
world,
|
|
archetype_access,
|
|
_marker: PhantomData::default(),
|
|
}
|
|
}
|
|
|
|
#[inline]
|
|
pub fn iter(&mut self) -> QueryBorrowChecked<'_, Q> {
|
|
QueryBorrowChecked::new(&self.world.archetypes, self.archetype_access)
|
|
}
|
|
|
|
// TODO: find a way to make `iter`, `get`, `get_mut`, and `entity` safe without using tracking pointers with global locks
|
|
|
|
/// Gets a reference to the entity's component of the given type. This will fail if the entity does not have
|
|
/// the given component type or if the given component type does not match this query.
|
|
pub fn get<T: Component>(&self, entity: Entity) -> Result<Ref<T>, QueryError> {
|
|
if let Some(location) = self.world.get_entity_location(entity) {
|
|
if self
|
|
.archetype_access
|
|
.accessed
|
|
.contains(location.archetype as usize)
|
|
{
|
|
// SAFE: we have already checked that the entity/component matches our archetype access. and systems are scheduled to run with safe archetype access
|
|
unsafe {
|
|
self.world
|
|
.get_ref_at_location_unchecked(location)
|
|
.map_err(QueryError::ComponentError)
|
|
}
|
|
} else {
|
|
Err(QueryError::CannotReadArchetype)
|
|
}
|
|
} else {
|
|
Err(QueryError::ComponentError(ComponentError::NoSuchEntity))
|
|
}
|
|
}
|
|
|
|
pub fn entity(&mut self, entity: Entity) -> Result<QueryOneChecked<'_, Q>, QueryError> {
|
|
if let Some(location) = self.world.get_entity_location(entity) {
|
|
if self
|
|
.archetype_access
|
|
.accessed
|
|
.contains(location.archetype as usize)
|
|
{
|
|
// SAFE: we have already checked that the entity matches our archetype. and systems are scheduled to run with safe archetype access
|
|
Ok(unsafe {
|
|
QueryOneChecked::new(
|
|
&self.world.archetypes[location.archetype as usize],
|
|
location.index,
|
|
)
|
|
})
|
|
} else {
|
|
Err(QueryError::CannotReadArchetype)
|
|
}
|
|
} else {
|
|
Err(QueryError::NoSuchEntity)
|
|
}
|
|
}
|
|
|
|
/// Gets a mutable reference to the entity's component of the given type. This will fail if the entity does not have
|
|
/// the given component type or if the given component type does not match this query.
|
|
pub fn get_mut<T: Component>(&self, entity: Entity) -> Result<RefMut<'_, T>, QueryError> {
|
|
let location = match self.world.get_entity_location(entity) {
|
|
None => return Err(QueryError::ComponentError(ComponentError::NoSuchEntity)),
|
|
Some(location) => location,
|
|
};
|
|
|
|
if self
|
|
.archetype_access
|
|
.mutable
|
|
.contains(location.archetype as usize)
|
|
{
|
|
// SAFE: RefMut does exclusivity checks and we have already validated the entity
|
|
unsafe {
|
|
self.world
|
|
.get_ref_mut_at_location_unchecked(location)
|
|
.map_err(QueryError::ComponentError)
|
|
}
|
|
} else {
|
|
Err(QueryError::CannotWriteArchetype)
|
|
}
|
|
}
|
|
|
|
pub fn removed<C: Component>(&self) -> &[Entity] {
|
|
self.world.removed::<C>()
|
|
}
|
|
|
|
/// Sets the entity's component to the given value. This will fail if the entity does not already have
|
|
/// the given component type or if the given component type does not match this query.
|
|
pub fn set<T: Component>(&mut self, entity: Entity, component: T) -> Result<(), QueryError> {
|
|
let mut current = self.get_mut::<T>(entity)?;
|
|
*current = component;
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
/// A borrow of a `World` sufficient to execute the query `Q`
|
|
///
|
|
/// Note that borrows are not released until this object is dropped.
|
|
pub struct QueryBorrowChecked<'w, Q: HecsQuery> {
|
|
archetypes: &'w [Archetype],
|
|
archetype_access: &'w ArchetypeAccess,
|
|
borrowed: bool,
|
|
_marker: PhantomData<Q>,
|
|
}
|
|
|
|
impl<'w, Q: HecsQuery> fmt::Debug for QueryBorrowChecked<'w, Q> {
|
|
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
|
|
f.debug_struct("QueryBorrowChecked")
|
|
.field("archetypes", &self.archetypes)
|
|
.field("archetype_access", self.archetype_access)
|
|
.field("borrowed", &self.borrowed)
|
|
.field("_marker", &self._marker)
|
|
.finish()
|
|
}
|
|
}
|
|
|
|
impl<'w, Q: HecsQuery> QueryBorrowChecked<'w, Q> {
|
|
pub(crate) fn new(archetypes: &'w [Archetype], archetype_access: &'w ArchetypeAccess) -> Self {
|
|
Self {
|
|
archetypes,
|
|
borrowed: false,
|
|
archetype_access,
|
|
_marker: PhantomData,
|
|
}
|
|
}
|
|
|
|
/// Execute the query
|
|
///
|
|
/// Must be called only once per query.
|
|
#[inline]
|
|
pub fn iter<'q>(&'q mut self) -> QueryIter<'q, 'w, Q> {
|
|
self.borrow();
|
|
QueryIter {
|
|
borrow: self,
|
|
archetype_index: 0,
|
|
iter: None,
|
|
}
|
|
}
|
|
|
|
/// Like `iter`, but returns child iterators of at most `batch_size`
|
|
/// elements
|
|
///
|
|
/// Useful for distributing work over a threadpool using the
|
|
/// ParallelIterator interface.
|
|
///
|
|
/// Batch size needs to be chosen based on the task being done in
|
|
/// parallel. The elements in each batch are computed serially, while
|
|
/// the batches themselves are computed in parallel.
|
|
///
|
|
/// A too small batch size can cause too much overhead, since scheduling
|
|
/// each batch could take longer than running the batch. On the other
|
|
/// hand, a too large batch size risks that one batch is still running
|
|
/// long after the rest have finished.
|
|
pub fn par_iter<'q>(&'q mut self, batch_size: usize) -> ParIter<'q, 'w, Q> {
|
|
self.borrow();
|
|
ParIter {
|
|
borrow: self,
|
|
archetype_index: 0,
|
|
batch_size,
|
|
batch: 0,
|
|
}
|
|
}
|
|
|
|
fn borrow(&mut self) {
|
|
if self.borrowed {
|
|
panic!(
|
|
"called QueryBorrowChecked::iter twice on the same borrow; construct a new query instead"
|
|
);
|
|
}
|
|
|
|
for index in self.archetype_access.accessed.ones() {
|
|
Q::Fetch::borrow(&self.archetypes[index]);
|
|
}
|
|
|
|
self.borrowed = true;
|
|
}
|
|
}
|
|
|
|
unsafe impl<'w, Q: HecsQuery> Send for QueryBorrowChecked<'w, Q> {}
|
|
unsafe impl<'w, Q: HecsQuery> Sync for QueryBorrowChecked<'w, Q> {}
|
|
|
|
impl<'w, Q: HecsQuery> Drop for QueryBorrowChecked<'w, Q> {
|
|
#[inline]
|
|
fn drop(&mut self) {
|
|
if self.borrowed {
|
|
for index in self.archetype_access.accessed.ones() {
|
|
Q::Fetch::release(&self.archetypes[index]);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<'q, 'w, Q: HecsQuery> IntoIterator for &'q mut QueryBorrowChecked<'w, Q> {
|
|
type IntoIter = QueryIter<'q, 'w, Q>;
|
|
type Item = <Q::Fetch as Fetch<'q>>::Item;
|
|
|
|
#[inline]
|
|
fn into_iter(self) -> Self::IntoIter {
|
|
self.iter()
|
|
}
|
|
}
|
|
|
|
/// Iterator over the set of entities with the components in `Q`
|
|
pub struct QueryIter<'q, 'w, Q: HecsQuery> {
|
|
borrow: &'q mut QueryBorrowChecked<'w, Q>,
|
|
archetype_index: usize,
|
|
iter: Option<ChunkIter<Q>>,
|
|
}
|
|
|
|
impl<'q, 'w, Q: HecsQuery> fmt::Debug for QueryIter<'q, 'w, Q>
|
|
where
|
|
Q::Fetch: fmt::Debug,
|
|
{
|
|
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
|
|
f.debug_struct("QueryIter")
|
|
.field("borrow", self.borrow)
|
|
.field("archetype_index", &self.archetype_index)
|
|
.field("iter", &self.iter)
|
|
.finish()
|
|
}
|
|
}
|
|
|
|
unsafe impl<'q, 'w, Q: HecsQuery> Send for QueryIter<'q, 'w, Q> {}
|
|
unsafe impl<'q, 'w, Q: HecsQuery> Sync for QueryIter<'q, 'w, Q> {}
|
|
|
|
impl<'q, 'w, Q: HecsQuery> Iterator for QueryIter<'q, 'w, Q> {
|
|
type Item = <Q::Fetch as Fetch<'q>>::Item;
|
|
|
|
#[inline]
|
|
fn next(&mut self) -> Option<Self::Item> {
|
|
loop {
|
|
match self.iter {
|
|
None => {
|
|
let archetype = self.borrow.archetypes.get(self.archetype_index as usize)?;
|
|
self.archetype_index += 1;
|
|
unsafe {
|
|
self.iter = Q::Fetch::get(archetype, 0).map(|fetch| ChunkIter {
|
|
fetch,
|
|
len: archetype.len(),
|
|
});
|
|
}
|
|
}
|
|
Some(ref mut iter) => match unsafe { iter.next() } {
|
|
None => {
|
|
self.iter = None;
|
|
continue;
|
|
}
|
|
Some(components) => {
|
|
return Some(components);
|
|
}
|
|
},
|
|
}
|
|
}
|
|
}
|
|
|
|
fn size_hint(&self) -> (usize, Option<usize>) {
|
|
let n = self.len();
|
|
(n, Some(n))
|
|
}
|
|
}
|
|
|
|
impl<'q, 'w, Q: HecsQuery> ExactSizeIterator for QueryIter<'q, 'w, Q> {
|
|
fn len(&self) -> usize {
|
|
self.borrow
|
|
.archetypes
|
|
.iter()
|
|
.filter(|&x| Q::Fetch::access(x).is_some())
|
|
.map(|x| x.len())
|
|
.sum()
|
|
}
|
|
}
|
|
|
|
struct ChunkIter<Q: HecsQuery> {
|
|
fetch: Q::Fetch,
|
|
len: usize,
|
|
}
|
|
|
|
impl<Q: HecsQuery> fmt::Debug for ChunkIter<Q>
|
|
where
|
|
Q::Fetch: fmt::Debug,
|
|
{
|
|
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
|
|
f.debug_struct("ChunkIter")
|
|
.field("fetch", &self.fetch)
|
|
.field("len", &self.len)
|
|
.finish()
|
|
}
|
|
}
|
|
|
|
impl<Q: HecsQuery> ChunkIter<Q> {
|
|
#[inline]
|
|
unsafe fn next<'a>(&mut self) -> Option<<Q::Fetch as Fetch<'a>>::Item> {
|
|
loop {
|
|
if self.len == 0 {
|
|
return None;
|
|
}
|
|
|
|
self.len -= 1;
|
|
if self.fetch.should_skip() {
|
|
// we still need to progress the iterator
|
|
let _ = self.fetch.next();
|
|
continue;
|
|
}
|
|
|
|
break Some(self.fetch.next());
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Batched version of `QueryIter`
|
|
pub struct ParIter<'q, 'w, Q: HecsQuery> {
|
|
borrow: &'q mut QueryBorrowChecked<'w, Q>,
|
|
archetype_index: usize,
|
|
batch_size: usize,
|
|
batch: usize,
|
|
}
|
|
|
|
impl<'q, 'w, Q: HecsQuery> ParallelIterator<Batch<'q, Q>> for ParIter<'q, 'w, Q> {
|
|
type Item = <Q::Fetch as Fetch<'q>>::Item;
|
|
|
|
fn next_batch(&mut self) -> Option<Batch<'q, Q>> {
|
|
loop {
|
|
let archetype = self.borrow.archetypes.get(self.archetype_index)?;
|
|
let offset = self.batch_size * self.batch;
|
|
if offset >= archetype.len() {
|
|
self.archetype_index += 1;
|
|
self.batch = 0;
|
|
continue;
|
|
}
|
|
if let Some(fetch) = unsafe { Q::Fetch::get(archetype, offset as usize) } {
|
|
self.batch += 1;
|
|
return Some(Batch {
|
|
_marker: PhantomData,
|
|
state: ChunkIter {
|
|
fetch,
|
|
len: self.batch_size.min(archetype.len() - offset),
|
|
},
|
|
});
|
|
} else {
|
|
self.archetype_index += 1;
|
|
debug_assert_eq!(
|
|
self.batch, 0,
|
|
"query fetch should always reject at the first batch or not at all"
|
|
);
|
|
continue;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
/// A sequence of entities yielded by `ParIter`
|
|
pub struct Batch<'q, Q: HecsQuery> {
|
|
_marker: PhantomData<&'q ()>,
|
|
state: ChunkIter<Q>,
|
|
}
|
|
|
|
impl<'q, Q: HecsQuery> fmt::Debug for Batch<'q, Q>
|
|
where
|
|
Q::Fetch: fmt::Debug,
|
|
{
|
|
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
|
|
f.debug_struct("Batch")
|
|
.field("_marker", &self._marker)
|
|
.field("state", &self.state)
|
|
.finish()
|
|
}
|
|
}
|
|
|
|
impl<'q, 'w, Q: HecsQuery> Iterator for Batch<'q, Q> {
|
|
type Item = <Q::Fetch as Fetch<'q>>::Item;
|
|
|
|
fn next(&mut self) -> Option<Self::Item> {
|
|
let components = unsafe { self.state.next()? };
|
|
Some(components)
|
|
}
|
|
}
|
|
|
|
unsafe impl<'q, Q: HecsQuery> Send for Batch<'q, Q> {}
|
|
|
|
/// A borrow of a `World` sufficient to execute the query `Q` on a single entity
|
|
#[derive(Debug)]
|
|
pub struct QueryOneChecked<'a, Q: HecsQuery> {
|
|
archetype: &'a Archetype,
|
|
index: usize,
|
|
borrowed: bool,
|
|
_marker: PhantomData<Q>,
|
|
}
|
|
|
|
impl<'a, Q: HecsQuery> QueryOneChecked<'a, Q> {
|
|
/// Construct a query accessing the entity in `archetype` at `index`
|
|
///
|
|
/// # Safety
|
|
///
|
|
/// `index` must be in-bounds for `archetype`
|
|
pub(crate) unsafe fn new(archetype: &'a Archetype, index: usize) -> Self {
|
|
Self {
|
|
archetype,
|
|
index,
|
|
borrowed: false,
|
|
_marker: PhantomData,
|
|
}
|
|
}
|
|
|
|
/// Get the query result, or `None` if the entity does not satisfy the query
|
|
///
|
|
/// Must be called at most once.
|
|
///
|
|
/// Panics if called more than once or if it would construct a borrow that clashes with another
|
|
/// pre-existing borrow.
|
|
pub fn get(&mut self) -> Option<<Q::Fetch as Fetch<'_>>::Item> {
|
|
unsafe {
|
|
let mut fetch = Q::Fetch::get(self.archetype, self.index as usize)?;
|
|
self.borrowed = true;
|
|
Q::Fetch::borrow(self.archetype);
|
|
Some(fetch.next())
|
|
}
|
|
}
|
|
|
|
/// Transform the query into one that requires a certain component without borrowing it
|
|
///
|
|
/// See `QueryBorrow::with` for details.
|
|
pub fn with<T: Component>(self) -> QueryOneChecked<'a, With<T, Q>> {
|
|
self.transform()
|
|
}
|
|
|
|
/// Transform the query into one that skips entities having a certain component
|
|
///
|
|
/// See `QueryBorrow::without` for details.
|
|
pub fn without<T: Component>(self) -> QueryOneChecked<'a, Without<T, Q>> {
|
|
self.transform()
|
|
}
|
|
|
|
/// Helper to change the type of the query
|
|
fn transform<R: HecsQuery>(self) -> QueryOneChecked<'a, R> {
|
|
QueryOneChecked {
|
|
archetype: self.archetype,
|
|
index: self.index,
|
|
borrowed: self.borrowed,
|
|
_marker: PhantomData,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<Q: HecsQuery> Drop for QueryOneChecked<'_, Q> {
|
|
fn drop(&mut self) {
|
|
if self.borrowed {
|
|
Q::Fetch::release(self.archetype);
|
|
}
|
|
}
|
|
}
|
|
|
|
unsafe impl<Q: HecsQuery> Send for QueryOneChecked<'_, Q> {}
|
|
unsafe impl<Q: HecsQuery> Sync for QueryOneChecked<'_, Q> {}
|