# Objective Another clippy-lint fix: the goal is so that `ci lints` actually displays the problems that a contributor caused, and not a bunch of existing stuff in the repo. (when run on nightly) ## Solution This fixes all but the `clippy::needless_lifetimes` lint, which will result in substantially more fixes and be in other PR(s). I also explicitly allow `non_local_definitions` since it is [not working correctly, but will be fixed](https://github.com/rust-lang/rust/issues/131643). A few things were manually fixed: for example, some places had an explicitly defined `div_ceil` function that was used, which is no longer needed since this function is stable on unsigned integers. Also, empty lines in doc comments were handled individually. ## Testing I ran `cargo clippy --workspace --all-targets --all-features --fix --allow-staged` with the `clippy::needless_lifetimes` lint marked as `allow` in `Cargo.toml` to avoid fixing that too. It now passes with all but the listed lint.
44 lines
1.7 KiB
Rust
44 lines
1.7 KiB
Rust
//! Internal components used by bevy with a fixed component id.
|
|
//! Constants are used to skip [`TypeId`] lookups in hot paths.
|
|
use super::*;
|
|
use crate::{self as bevy_ecs};
|
|
#[cfg(feature = "bevy_reflect")]
|
|
use bevy_reflect::Reflect;
|
|
|
|
/// [`ComponentId`] for [`OnAdd`]
|
|
pub const ON_ADD: ComponentId = ComponentId::new(0);
|
|
/// [`ComponentId`] for [`OnInsert`]
|
|
pub const ON_INSERT: ComponentId = ComponentId::new(1);
|
|
/// [`ComponentId`] for [`OnReplace`]
|
|
pub const ON_REPLACE: ComponentId = ComponentId::new(2);
|
|
/// [`ComponentId`] for [`OnRemove`]
|
|
pub const ON_REMOVE: ComponentId = ComponentId::new(3);
|
|
|
|
/// Trigger emitted when a component is added to an entity. See [`crate::component::ComponentHooks::on_add`]
|
|
/// for more information.
|
|
#[derive(Event, Debug)]
|
|
#[cfg_attr(feature = "bevy_reflect", derive(Reflect))]
|
|
#[cfg_attr(feature = "bevy_reflect", reflect(Debug))]
|
|
pub struct OnAdd;
|
|
|
|
/// Trigger emitted when a component is inserted onto an entity. See [`crate::component::ComponentHooks::on_insert`]
|
|
/// for more information.
|
|
#[derive(Event, Debug)]
|
|
#[cfg_attr(feature = "bevy_reflect", derive(Reflect))]
|
|
#[cfg_attr(feature = "bevy_reflect", reflect(Debug))]
|
|
pub struct OnInsert;
|
|
|
|
/// Trigger emitted when a component is replaced on an entity. See [`crate::component::ComponentHooks::on_replace`]
|
|
/// for more information.
|
|
#[derive(Event, Debug)]
|
|
#[cfg_attr(feature = "bevy_reflect", derive(Reflect))]
|
|
#[cfg_attr(feature = "bevy_reflect", reflect(Debug))]
|
|
pub struct OnReplace;
|
|
|
|
/// Trigger emitted when a component is removed from an entity. See [`crate::component::ComponentHooks::on_remove`]
|
|
/// for more information.
|
|
#[derive(Event, Debug)]
|
|
#[cfg_attr(feature = "bevy_reflect", derive(Reflect))]
|
|
#[cfg_attr(feature = "bevy_reflect", reflect(Debug))]
|
|
pub struct OnRemove;
|