# Objective Yet another PR for migrating stuff to required components. This time, cameras! ## Solution As per the [selected proposal](https://hackmd.io/tsYID4CGRiWxzsgawzxG_g#Combined-Proposal-1-Selected), deprecate `Camera2dBundle` and `Camera3dBundle` in favor of `Camera2d` and `Camera3d`. Adding a `Camera` without `Camera2d` or `Camera3d` now logs a warning, as suggested by Cart [on Discord](https://discord.com/channels/691052431525675048/1264881140007702558/1291506402832945273). I would personally like cameras to work a bit differently and be split into a few more components, to avoid some footguns and confusing semantics, but that is more controversial, and shouldn't block this core migration. ## Testing I ran a few 2D and 3D examples, and tried cameras with and without render graphs. --- ## Migration Guide `Camera2dBundle` and `Camera3dBundle` have been deprecated in favor of `Camera2d` and `Camera3d`. Inserting them will now also insert the other components required by them automatically.
		
			
				
	
	
		
			97 lines
		
	
	
		
			2.7 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			97 lines
		
	
	
		
			2.7 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
//! Simple text rendering benchmark.
 | 
						|
//!
 | 
						|
//! Creates a `Text` with a single `TextSection` containing `100_000` glyphs,
 | 
						|
//! and renders it with the UI in a white color and with Text2d in a red color.
 | 
						|
//!
 | 
						|
//! To recompute all text each frame run
 | 
						|
//! `cargo run --example many_glyphs --release recompute-text`
 | 
						|
use bevy::{
 | 
						|
    color::palettes::basic::RED,
 | 
						|
    diagnostic::{FrameTimeDiagnosticsPlugin, LogDiagnosticsPlugin},
 | 
						|
    prelude::*,
 | 
						|
    text::{LineBreak, TextBounds},
 | 
						|
    window::{PresentMode, WindowResolution},
 | 
						|
    winit::{UpdateMode, WinitSettings},
 | 
						|
};
 | 
						|
 | 
						|
fn main() {
 | 
						|
    let mut app = App::new();
 | 
						|
    app.add_plugins((
 | 
						|
        DefaultPlugins.set(WindowPlugin {
 | 
						|
            primary_window: Some(Window {
 | 
						|
                present_mode: PresentMode::AutoNoVsync,
 | 
						|
                resolution: WindowResolution::new(1920.0, 1080.0).with_scale_factor_override(1.0),
 | 
						|
                ..default()
 | 
						|
            }),
 | 
						|
            ..default()
 | 
						|
        }),
 | 
						|
        FrameTimeDiagnosticsPlugin,
 | 
						|
        LogDiagnosticsPlugin::default(),
 | 
						|
    ))
 | 
						|
    .insert_resource(WinitSettings {
 | 
						|
        focused_mode: UpdateMode::Continuous,
 | 
						|
        unfocused_mode: UpdateMode::Continuous,
 | 
						|
    })
 | 
						|
    .add_systems(Startup, setup);
 | 
						|
 | 
						|
    if std::env::args().any(|arg| arg == "recompute-text") {
 | 
						|
        app.add_systems(Update, force_text_recomputation);
 | 
						|
    }
 | 
						|
 | 
						|
    app.run();
 | 
						|
}
 | 
						|
 | 
						|
fn setup(mut commands: Commands) {
 | 
						|
    warn!(include_str!("warning_string.txt"));
 | 
						|
 | 
						|
    commands.spawn(Camera2d);
 | 
						|
    let mut text = Text {
 | 
						|
        sections: vec![TextSection {
 | 
						|
            value: "0123456789".repeat(10_000),
 | 
						|
            style: TextStyle {
 | 
						|
                font_size: 4.,
 | 
						|
                ..default()
 | 
						|
            },
 | 
						|
        }],
 | 
						|
        justify: JustifyText::Left,
 | 
						|
        linebreak: LineBreak::AnyCharacter,
 | 
						|
        ..default()
 | 
						|
    };
 | 
						|
 | 
						|
    commands
 | 
						|
        .spawn(NodeBundle {
 | 
						|
            style: Style {
 | 
						|
                width: Val::Percent(100.),
 | 
						|
                align_items: AlignItems::Center,
 | 
						|
                justify_content: JustifyContent::Center,
 | 
						|
                ..default()
 | 
						|
            },
 | 
						|
            ..default()
 | 
						|
        })
 | 
						|
        .with_children(|commands| {
 | 
						|
            commands.spawn(TextBundle {
 | 
						|
                text: text.clone(),
 | 
						|
                style: Style {
 | 
						|
                    width: Val::Px(1000.),
 | 
						|
                    ..Default::default()
 | 
						|
                },
 | 
						|
                ..Default::default()
 | 
						|
            });
 | 
						|
        });
 | 
						|
 | 
						|
    text.sections[0].style.color = RED.into();
 | 
						|
 | 
						|
    commands.spawn(Text2dBundle {
 | 
						|
        text,
 | 
						|
        text_anchor: bevy::sprite::Anchor::Center,
 | 
						|
        text_2d_bounds: TextBounds::new_horizontal(1000.),
 | 
						|
        ..Default::default()
 | 
						|
    });
 | 
						|
}
 | 
						|
 | 
						|
fn force_text_recomputation(mut text_query: Query<&mut Text>) {
 | 
						|
    for mut text in &mut text_query {
 | 
						|
        text.set_changed();
 | 
						|
    }
 | 
						|
}
 |