forestia/bevy

History

Máté Homolya 9e11e96a59 Fix false positive GPU frustum culling (#17939 ) # Objective Fix incorrect mesh culling where objects (particularly directional shadows) were being incorrectly culled during the early preprocessing phase. The issue manifested specifically on Apple M1 GPUs but not on newer devices like the M4. The bug was in the `view_frustum_intersects_obb` function, where including the w component (plane distance) in the dot product calculations led to false positive culling results. This caused objects to be incorrectly culled before shadow casting could begin. ## Issue Details The problem of missing shadows is reproducible on Apple M1 GPUs as of this commit (bisected): ``` `00722b8d0` Make indirect drawing opt-out instead of opt-in, enabling multidraw by default. (#16757) ``` and as recent as this commit: ``` `c818c9214` Add option to animate materials in many_cubes (#17927) ``` - The frustum culling calculation incorrectly included the w component (plane distance) when transforming basis vectors - The relative radius calculation should only consider directional transformation (xyz), not positional information (w) - This caused false positive culling specifically on M1 devices likely due to different device-specific floating-point behavior - When objects were incorrectly culled, `early_instance_count` never incremented, leading to missing geometry in the shadow pass ## Testing - Tested on M1 and M4 devices to verify the fix - Verified shadows and geometry render correctly on both platforms - Confirmed the solution matches the existing Rust implementation's behavior for calculating the relative radius: `c818c92143/crates/bevy_render/src/primitives/mod.rs (L77-L87)` - The fix resolves a mathematical error in the frustum culling calculation while maintaining correct culling behavior across all platforms. --- ## Showcase `c818c9214` <img width="1284" alt="c818c9214" src="https://github.com/user-attachments/assets/fe1c7ea9-b13d-422e-b12d-f1cd74475213" /> `mate-h/frustum-cull-fix` <img width="1283" alt="frustum-cull-fix" src="https://github.com/user-attachments/assets/8a9ccb2a-64b6-4d5e-a17d-ac4798da5b51" />		2025-02-20 05:35:21 +00:00
..
src	Fix false positive GPU frustum culling (#17939 )	2025-02-20 05:35:21 +00:00
Cargo.toml	Fix motion vector computation after #17688 . (#17717 )	2025-02-18 09:34:19 +00:00
LICENSE-APACHE	Cleanup publish process (#17728 )	2025-02-09 17:46:19 +00:00
LICENSE-MIT	Cleanup publish process (#17728 )	2025-02-09 17:46:19 +00:00
README.md	Add `README.md` to all crates (#13184 )	2024-05-02 18:56:00 +00:00

README.md

Bevy PBR