8130b229be
# Objective - Optimize static scene performance by marking unchanged subtrees. - [bef0209](bef0209de1) fixes #18255 and #18363. - Closes #18365 - Includes change from #18321 ## Solution - Mark hierarchy subtrees with dirty bits to avoid transform propagation where not needed - This causes a performance regression when spawning many entities, or when the scene is entirely dynamic. - This results in massive speedups for largely static scenes. - In the future we could allow the user to change this behavior, or add some threshold based on how dynamic the scene is? ## Testing - Caldera Hotel scene
48 lines
1.8 KiB
Rust
48 lines
1.8 KiB
Rust
use crate::systems::{mark_dirty_trees, propagate_parent_transforms, sync_simple_transforms};
|
|
use bevy_app::{App, Plugin, PostStartup, PostUpdate};
|
|
use bevy_ecs::schedule::{IntoScheduleConfigs, SystemSet};
|
|
|
|
/// Set enum for the systems relating to transform propagation
|
|
#[derive(Debug, Hash, PartialEq, Eq, Clone, SystemSet)]
|
|
pub enum TransformSystem {
|
|
/// Propagates changes in transform to children's [`GlobalTransform`](crate::components::GlobalTransform)
|
|
TransformPropagate,
|
|
}
|
|
|
|
/// The base plugin for handling [`Transform`](crate::components::Transform) components
|
|
#[derive(Default)]
|
|
pub struct TransformPlugin;
|
|
|
|
impl Plugin for TransformPlugin {
|
|
fn build(&self, app: &mut App) {
|
|
#[cfg(feature = "bevy_reflect")]
|
|
app.register_type::<crate::components::Transform>()
|
|
.register_type::<crate::components::TransformTreeChanged>()
|
|
.register_type::<crate::components::GlobalTransform>();
|
|
|
|
app
|
|
// add transform systems to startup so the first update is "correct"
|
|
.add_systems(
|
|
PostStartup,
|
|
(
|
|
mark_dirty_trees,
|
|
propagate_parent_transforms,
|
|
sync_simple_transforms,
|
|
)
|
|
.chain()
|
|
.in_set(TransformSystem::TransformPropagate),
|
|
)
|
|
.add_systems(
|
|
PostUpdate,
|
|
(
|
|
mark_dirty_trees,
|
|
propagate_parent_transforms,
|
|
// TODO: Adjust the internal parallel queries to make this system more efficiently share and fill CPU time.
|
|
sync_simple_transforms,
|
|
)
|
|
.chain()
|
|
.in_set(TransformSystem::TransformPropagate),
|
|
);
|
|
}
|
|
}
|