a750cfe4a1
# Objective - Fixes #19627 - Tackles part of #19644 - Supersedes #19629 - `Window` has become a very very very big component - As such, our change detection does not *really* work on it, as e.g. moving the mouse will cause a change for the entire window - We circumvented this with a cache - But, some things *shouldn't* be cached as they can be changed from outside the user's control, notably the cursor grab mode on web - So, we need to disable the cache for that - But because change detection is broken, that would result in the cursor grab mode being set every frame the mouse is moved - That is usually *not* what a dev wants, as it forces the cursor to be locked even when the end-user is trying to free the cursor on the browser - the cache in this situation is invalid due to #8949 ## Solution - Split `Window` into multiple components, each with working change detection - Disable caching of the cursor grab mode - This will only attempt to force the grab mode when the `CursorOptions` were touched by the user, which is *much* rarer than simply moving the mouse. - If this PR is merged, I'll do the exact same for the other constituents of `Window` as a follow-up ## Testing - Ran all the changed examples
14 lines
612 B
Diff
14 lines
612 B
Diff
diff --git a/crates/bevy_window/src/window.rs b/crates/bevy_window/src/window.rs
|
|
index f578658cd..ffac22062 100644
|
|
--- a/crates/bevy_window/src/window.rs
|
|
+++ b/crates/bevy_window/src/window.rs
|
|
@@ -318,7 +318,7 @@ impl Default for Window {
|
|
name: None,
|
|
present_mode: Default::default(),
|
|
mode: Default::default(),
|
|
- position: Default::default(),
|
|
+ position: WindowPosition::Centered(MonitorSelection::Primary),
|
|
resolution: Default::default(),
|
|
internal: Default::default(),
|
|
composite_alpha_mode: Default::default(),
|