 f0047899d7
			
		
	
	
		f0047899d7
		
			
		
	
	
	
	
		
			
			# Objective I have an application where I'd like to measure average frame rate over the entire life of the application, and it would be handy if I could just configure this on the existing `FrameTimeDiagnosticsPlugin`. Probably fixes #10948? ## Solution Add `max_history_length` to `FrameTimeDiagnosticsPlugin`, and because `smoothing_factor` seems to be based on history length, add that too. ## Discussion I'm not totally sure that `DEFAULT_MAX_HISTORY_LENGTH` is a great default for `FrameTimeDiagnosticsPlugin` (or any diagnostic?). That's 1/3 of a second at typical game frame rates. Moreover, the default print interval for `LogDiagnosticsPlugin` is 1 second. So when the two are combined, you are printing the average over the last third of the duration between now and the previous print, which seems a bit wonky. (related: #11429) I'm pretty sure this default value discussed and the current value wasn't totally arbitrary though. Maybe it would be nice for `Diagnostic` to have a `with_max_history_length_and_also_calculate_a_good_default_smoothing_factor` method? And then make an explicit smoothing factor in `FrameTimeDiagnosticsPlugin` optional? Or add a `new(max_history_length: usize)` method to `FrameTimeDiagnosticsPlugin` that sets a reasonable default `smoothing_factor`? edit: This one seems like a no-brainer, doing it. ## Alternatives It's really easy to roll your own `FrameTimeDiagnosticsPlugin`, but that might not be super interoperable with, for example, third party FPS overlays. Still, might be the right call. ## Testing `cargo run --example many_sprites` (modified to use a custom `max_history_length`) ## Migration Guide `FrameTimeDiagnosticsPlugin` now contains two fields. Use `FrameTimeDiagnosticsPlugin::default()` to match Bevy's previous behavior or, for example, `FrameTimeDiagnosticsPlugin::new(60)` to configure it.
		
			
				
	
	
		
			145 lines
		
	
	
		
			4.7 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			145 lines
		
	
	
		
			4.7 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
| //! This example illustrates how to create UI text and update it in a system.
 | |
| //!
 | |
| //! It displays the current FPS in the top left corner, as well as text that changes color
 | |
| //! in the bottom right. For text within a scene, please see the text2d example.
 | |
| 
 | |
| use bevy::{
 | |
|     color::palettes::css::GOLD,
 | |
|     diagnostic::{DiagnosticsStore, FrameTimeDiagnosticsPlugin},
 | |
|     prelude::*,
 | |
| };
 | |
| 
 | |
| fn main() {
 | |
|     App::new()
 | |
|         .add_plugins((DefaultPlugins, FrameTimeDiagnosticsPlugin::default()))
 | |
|         .add_systems(Startup, setup)
 | |
|         .add_systems(Update, (text_update_system, text_color_system))
 | |
|         .run();
 | |
| }
 | |
| 
 | |
| // Marker struct to help identify the FPS UI component, since there may be many Text components
 | |
| #[derive(Component)]
 | |
| struct FpsText;
 | |
| 
 | |
| // Marker struct to help identify the color-changing Text component
 | |
| #[derive(Component)]
 | |
| struct AnimatedText;
 | |
| 
 | |
| fn setup(mut commands: Commands, asset_server: Res<AssetServer>) {
 | |
|     // UI camera
 | |
|     commands.spawn(Camera2d);
 | |
|     // Text with one section
 | |
|     commands.spawn((
 | |
|         // Accepts a `String` or any type that converts into a `String`, such as `&str`
 | |
|         Text::new("hello\nbevy!"),
 | |
|         TextFont {
 | |
|             // This font is loaded and will be used instead of the default font.
 | |
|             font: asset_server.load("fonts/FiraSans-Bold.ttf"),
 | |
|             font_size: 67.0,
 | |
|             ..default()
 | |
|         },
 | |
|         // Set the justification of the Text
 | |
|         TextLayout::new_with_justify(JustifyText::Center),
 | |
|         // Set the style of the Node itself.
 | |
|         Node {
 | |
|             position_type: PositionType::Absolute,
 | |
|             bottom: Val::Px(5.0),
 | |
|             right: Val::Px(5.0),
 | |
|             ..default()
 | |
|         },
 | |
|         AnimatedText,
 | |
|     ));
 | |
| 
 | |
|     // Text with multiple sections
 | |
|     commands
 | |
|         .spawn((
 | |
|             // Create a Text with multiple child spans.
 | |
|             Text::new("FPS: "),
 | |
|             TextFont {
 | |
|                 // This font is loaded and will be used instead of the default font.
 | |
|                 font: asset_server.load("fonts/FiraSans-Bold.ttf"),
 | |
|                 font_size: 42.0,
 | |
|                 ..default()
 | |
|             },
 | |
|         ))
 | |
|         .with_child((
 | |
|             TextSpan::default(),
 | |
|             if cfg!(feature = "default_font") {
 | |
|                 (
 | |
|                     TextFont {
 | |
|                         font_size: 33.0,
 | |
|                         // If no font is specified, the default font (a minimal subset of FiraMono) will be used.
 | |
|                         ..default()
 | |
|                     },
 | |
|                     TextColor(GOLD.into()),
 | |
|                 )
 | |
|             } else {
 | |
|                 (
 | |
|                     // "default_font" feature is unavailable, load a font to use instead.
 | |
|                     TextFont {
 | |
|                         font: asset_server.load("fonts/FiraMono-Medium.ttf"),
 | |
|                         font_size: 33.0,
 | |
|                         ..Default::default()
 | |
|                     },
 | |
|                     TextColor(GOLD.into()),
 | |
|                 )
 | |
|             },
 | |
|             FpsText,
 | |
|         ));
 | |
| 
 | |
|     #[cfg(feature = "default_font")]
 | |
|     commands.spawn((
 | |
|         // Here we are able to call the `From` method instead of creating a new `TextSection`.
 | |
|         // This will use the default font (a minimal subset of FiraMono) and apply the default styling.
 | |
|         Text::new("From an &str into a Text with the default font!"),
 | |
|         Node {
 | |
|             position_type: PositionType::Absolute,
 | |
|             bottom: Val::Px(5.0),
 | |
|             left: Val::Px(15.0),
 | |
|             ..default()
 | |
|         },
 | |
|     ));
 | |
| 
 | |
|     #[cfg(not(feature = "default_font"))]
 | |
|     commands.spawn((
 | |
|         Text::new("Default font disabled"),
 | |
|         TextFont {
 | |
|             font: asset_server.load("fonts/FiraMono-Medium.ttf"),
 | |
|             ..default()
 | |
|         },
 | |
|         Node {
 | |
|             position_type: PositionType::Absolute,
 | |
|             bottom: Val::Px(5.0),
 | |
|             left: Val::Px(15.0),
 | |
|             ..default()
 | |
|         },
 | |
|     ));
 | |
| }
 | |
| 
 | |
| fn text_color_system(time: Res<Time>, mut query: Query<&mut TextColor, With<AnimatedText>>) {
 | |
|     for mut text_color in &mut query {
 | |
|         let seconds = time.elapsed_secs();
 | |
| 
 | |
|         // Update the color of the ColorText span.
 | |
|         text_color.0 = Color::srgb(
 | |
|             ops::sin(1.25 * seconds) / 2.0 + 0.5,
 | |
|             ops::sin(0.75 * seconds) / 2.0 + 0.5,
 | |
|             ops::sin(0.50 * seconds) / 2.0 + 0.5,
 | |
|         );
 | |
|     }
 | |
| }
 | |
| 
 | |
| fn text_update_system(
 | |
|     diagnostics: Res<DiagnosticsStore>,
 | |
|     mut query: Query<&mut TextSpan, With<FpsText>>,
 | |
| ) {
 | |
|     for mut span in &mut query {
 | |
|         if let Some(fps) = diagnostics.get(&FrameTimeDiagnosticsPlugin::FPS) {
 | |
|             if let Some(value) = fps.smoothed() {
 | |
|                 // Update the value of the second section
 | |
|                 **span = format!("{value:.2}");
 | |
|             }
 | |
|         }
 | |
|     }
 | |
| }
 |