 d70595b667
			
		
	
	
		d70595b667
		
			
		
	
	
	
	
		
			
			# Objective - Fixes #6370 - Closes #6581 ## Solution - Added the following lints to the workspace: - `std_instead_of_core` - `std_instead_of_alloc` - `alloc_instead_of_core` - Used `cargo +nightly fmt` with [item level use formatting](https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=#Item%5C%3A) to split all `use` statements into single items. - Used `cargo clippy --workspace --all-targets --all-features --fix --allow-dirty` to _attempt_ to resolve the new linting issues, and intervened where the lint was unable to resolve the issue automatically (usually due to needing an `extern crate alloc;` statement in a crate root). - Manually removed certain uses of `std` where negative feature gating prevented `--all-features` from finding the offending uses. - Used `cargo +nightly fmt` with [crate level use formatting](https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=#Crate%5C%3A) to re-merge all `use` statements matching Bevy's previous styling. - Manually fixed cases where the `fmt` tool could not re-merge `use` statements due to conditional compilation attributes. ## Testing - Ran CI locally ## Migration Guide The MSRV is now 1.81. Please update to this version or higher. ## Notes - This is a _massive_ change to try and push through, which is why I've outlined the semi-automatic steps I used to create this PR, in case this fails and someone else tries again in the future. - Making this change has no impact on user code, but does mean Bevy contributors will be warned to use `core` and `alloc` instead of `std` where possible. - This lint is a critical first step towards investigating `no_std` options for Bevy. --------- Co-authored-by: François Mockers <francois.mockers@vleue.com>
		
			
				
	
	
		
			107 lines
		
	
	
		
			2.9 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			107 lines
		
	
	
		
			2.9 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
| //! Shows how to create a custom [`Decodable`] type by implementing a Sine wave.
 | |
| 
 | |
| use bevy::{
 | |
|     audio::{AddAudioSource, AudioPlugin, Source},
 | |
|     math::ops,
 | |
|     prelude::*,
 | |
|     reflect::TypePath,
 | |
|     utils::Duration,
 | |
| };
 | |
| 
 | |
| // This struct usually contains the data for the audio being played.
 | |
| // This is where data read from an audio file would be stored, for example.
 | |
| // This allows the type to be registered as an asset.
 | |
| #[derive(Asset, TypePath)]
 | |
| struct SineAudio {
 | |
|     frequency: f32,
 | |
| }
 | |
| // This decoder is responsible for playing the audio,
 | |
| // and so stores data about the audio being played.
 | |
| struct SineDecoder {
 | |
|     // how far along one period the wave is (between 0 and 1)
 | |
|     current_progress: f32,
 | |
|     // how much we move along the period every frame
 | |
|     progress_per_frame: f32,
 | |
|     // how long a period is
 | |
|     period: f32,
 | |
|     sample_rate: u32,
 | |
| }
 | |
| 
 | |
| impl SineDecoder {
 | |
|     fn new(frequency: f32) -> Self {
 | |
|         // standard sample rate for most recordings
 | |
|         let sample_rate = 44_100;
 | |
|         SineDecoder {
 | |
|             current_progress: 0.,
 | |
|             progress_per_frame: frequency / sample_rate as f32,
 | |
|             period: std::f32::consts::PI * 2.,
 | |
|             sample_rate,
 | |
|         }
 | |
|     }
 | |
| }
 | |
| 
 | |
| // The decoder must implement iterator so that it can implement `Decodable`.
 | |
| impl Iterator for SineDecoder {
 | |
|     type Item = f32;
 | |
| 
 | |
|     fn next(&mut self) -> Option<Self::Item> {
 | |
|         self.current_progress += self.progress_per_frame;
 | |
|         // we loop back round to 0 to avoid floating point inaccuracies
 | |
|         self.current_progress %= 1.;
 | |
|         Some(ops::sin(self.period * self.current_progress))
 | |
|     }
 | |
| }
 | |
| // `Source` is what allows the audio source to be played by bevy.
 | |
| // This trait provides information on the audio.
 | |
| impl Source for SineDecoder {
 | |
|     fn current_frame_len(&self) -> Option<usize> {
 | |
|         None
 | |
|     }
 | |
| 
 | |
|     fn channels(&self) -> u16 {
 | |
|         1
 | |
|     }
 | |
| 
 | |
|     fn sample_rate(&self) -> u32 {
 | |
|         self.sample_rate
 | |
|     }
 | |
| 
 | |
|     fn total_duration(&self) -> Option<Duration> {
 | |
|         None
 | |
|     }
 | |
| }
 | |
| 
 | |
| // Finally `Decodable` can be implemented for our `SineAudio`.
 | |
| impl Decodable for SineAudio {
 | |
|     type DecoderItem = <SineDecoder as Iterator>::Item;
 | |
| 
 | |
|     type Decoder = SineDecoder;
 | |
| 
 | |
|     fn decoder(&self) -> Self::Decoder {
 | |
|         SineDecoder::new(self.frequency)
 | |
|     }
 | |
| }
 | |
| 
 | |
| fn main() {
 | |
|     let mut app = App::new();
 | |
|     // register the audio source so that it can be used
 | |
|     app.add_plugins(DefaultPlugins.set(AudioPlugin {
 | |
|         global_volume: GlobalVolume::new(0.2),
 | |
|         ..default()
 | |
|     }))
 | |
|     .add_audio_source::<SineAudio>()
 | |
|     .add_systems(Startup, setup)
 | |
|     .run();
 | |
| }
 | |
| 
 | |
| fn setup(mut assets: ResMut<Assets<SineAudio>>, mut commands: Commands) {
 | |
|     // add a `SineAudio` to the asset server so that it can be played
 | |
|     let audio_handle = assets.add(SineAudio {
 | |
|         frequency: 440., // this is the frequency of A4
 | |
|     });
 | |
|     commands.spawn(AudioSourceBundle {
 | |
|         source: audio_handle,
 | |
|         ..default()
 | |
|     });
 | |
| }
 |