forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
d67fbd5e90
bevy/crates/bevy_core_pipeline/src
History
Griffin d3e41e2ff7
Fix deferred lighting pass values not all working on M1 in WebGL2 (#10304) 
# Objective

- On MacOS M1 WebGL2 the deferred lighting ID depth comparison is
failing for some values (including 1, the default)
Note: this issue is just with WebGL2, native on MacOS M1 is working with
current bevy main.

## Solution

- Use Depth16Unorm for lighting pass id format.

This format is aliasing to the same value consistently (in
[copy_deferred_lighting_id](https://github.com/bevyengine/bevy/blob/main/crates/bevy_core_pipeline/src/deferred/copy_deferred_lighting_id.wgsl#L15)
and
[deferred_lighting](https://github.com/bevyengine/bevy/blob/main/crates/bevy_pbr/src/deferred/deferred_lighting.wgsl#L39))
on MacOS M1 WebGL, and appears to be supported across WebGL2, WebGPU,
DX12, OpenGL 3.3, Vulkan.

Successfully tested all 256 ids on:

- MacOS M1 native and WebGL2
- Window RTX3060 Vulkan/DX12/WebGL2
- Windows Intel UHD Graphics 630 IGP DX12/WebGL2 
(bevy w/ Vulkan doesn't work on this IGP in general
https://github.com/bevyengine/bevy/issues/8037)
2023-10-29 16:47:48 +00:00
..
blit update shader imports (#10180) 2023-10-21 11:51:58 +00:00
bloom Use clippy::doc_markdown more. (#10286) 2023-10-27 22:49:02 +00:00
contrast_adaptive_sharpening Bind group entries (#9694) 2023-10-21 15:39:22 +00:00
core_2d Automatic batching/instancing of draw commands (#9685) 2023-09-21 22:12:34 +00:00
core_3d Deferred Renderer (#9258) 2023-10-12 22:10:38 +00:00
deferred Fix deferred lighting pass values not all working on M1 in WebGL2 (#10304) 2023-10-29 16:47:48 +00:00
fullscreen_vertex_shader Bevy Asset V2 (#8624) 2023-09-07 02:07:27 +00:00
fxaa Bind group entries (#9694) 2023-10-21 15:39:22 +00:00
prepass Deferred Renderer (#9258) 2023-10-12 22:10:38 +00:00
skybox Bind group entries (#9694) 2023-10-21 15:39:22 +00:00
taa Smaller TAA fixes (#10200) 2023-10-27 23:13:14 +00:00
tonemapping Log a warning when the tonemapping_luts feature is disabled but required for the selected tonemapper. (#10253) 2023-10-27 02:07:24 +00:00
upscaling Bind group entries (#9694) 2023-10-21 15:39:22 +00:00
clear_color.rs Document ClearColorConfig (#9288) 2023-07-29 22:22:49 +00:00
lib.rs Smaller TAA fixes (#10200) 2023-10-27 23:13:14 +00:00
msaa_writeback.rs Bind group entries (#9694) 2023-10-21 15:39:22 +00:00