 992681b59b
			
		
	
	
		992681b59b
		
	
	
	
	
		
			
			*This PR description is an edited copy of #5007, written by @alice-i-cecile.* # Objective Follow-up to https://github.com/bevyengine/bevy/pull/2254. The `Resource` trait currently has a blanket implementation for all types that meet its bounds. While ergonomic, this results in several drawbacks: * it is possible to make confusing, silent mistakes such as inserting a function pointer (Foo) rather than a value (Foo::Bar) as a resource * it is challenging to discover if a type is intended to be used as a resource * we cannot later add customization options (see the [RFC](https://github.com/bevyengine/rfcs/blob/main/rfcs/27-derive-component.md) for the equivalent choice for Component). * dependencies can use the same Rust type as a resource in invisibly conflicting ways * raw Rust types used as resources cannot preserve privacy appropriately, as anyone able to access that type can read and write to internal values * we cannot capture a definitive list of possible resources to display to users in an editor ## Notes to reviewers * Review this commit-by-commit; there's effectively no back-tracking and there's a lot of churn in some of these commits. *ira: My commits are not as well organized :')* * I've relaxed the bound on Local to Send + Sync + 'static: I don't think these concerns apply there, so this can keep things simple. Storing e.g. a u32 in a Local is fine, because there's a variable name attached explaining what it does. * I think this is a bad place for the Resource trait to live, but I've left it in place to make reviewing easier. IMO that's best tackled with https://github.com/bevyengine/bevy/issues/4981. ## Changelog `Resource` is no longer automatically implemented for all matching types. Instead, use the new `#[derive(Resource)]` macro. ## Migration Guide Add `#[derive(Resource)]` to all types you are using as a resource. If you are using a third party type as a resource, wrap it in a tuple struct to bypass orphan rules. Consider deriving `Deref` and `DerefMut` to improve ergonomics. `ClearColor` no longer implements `Component`. Using `ClearColor` as a component in 0.8 did nothing. Use the `ClearColorConfig` in the `Camera3d` and `Camera2d` components instead. Co-authored-by: Alice <alice.i.cecile@gmail.com> Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: devil-ira <justthecooldude@gmail.com> Co-authored-by: Carter Anderson <mcanders1@gmail.com>
		
			
				
	
	
		
			271 lines
		
	
	
		
			8.4 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			271 lines
		
	
	
		
			8.4 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
| //! A shader that uses dynamic data like the time since startup.
 | |
| //!
 | |
| //! This example uses a specialized pipeline.
 | |
| 
 | |
| use bevy::{
 | |
|     core_pipeline::core_3d::Transparent3d,
 | |
|     ecs::system::{
 | |
|         lifetimeless::{Read, SRes},
 | |
|         SystemParamItem,
 | |
|     },
 | |
|     pbr::{
 | |
|         DrawMesh, MeshPipeline, MeshPipelineKey, MeshUniform, SetMeshBindGroup,
 | |
|         SetMeshViewBindGroup,
 | |
|     },
 | |
|     prelude::*,
 | |
|     render::{
 | |
|         extract_component::{ExtractComponent, ExtractComponentPlugin},
 | |
|         extract_resource::{ExtractResource, ExtractResourcePlugin},
 | |
|         mesh::MeshVertexBufferLayout,
 | |
|         render_asset::RenderAssets,
 | |
|         render_phase::{
 | |
|             AddRenderCommand, DrawFunctions, EntityRenderCommand, RenderCommandResult, RenderPhase,
 | |
|             SetItemPipeline, TrackedRenderPass,
 | |
|         },
 | |
|         render_resource::*,
 | |
|         renderer::{RenderDevice, RenderQueue},
 | |
|         view::{ComputedVisibility, ExtractedView, Msaa, Visibility},
 | |
|         RenderApp, RenderStage,
 | |
|     },
 | |
| };
 | |
| 
 | |
| fn main() {
 | |
|     App::new()
 | |
|         .add_plugins(DefaultPlugins)
 | |
|         .add_plugin(CustomMaterialPlugin)
 | |
|         .add_startup_system(setup)
 | |
|         .run();
 | |
| }
 | |
| 
 | |
| fn setup(mut commands: Commands, mut meshes: ResMut<Assets<Mesh>>) {
 | |
|     // cube
 | |
|     commands.spawn().insert_bundle((
 | |
|         meshes.add(Mesh::from(shape::Cube { size: 1.0 })),
 | |
|         Transform::from_xyz(0.0, 0.5, 0.0),
 | |
|         GlobalTransform::default(),
 | |
|         CustomMaterial,
 | |
|         Visibility::default(),
 | |
|         ComputedVisibility::default(),
 | |
|     ));
 | |
| 
 | |
|     // camera
 | |
|     commands.spawn_bundle(Camera3dBundle {
 | |
|         transform: Transform::from_xyz(-2.0, 2.5, 5.0).looking_at(Vec3::ZERO, Vec3::Y),
 | |
|         ..default()
 | |
|     });
 | |
| }
 | |
| 
 | |
| #[derive(Component)]
 | |
| struct CustomMaterial;
 | |
| 
 | |
| pub struct CustomMaterialPlugin;
 | |
| 
 | |
| impl Plugin for CustomMaterialPlugin {
 | |
|     fn build(&self, app: &mut App) {
 | |
|         let render_device = app.world.resource::<RenderDevice>();
 | |
|         let buffer = render_device.create_buffer(&BufferDescriptor {
 | |
|             label: Some("time uniform buffer"),
 | |
|             size: std::mem::size_of::<f32>() as u64,
 | |
|             usage: BufferUsages::UNIFORM | BufferUsages::COPY_DST,
 | |
|             mapped_at_creation: false,
 | |
|         });
 | |
|         app.add_plugin(ExtractComponentPlugin::<CustomMaterial>::default())
 | |
|             .add_plugin(ExtractResourcePlugin::<ExtractedTime>::default());
 | |
| 
 | |
|         app.sub_app_mut(RenderApp)
 | |
|             .add_render_command::<Transparent3d, DrawCustom>()
 | |
|             .insert_resource(TimeMeta {
 | |
|                 buffer,
 | |
|                 bind_group: None,
 | |
|             })
 | |
|             .init_resource::<CustomPipeline>()
 | |
|             .init_resource::<SpecializedMeshPipelines<CustomPipeline>>()
 | |
|             .add_system_to_stage(RenderStage::Prepare, prepare_time)
 | |
|             .add_system_to_stage(RenderStage::Queue, queue_custom)
 | |
|             .add_system_to_stage(RenderStage::Queue, queue_time_bind_group);
 | |
|     }
 | |
| }
 | |
| 
 | |
| impl ExtractComponent for CustomMaterial {
 | |
|     type Query = Read<CustomMaterial>;
 | |
| 
 | |
|     type Filter = ();
 | |
| 
 | |
|     fn extract_component(_: bevy::ecs::query::QueryItem<Self::Query>) -> Self {
 | |
|         CustomMaterial
 | |
|     }
 | |
| }
 | |
| 
 | |
| // add each entity with a mesh and a `CustomMaterial` to every view's `Transparent3d` render phase using the `CustomPipeline`
 | |
| #[allow(clippy::too_many_arguments)]
 | |
| fn queue_custom(
 | |
|     transparent_3d_draw_functions: Res<DrawFunctions<Transparent3d>>,
 | |
|     custom_pipeline: Res<CustomPipeline>,
 | |
|     msaa: Res<Msaa>,
 | |
|     mut pipelines: ResMut<SpecializedMeshPipelines<CustomPipeline>>,
 | |
|     mut pipeline_cache: ResMut<PipelineCache>,
 | |
|     render_meshes: Res<RenderAssets<Mesh>>,
 | |
|     material_meshes: Query<(Entity, &MeshUniform, &Handle<Mesh>), With<CustomMaterial>>,
 | |
|     mut views: Query<(&ExtractedView, &mut RenderPhase<Transparent3d>)>,
 | |
| ) {
 | |
|     let draw_custom = transparent_3d_draw_functions
 | |
|         .read()
 | |
|         .get_id::<DrawCustom>()
 | |
|         .unwrap();
 | |
| 
 | |
|     let key = MeshPipelineKey::from_msaa_samples(msaa.samples)
 | |
|         | MeshPipelineKey::from_primitive_topology(PrimitiveTopology::TriangleList);
 | |
| 
 | |
|     for (view, mut transparent_phase) in &mut views {
 | |
|         let rangefinder = view.rangefinder3d();
 | |
|         for (entity, mesh_uniform, mesh_handle) in &material_meshes {
 | |
|             if let Some(mesh) = render_meshes.get(mesh_handle) {
 | |
|                 let pipeline = pipelines
 | |
|                     .specialize(&mut pipeline_cache, &custom_pipeline, key, &mesh.layout)
 | |
|                     .unwrap();
 | |
|                 transparent_phase.add(Transparent3d {
 | |
|                     entity,
 | |
|                     pipeline,
 | |
|                     draw_function: draw_custom,
 | |
|                     distance: rangefinder.distance(&mesh_uniform.transform),
 | |
|                 });
 | |
|             }
 | |
|         }
 | |
|     }
 | |
| }
 | |
| 
 | |
| #[derive(Resource, Default)]
 | |
| struct ExtractedTime {
 | |
|     seconds_since_startup: f32,
 | |
| }
 | |
| 
 | |
| impl ExtractResource for ExtractedTime {
 | |
|     type Source = Time;
 | |
| 
 | |
|     fn extract_resource(time: &Self::Source) -> Self {
 | |
|         ExtractedTime {
 | |
|             seconds_since_startup: time.seconds_since_startup() as f32,
 | |
|         }
 | |
|     }
 | |
| }
 | |
| 
 | |
| #[derive(Resource)]
 | |
| struct TimeMeta {
 | |
|     buffer: Buffer,
 | |
|     bind_group: Option<BindGroup>,
 | |
| }
 | |
| 
 | |
| // write the extracted time into the corresponding uniform buffer
 | |
| fn prepare_time(
 | |
|     time: Res<ExtractedTime>,
 | |
|     time_meta: ResMut<TimeMeta>,
 | |
|     render_queue: Res<RenderQueue>,
 | |
| ) {
 | |
|     render_queue.write_buffer(
 | |
|         &time_meta.buffer,
 | |
|         0,
 | |
|         bevy::core::cast_slice(&[time.seconds_since_startup]),
 | |
|     );
 | |
| }
 | |
| 
 | |
| // create a bind group for the time uniform buffer
 | |
| fn queue_time_bind_group(
 | |
|     render_device: Res<RenderDevice>,
 | |
|     mut time_meta: ResMut<TimeMeta>,
 | |
|     pipeline: Res<CustomPipeline>,
 | |
| ) {
 | |
|     let bind_group = render_device.create_bind_group(&BindGroupDescriptor {
 | |
|         label: None,
 | |
|         layout: &pipeline.time_bind_group_layout,
 | |
|         entries: &[BindGroupEntry {
 | |
|             binding: 0,
 | |
|             resource: time_meta.buffer.as_entire_binding(),
 | |
|         }],
 | |
|     });
 | |
|     time_meta.bind_group = Some(bind_group);
 | |
| }
 | |
| 
 | |
| #[derive(Resource)]
 | |
| pub struct CustomPipeline {
 | |
|     shader: Handle<Shader>,
 | |
|     mesh_pipeline: MeshPipeline,
 | |
|     time_bind_group_layout: BindGroupLayout,
 | |
| }
 | |
| 
 | |
| impl FromWorld for CustomPipeline {
 | |
|     fn from_world(world: &mut World) -> Self {
 | |
|         let asset_server = world.resource::<AssetServer>();
 | |
|         let shader = asset_server.load("shaders/animate_shader.wgsl");
 | |
| 
 | |
|         let render_device = world.resource::<RenderDevice>();
 | |
|         let time_bind_group_layout =
 | |
|             render_device.create_bind_group_layout(&BindGroupLayoutDescriptor {
 | |
|                 label: Some("time bind group"),
 | |
|                 entries: &[BindGroupLayoutEntry {
 | |
|                     binding: 0,
 | |
|                     visibility: ShaderStages::FRAGMENT,
 | |
|                     ty: BindingType::Buffer {
 | |
|                         ty: BufferBindingType::Uniform,
 | |
|                         has_dynamic_offset: false,
 | |
|                         min_binding_size: BufferSize::new(std::mem::size_of::<f32>() as u64),
 | |
|                     },
 | |
|                     count: None,
 | |
|                 }],
 | |
|             });
 | |
| 
 | |
|         let mesh_pipeline = world.resource::<MeshPipeline>();
 | |
| 
 | |
|         CustomPipeline {
 | |
|             shader,
 | |
|             mesh_pipeline: mesh_pipeline.clone(),
 | |
|             time_bind_group_layout,
 | |
|         }
 | |
|     }
 | |
| }
 | |
| 
 | |
| impl SpecializedMeshPipeline for CustomPipeline {
 | |
|     type Key = MeshPipelineKey;
 | |
| 
 | |
|     fn specialize(
 | |
|         &self,
 | |
|         key: Self::Key,
 | |
|         layout: &MeshVertexBufferLayout,
 | |
|     ) -> Result<RenderPipelineDescriptor, SpecializedMeshPipelineError> {
 | |
|         let mut descriptor = self.mesh_pipeline.specialize(key, layout)?;
 | |
|         descriptor.vertex.shader = self.shader.clone();
 | |
|         descriptor.fragment.as_mut().unwrap().shader = self.shader.clone();
 | |
|         descriptor.layout = Some(vec![
 | |
|             self.mesh_pipeline.view_layout.clone(),
 | |
|             self.mesh_pipeline.mesh_layout.clone(),
 | |
|             self.time_bind_group_layout.clone(),
 | |
|         ]);
 | |
|         Ok(descriptor)
 | |
|     }
 | |
| }
 | |
| 
 | |
| type DrawCustom = (
 | |
|     SetItemPipeline,
 | |
|     SetMeshViewBindGroup<0>,
 | |
|     SetMeshBindGroup<1>,
 | |
|     SetTimeBindGroup<2>,
 | |
|     DrawMesh,
 | |
| );
 | |
| 
 | |
| struct SetTimeBindGroup<const I: usize>;
 | |
| 
 | |
| impl<const I: usize> EntityRenderCommand for SetTimeBindGroup<I> {
 | |
|     type Param = SRes<TimeMeta>;
 | |
| 
 | |
|     fn render<'w>(
 | |
|         _view: Entity,
 | |
|         _item: Entity,
 | |
|         time_meta: SystemParamItem<'w, '_, Self::Param>,
 | |
|         pass: &mut TrackedRenderPass<'w>,
 | |
|     ) -> RenderCommandResult {
 | |
|         let time_bind_group = time_meta.into_inner().bind_group.as_ref().unwrap();
 | |
|         pass.set_bind_group(I, time_bind_group, &[]);
 | |
| 
 | |
|         RenderCommandResult::Success
 | |
|     }
 | |
| }
 |