
When building Bevy using Bazel, you don't need a 'Cargo.toml'... except Bevy requires it currently. Hopefully this can help illuminate the requirement. # Objective I recently started exploring Bazel and Buck2. Currently Bazel has some great advantages over Cargo for me and I was pretty happy to find that things generally work quite well! Once I added a target to my test project that depended on bevy but didn't use Cargo, I didn't create a Cargo.toml file for it and things appeared to work, but as soon as I went to derive from Component the build failed with the cryptic error: ``` ERROR: /Users/photex/workspaces/personal/mb-rogue/scratch/BUILD:24:12: Compiling Rust bin hello_bevy (0 files) failed: (Exit 1): process_wrapper failed: error executing command (from target //scratch:hello_bevy) bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/rules_rust/util/process_wrapper/process_wrapper --arg-file ... (remaining 312 arguments skipped) error: proc-macro derive panicked --> scratch/hello_bevy.rs:5:10 | 5 | #[derive(Component)] | ^^^^^^^^^ | = help: message: called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" } error: proc-macro derive panicked --> scratch/hello_bevy.rs:8:10 | 8 | #[derive(Component)] | ^^^^^^^^^ | = help: message: called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" } ``` ## Solution After poking around I realized that the proc macros in Bevy all use bevy_macro_utils::BevyManifest, which was attempting to load a Cargo manifest that doesn't exist. This PR doesn't address the Cargo requirement (I'd love to see if there was a way to support more than Cargo transparently), but it *does* replace some calls to unwrap with expect and hopefully the error messages will be more helpful for other folks like me hoping to pat down a new trail: ``` ERROR: /Users/photex/workspaces/personal/mb-rogue/scratch/BUILD:23:12: Compiling Rust bin hello_bevy (0 files) failed: (Exit 1): process_wrapper failed: error executing command (from target //scratch:hello_bevy) bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/rules_rust/util/process_wrapper/process_wrapper --arg-file ... (remaining 312 arguments skipped) error: proc-macro derive panicked --> scratch/hello_bevy.rs:5:10 | 5 | #[derive(Component)] | ^^^^^^^^^ | = help: message: Unable to read cargo manifest: /private/var/tmp/_bazel_photex/135f23dc56826c24d6c3c9f6b688b2fe/execroot/__main__/scratch/Cargo.toml: Os { code: 2, kind: NotFound, message: "No such file or directory" } error: proc-macro derive panicked --> scratch/hello_bevy.rs:8:10 | 8 | #[derive(Component)] | ^^^^^^^^^ | = help: message: Unable to read cargo manifest: /private/var/tmp/_bazel_photex/135f23dc56826c24d6c3c9f6b688b2fe/execroot/__main__/scratch/Cargo.toml: Os { code: 2, kind: NotFound, message: "No such file or directory" } ``` Co-authored-by: Chip Collier <chip.collier@avid.com>
325 lines
12 KiB
Rust
325 lines
12 KiB
Rust
#![allow(clippy::type_complexity)]
|
|
|
|
extern crate proc_macro;
|
|
|
|
mod attrs;
|
|
mod shape;
|
|
mod symbol;
|
|
|
|
pub use attrs::*;
|
|
pub use shape::*;
|
|
pub use symbol::*;
|
|
|
|
use proc_macro::{TokenStream, TokenTree};
|
|
use quote::{quote, quote_spanned};
|
|
use rustc_hash::FxHashSet;
|
|
use std::{env, path::PathBuf};
|
|
use syn::{spanned::Spanned, Ident};
|
|
use toml_edit::{Document, Item};
|
|
|
|
pub struct BevyManifest {
|
|
manifest: Document,
|
|
}
|
|
|
|
impl Default for BevyManifest {
|
|
fn default() -> Self {
|
|
Self {
|
|
manifest: env::var_os("CARGO_MANIFEST_DIR")
|
|
.map(PathBuf::from)
|
|
.map(|mut path| {
|
|
path.push("Cargo.toml");
|
|
if !path.exists() {
|
|
panic!(
|
|
"No Cargo manifest found for crate. Expected: {}",
|
|
path.display()
|
|
);
|
|
}
|
|
let manifest = std::fs::read_to_string(path.clone()).unwrap_or_else(|_| {
|
|
panic!("Unable to read cargo manifest: {}", path.display())
|
|
});
|
|
manifest.parse::<Document>().unwrap_or_else(|_| {
|
|
panic!("Failed to parse cargo manifest: {}", path.display())
|
|
})
|
|
})
|
|
.expect("CARGO_MANIFEST_DIR is not defined."),
|
|
}
|
|
}
|
|
}
|
|
const BEVY: &str = "bevy";
|
|
const BEVY_INTERNAL: &str = "bevy_internal";
|
|
|
|
impl BevyManifest {
|
|
pub fn maybe_get_path(&self, name: &str) -> Option<syn::Path> {
|
|
fn dep_package(dep: &Item) -> Option<&str> {
|
|
if dep.as_str().is_some() {
|
|
None
|
|
} else {
|
|
dep.get("package").map(|name| name.as_str().unwrap())
|
|
}
|
|
}
|
|
|
|
let find_in_deps = |deps: &Item| -> Option<syn::Path> {
|
|
let package = if let Some(dep) = deps.get(name) {
|
|
return Some(Self::parse_str(dep_package(dep).unwrap_or(name)));
|
|
} else if let Some(dep) = deps.get(BEVY) {
|
|
dep_package(dep).unwrap_or(BEVY)
|
|
} else if let Some(dep) = deps.get(BEVY_INTERNAL) {
|
|
dep_package(dep).unwrap_or(BEVY_INTERNAL)
|
|
} else {
|
|
return None;
|
|
};
|
|
|
|
let mut path = Self::parse_str::<syn::Path>(package);
|
|
if let Some(module) = name.strip_prefix("bevy_") {
|
|
path.segments.push(Self::parse_str(module));
|
|
}
|
|
Some(path)
|
|
};
|
|
|
|
let deps = self.manifest.get("dependencies");
|
|
let deps_dev = self.manifest.get("dev-dependencies");
|
|
|
|
deps.and_then(find_in_deps)
|
|
.or_else(|| deps_dev.and_then(find_in_deps))
|
|
}
|
|
|
|
/// Returns the path for the crate with the given name.
|
|
///
|
|
/// This is a convenience method for constructing a [manifest] and
|
|
/// calling the [`get_path`] method.
|
|
///
|
|
/// This method should only be used where you just need the path and can't
|
|
/// cache the [manifest]. If caching is possible, it's recommended to create
|
|
/// the [manifest] yourself and use the [`get_path`] method.
|
|
///
|
|
/// [`get_path`]: Self::get_path
|
|
/// [manifest]: Self
|
|
pub fn get_path_direct(name: &str) -> syn::Path {
|
|
Self::default().get_path(name)
|
|
}
|
|
|
|
pub fn get_path(&self, name: &str) -> syn::Path {
|
|
self.maybe_get_path(name)
|
|
.unwrap_or_else(|| Self::parse_str(name))
|
|
}
|
|
|
|
pub fn parse_str<T: syn::parse::Parse>(path: &str) -> T {
|
|
syn::parse(path.parse::<TokenStream>().unwrap()).unwrap()
|
|
}
|
|
|
|
pub fn get_subcrate(&self, subcrate: &str) -> Option<syn::Path> {
|
|
self.maybe_get_path(BEVY)
|
|
.map(|bevy_path| {
|
|
let mut segments = bevy_path.segments;
|
|
segments.push(BevyManifest::parse_str(subcrate));
|
|
syn::Path {
|
|
leading_colon: None,
|
|
segments,
|
|
}
|
|
})
|
|
.or_else(|| self.maybe_get_path(&format!("bevy_{subcrate}")))
|
|
}
|
|
}
|
|
|
|
/// Finds an identifier that will not conflict with the specified set of tokens.
|
|
/// If the identifier is present in `haystack`, extra characters will be added
|
|
/// to it until it no longer conflicts with anything.
|
|
///
|
|
/// Note that the returned identifier can still conflict in niche cases,
|
|
/// such as if an identifier in `haystack` is hidden behind an un-expanded macro.
|
|
pub fn ensure_no_collision(value: Ident, haystack: TokenStream) -> Ident {
|
|
// Collect all the identifiers in `haystack` into a set.
|
|
let idents = {
|
|
// List of token streams that will be visited in future loop iterations.
|
|
let mut unvisited = vec![haystack];
|
|
// Identifiers we have found while searching tokens.
|
|
let mut found = FxHashSet::default();
|
|
while let Some(tokens) = unvisited.pop() {
|
|
for t in tokens {
|
|
match t {
|
|
// Collect any identifiers we encounter.
|
|
TokenTree::Ident(ident) => {
|
|
found.insert(ident.to_string());
|
|
}
|
|
// Queue up nested token streams to be visited in a future loop iteration.
|
|
TokenTree::Group(g) => unvisited.push(g.stream()),
|
|
TokenTree::Punct(_) | TokenTree::Literal(_) => {}
|
|
}
|
|
}
|
|
}
|
|
|
|
found
|
|
};
|
|
|
|
let span = value.span();
|
|
|
|
// If there's a collision, add more characters to the identifier
|
|
// until it doesn't collide with anything anymore.
|
|
let mut value = value.to_string();
|
|
while idents.contains(&value) {
|
|
value.push('X');
|
|
}
|
|
|
|
Ident::new(&value, span)
|
|
}
|
|
|
|
/// Derive a label trait
|
|
///
|
|
/// # Args
|
|
///
|
|
/// - `input`: The [`syn::DeriveInput`] for struct that is deriving the label trait
|
|
/// - `trait_path`: The path [`syn::Path`] to the label trait
|
|
pub fn derive_boxed_label(input: syn::DeriveInput, trait_path: &syn::Path) -> TokenStream {
|
|
let bevy_utils_path = BevyManifest::default().get_path("bevy_utils");
|
|
|
|
let ident = input.ident;
|
|
let (impl_generics, ty_generics, where_clause) = input.generics.split_for_impl();
|
|
let mut where_clause = where_clause.cloned().unwrap_or_else(|| syn::WhereClause {
|
|
where_token: Default::default(),
|
|
predicates: Default::default(),
|
|
});
|
|
where_clause.predicates.push(
|
|
syn::parse2(quote! {
|
|
Self: 'static + Send + Sync + Clone + Eq + ::std::fmt::Debug + ::std::hash::Hash
|
|
})
|
|
.unwrap(),
|
|
);
|
|
|
|
(quote! {
|
|
impl #impl_generics #trait_path for #ident #ty_generics #where_clause {
|
|
fn dyn_clone(&self) -> std::boxed::Box<dyn #trait_path> {
|
|
std::boxed::Box::new(std::clone::Clone::clone(self))
|
|
}
|
|
|
|
fn as_dyn_eq(&self) -> &dyn #bevy_utils_path::label::DynEq {
|
|
self
|
|
}
|
|
|
|
fn dyn_hash(&self, mut state: &mut dyn ::std::hash::Hasher) {
|
|
let ty_id = #trait_path::inner_type_id(self);
|
|
::std::hash::Hash::hash(&ty_id, &mut state);
|
|
::std::hash::Hash::hash(self, &mut state);
|
|
}
|
|
}
|
|
|
|
impl #impl_generics ::std::convert::AsRef<dyn #trait_path> for #ident #ty_generics #where_clause {
|
|
fn as_ref(&self) -> &dyn #trait_path {
|
|
self
|
|
}
|
|
}
|
|
})
|
|
.into()
|
|
}
|
|
|
|
/// Derive a label trait
|
|
///
|
|
/// # Args
|
|
///
|
|
/// - `input`: The [`syn::DeriveInput`] for struct that is deriving the label trait
|
|
/// - `trait_path`: The path [`syn::Path`] to the label trait
|
|
pub fn derive_label(
|
|
input: syn::DeriveInput,
|
|
trait_path: &syn::Path,
|
|
attr_name: &str,
|
|
) -> TokenStream {
|
|
// return true if the variant specified is an `ignore_fields` attribute
|
|
fn is_ignore(attr: &syn::Attribute, attr_name: &str) -> bool {
|
|
if attr.path().get_ident().as_ref().unwrap() != &attr_name {
|
|
return false;
|
|
}
|
|
|
|
syn::custom_keyword!(ignore_fields);
|
|
attr.parse_args_with(|input: syn::parse::ParseStream| {
|
|
let ignore = input.parse::<Option<ignore_fields>>()?.is_some();
|
|
Ok(ignore)
|
|
})
|
|
.unwrap()
|
|
}
|
|
|
|
let ident = input.ident.clone();
|
|
|
|
let (impl_generics, ty_generics, where_clause) = input.generics.split_for_impl();
|
|
let mut where_clause = where_clause.cloned().unwrap_or_else(|| syn::WhereClause {
|
|
where_token: Default::default(),
|
|
predicates: Default::default(),
|
|
});
|
|
where_clause
|
|
.predicates
|
|
.push(syn::parse2(quote! { Self: 'static }).unwrap());
|
|
|
|
let as_str = match input.data {
|
|
syn::Data::Struct(d) => {
|
|
// see if the user tried to ignore fields incorrectly
|
|
if let Some(attr) = d
|
|
.fields
|
|
.iter()
|
|
.flat_map(|f| &f.attrs)
|
|
.find(|a| is_ignore(a, attr_name))
|
|
{
|
|
let err_msg = format!("`#[{attr_name}(ignore_fields)]` cannot be applied to fields individually: add it to the struct declaration");
|
|
return quote_spanned! {
|
|
attr.span() => compile_error!(#err_msg);
|
|
}
|
|
.into();
|
|
}
|
|
// Structs must either be fieldless, or explicitly ignore the fields.
|
|
let ignore_fields = input.attrs.iter().any(|a| is_ignore(a, attr_name));
|
|
if matches!(d.fields, syn::Fields::Unit) || ignore_fields {
|
|
let lit = ident.to_string();
|
|
quote! { #lit }
|
|
} else {
|
|
let err_msg = format!("Labels cannot contain data, unless explicitly ignored with `#[{attr_name}(ignore_fields)]`");
|
|
return quote_spanned! {
|
|
d.fields.span() => compile_error!(#err_msg);
|
|
}
|
|
.into();
|
|
}
|
|
}
|
|
syn::Data::Enum(d) => {
|
|
// check if the user put #[label(ignore_fields)] in the wrong place
|
|
if let Some(attr) = input.attrs.iter().find(|a| is_ignore(a, attr_name)) {
|
|
let err_msg = format!("`#[{attr_name}(ignore_fields)]` can only be applied to enum variants or struct declarations");
|
|
return quote_spanned! {
|
|
attr.span() => compile_error!(#err_msg);
|
|
}
|
|
.into();
|
|
}
|
|
let arms = d.variants.iter().map(|v| {
|
|
// Variants must either be fieldless, or explicitly ignore the fields.
|
|
let ignore_fields = v.attrs.iter().any(|a| is_ignore(a, attr_name));
|
|
if matches!(v.fields, syn::Fields::Unit) | ignore_fields {
|
|
let mut path = syn::Path::from(ident.clone());
|
|
path.segments.push(v.ident.clone().into());
|
|
let lit = format!("{ident}::{}", v.ident.clone());
|
|
quote! { #path { .. } => #lit }
|
|
} else {
|
|
let err_msg = format!("Label variants cannot contain data, unless explicitly ignored with `#[{attr_name}(ignore_fields)]`");
|
|
quote_spanned! {
|
|
v.fields.span() => _ => { compile_error!(#err_msg); }
|
|
}
|
|
}
|
|
});
|
|
quote! {
|
|
match self {
|
|
#(#arms),*
|
|
}
|
|
}
|
|
}
|
|
syn::Data::Union(_) => {
|
|
return quote_spanned! {
|
|
input.span() => compile_error!("Unions cannot be used as labels.");
|
|
}
|
|
.into();
|
|
}
|
|
};
|
|
|
|
(quote! {
|
|
impl #impl_generics #trait_path for #ident #ty_generics #where_clause {
|
|
fn as_str(&self) -> &'static str {
|
|
#as_str
|
|
}
|
|
}
|
|
})
|
|
.into()
|
|
}
|