bevy/crates/bevy_ecs/src/event
Zachary Harrold 0403948aa2
Remove Implicit std Prelude from no_std Crates (#17086)
# Background

In `no_std` compatible crates, there is often an `std` feature which
will allow access to the standard library. Currently, with the `std`
feature _enabled_, the
[`std::prelude`](https://doc.rust-lang.org/std/prelude/index.html) is
implicitly imported in all modules. With the feature _disabled_, instead
the [`core::prelude`](https://doc.rust-lang.org/core/prelude/index.html)
is implicitly imported. This creates a subtle and pervasive issue where
`alloc` items _may_ be implicitly included (if `std` is enabled), or
must be explicitly included (if `std` is not enabled).

# Objective

- Make the implicit imports for `no_std` crates consistent regardless of
what features are/not enabled.

## Solution

- Replace the `cfg_attr` "double negative" `no_std` attribute with
conditional compilation to _include_ `std` as an external crate.
```rust
// Before
#![cfg_attr(not(feature = "std"), no_std)]

// After
#![no_std]

#[cfg(feature = "std")]
extern crate std;
```
- Fix imports that are currently broken but are only now visible with
the above fix.

## Testing

- CI

## Notes

I had previously used the "double negative" version of `no_std` based on
general consensus that it was "cleaner" within the Rust embedded
community. However, this implicit prelude issue likely was considered
when forming this consensus. I believe the reason why is the items most
affected by this issue are provided by the `alloc` crate, which is
rarely used within embedded but extensively used within Bevy.
2025-01-03 01:58:43 +00:00
..
base.rs Rename track_change_detection flag to track_location (#17075) 2025-01-01 18:43:47 +00:00
collections.rs Rename track_change_detection flag to track_location (#17075) 2025-01-01 18:43:47 +00:00
event_cursor.rs Remove deprecated ECS items (#16853) 2024-12-17 05:43:05 +00:00
iterators.rs Use -D warnings in all relevant CI (#17011) 2024-12-31 00:15:28 +00:00
mod.rs Remove Implicit std Prelude from no_std Crates (#17086) 2025-01-03 01:58:43 +00:00
mut_iterators.rs Use -D warnings in all relevant CI (#17011) 2024-12-31 00:15:28 +00:00
mutator.rs Simpler lint fixes: makes ci lints work but disables a lint for now (#15376) 2024-09-24 11:42:59 +00:00
reader.rs Simpler lint fixes: makes ci lints work but disables a lint for now (#15376) 2024-09-24 11:42:59 +00:00
registry.rs Add no_std support to bevy_ecs (#16758) 2024-12-17 21:40:36 +00:00
update.rs Add core and alloc over std Lints (#15281) 2024-09-27 00:59:59 +00:00
writer.rs Event source location tracking (#16778) 2024-12-12 18:12:53 +00:00