 6f7d0e5725
			
		
	
	
		6f7d0e5725
		
			
		
	
	
	
	
		
			
			# Objective
Currently text is recomputed unnecessarily on any changes to its color,
which is extremely expensive.
## Solution
Split up `TextStyle` into two separate components `TextFont` and
`TextColor`.
## Testing
I added this system to `many_buttons`:
```rust
fn set_text_colors_changed(mut colors: Query<&mut TextColor>) {
    for mut text_color in colors.iter_mut() {
        text_color.set_changed();
    }
}
```
reports ~4fps on main, ~50fps with this PR.
## Migration Guide
`TextStyle` has been renamed to `TextFont` and its `color` field has
been moved to a separate component named `TextColor` which newtypes
`Color`.
		
	
			
		
			
				
	
	
		
			91 lines
		
	
	
		
			2.7 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			91 lines
		
	
	
		
			2.7 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
| //! Text pipeline benchmark.
 | |
| //!
 | |
| //! Continuously recomputes a large block of text with 100 text spans.
 | |
| 
 | |
| use bevy::{
 | |
|     color::palettes::basic::{BLUE, YELLOW},
 | |
|     diagnostic::{FrameTimeDiagnosticsPlugin, LogDiagnosticsPlugin},
 | |
|     prelude::*,
 | |
|     text::{LineBreak, TextBounds},
 | |
|     window::{PresentMode, WindowResolution},
 | |
|     winit::{UpdateMode, WinitSettings},
 | |
| };
 | |
| 
 | |
| fn main() {
 | |
|     App::new()
 | |
|         .add_plugins((
 | |
|             DefaultPlugins.set(WindowPlugin {
 | |
|                 primary_window: Some(Window {
 | |
|                     present_mode: PresentMode::AutoNoVsync,
 | |
|                     resolution: WindowResolution::new(1920.0, 1080.0)
 | |
|                         .with_scale_factor_override(1.0),
 | |
|                     ..default()
 | |
|                 }),
 | |
|                 ..default()
 | |
|             }),
 | |
|             FrameTimeDiagnosticsPlugin,
 | |
|             LogDiagnosticsPlugin::default(),
 | |
|         ))
 | |
|         .insert_resource(WinitSettings {
 | |
|             focused_mode: UpdateMode::Continuous,
 | |
|             unfocused_mode: UpdateMode::Continuous,
 | |
|         })
 | |
|         .add_systems(Startup, spawn)
 | |
|         .add_systems(Update, update_text_bounds)
 | |
|         .run();
 | |
| }
 | |
| 
 | |
| fn spawn(mut commands: Commands, asset_server: Res<AssetServer>) {
 | |
|     warn!(include_str!("warning_string.txt"));
 | |
| 
 | |
|     commands.spawn(Camera2d);
 | |
| 
 | |
|     let make_spans = |i| {
 | |
|         [
 | |
|             (
 | |
|                 TextSpan("text".repeat(i)),
 | |
|                 TextFont {
 | |
|                     font: asset_server.load("fonts/FiraMono-Medium.ttf"),
 | |
|                     font_size: (4 + i % 10) as f32,
 | |
|                     ..Default::default()
 | |
|                 },
 | |
|                 TextColor(BLUE.into()),
 | |
|             ),
 | |
|             (
 | |
|                 TextSpan("pipeline".repeat(i)),
 | |
|                 TextFont {
 | |
|                     font: asset_server.load("fonts/FiraSans-Bold.ttf"),
 | |
|                     font_size: (4 + i % 11) as f32,
 | |
|                     ..default()
 | |
|                 },
 | |
|                 TextColor(YELLOW.into()),
 | |
|             ),
 | |
|         ]
 | |
|     };
 | |
| 
 | |
|     let spans = (1..50).flat_map(|i| make_spans(i).into_iter());
 | |
| 
 | |
|     commands
 | |
|         .spawn((
 | |
|             Text2d::default(),
 | |
|             TextLayout {
 | |
|                 justify: JustifyText::Center,
 | |
|                 linebreak: LineBreak::AnyCharacter,
 | |
|             },
 | |
|             TextBounds::default(),
 | |
|         ))
 | |
|         .with_children(|p| {
 | |
|             for span in spans {
 | |
|                 p.spawn(span);
 | |
|             }
 | |
|         });
 | |
| }
 | |
| 
 | |
| // changing the bounds of the text will cause a recomputation
 | |
| fn update_text_bounds(time: Res<Time>, mut text_bounds_query: Query<&mut TextBounds>) {
 | |
|     let width = (1. + ops::sin(time.elapsed_seconds())) * 600.0;
 | |
|     for mut text_bounds in text_bounds_query.iter_mut() {
 | |
|         text_bounds.width = Some(width);
 | |
|     }
 | |
| }
 |