f93e5c5622
## Background/motivation The Nintendo 3DS is supported by the tier 3 rust target [armv6k-nintendo-3ds](https://doc.rust-lang.org/rustc/platform-support/armv6k-nintendo-3ds.html#armv6k-nintendo-3ds). Bevy does not officially support the device, but as more of bevy becomes `no_std` compatible, more targets are being partially supported (e.g. GBA - https://github.com/bevyengine/bevy/discussions/10680, https://github.com/bushrat011899/bevy_mod_gba) officially or not. The Nintendo 3DS runs Horizon as its OS which is [unix-based](4d08223c05/compiler/rustc_target/src/spec/targets/armv6k_nintendo_3ds.rs (L34)), and the above target (at least partially) supports rust std. It makes sense that you would want to use it, since the 3DS supports things like filesystem reads and the system clock. ## Problem Unlike standard unix targets, armv6k-nintendo-3ds is not one that can use/build the the `ctrlc` dependency in `bevy_app` which is enabled by the bevy `std` cargo feature. Without the `std` feature flag, scheduled systems panic without providing another way for bevy to tick using the `Instant` type (like you might for a [GBA](72d8bbf47b/src/time.rs (L36))). <details> <summary>Example</summary> ``` Finished `dev` profile [optimized + debuginfo] target(s) in 1m 39s Building smdh: /home/maya/repos/hyperspace-dj/target/armv6k-nintendo-3ds/debug/hyperspace-dj.smdh Building 3dsx: /home/maya/repos/hyperspace-dj/target/armv6k-nintendo-3ds/debug/hyperspace-dj.3dsx Adding RomFS from /home/maya/repos/hyperspace-dj/romfs Running 3dslink Sending hyperspace-dj.3dsx, 7172344 bytes 2777346 sent (38.72%), 233 blocks starting server server active ... hii we'are about the to start the bevy app thread 'main' panicked at /home/maya/repos/bevy/crates/bevy_platform/src/time/fallback.rs:177:13: An elapsed time getter has not been provided to `Instant`. Please use `Instant::set_elapsed(...)` before calling `Instant::now()` note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` </details> ## Solution This PR simply excludes the `ctrlc` dependency and its uses in `bevy_app` for the 3DS target (`horizon`) with an addition to its existing feature flags. After this fix, we can use the `std` feature, and regular scheduled systems no longer panic because of missing `Instant` (system clock) support. ## Testing I compiled and ran a binary with the modified version of bevy, using `no_default_features` and feature flags `default_no_std` and `std` on a physical 3DS (classic) using homebrew and `cargo-3ds`. Toolchain: [armv6k-nintendo-3ds](https://doc.rust-lang.org/rustc/platform-support/armv6k-nintendo-3ds.html#armv6k-nintendo-3ds) (nightly-2025-03-31) Project reference:440fc10184## Considerations It could be that we don't want to add specific exceptions inside bevy to support specific hardware with weird quirks inside general bevy code, but it's not obvious to me what we should use instead of an exception to (pre-existing) target cfg: every change here is merely an addition to a cfg that already checks for both the target family and the `std` flag. It is not clear to me if this PR is exhaustive enough to be considered an adequate solution for the larger goal of partially supporting the 3DS, but it seems to be a step in the right direction because it at least lets trivial App::run setups with scheduled systems work.
108 lines
3.3 KiB
TOML
108 lines
3.3 KiB
TOML
[package]
|
|
name = "bevy_app"
|
|
version = "0.16.0-dev"
|
|
edition = "2024"
|
|
description = "Provides core App functionality for Bevy Engine"
|
|
homepage = "https://bevyengine.org"
|
|
repository = "https://github.com/bevyengine/bevy"
|
|
license = "MIT OR Apache-2.0"
|
|
keywords = ["bevy"]
|
|
|
|
[features]
|
|
default = ["std", "bevy_reflect", "bevy_ecs/default", "error_panic_hook"]
|
|
|
|
# Functionality
|
|
|
|
## Adds runtime reflection support using `bevy_reflect`.
|
|
bevy_reflect = ["dep:bevy_reflect", "bevy_ecs/bevy_reflect"]
|
|
|
|
## Extends reflection support to functions.
|
|
reflect_functions = [
|
|
"bevy_reflect",
|
|
"bevy_reflect/functions",
|
|
"bevy_ecs/reflect_functions",
|
|
]
|
|
|
|
# Debugging Features
|
|
|
|
## Enables `tracing` integration, allowing spans and other metrics to be reported
|
|
## through that framework.
|
|
trace = ["dep:tracing"]
|
|
|
|
## Provides system stepping support, allowing them to be paused, stepped, and
|
|
## other debug operations which can help with diagnosing certain behaviors.
|
|
bevy_debug_stepping = []
|
|
|
|
## Will set the BevyError panic hook, which gives cleaner filtered backtraces when
|
|
## a BevyError is hit.
|
|
error_panic_hook = []
|
|
|
|
# Platform Compatibility
|
|
|
|
## Allows access to the `std` crate. Enabling this feature will prevent compilation
|
|
## on `no_std` targets, but provides access to certain additional features on
|
|
## supported platforms.
|
|
std = [
|
|
"bevy_reflect?/std",
|
|
"bevy_ecs/std",
|
|
"dep:ctrlc",
|
|
"downcast-rs/std",
|
|
"bevy_tasks/std",
|
|
"bevy_platform/std",
|
|
]
|
|
|
|
## `critical-section` provides the building blocks for synchronization primitives
|
|
## on all platforms, including `no_std`.
|
|
critical-section = [
|
|
"bevy_tasks/critical-section",
|
|
"bevy_ecs/critical-section",
|
|
"bevy_platform/critical-section",
|
|
"bevy_reflect?/critical-section",
|
|
]
|
|
|
|
## Enables use of browser APIs.
|
|
## Note this is currently only applicable on `wasm32` architectures.
|
|
web = [
|
|
"bevy_platform/web",
|
|
"bevy_tasks/web",
|
|
"bevy_reflect?/web",
|
|
"dep:wasm-bindgen",
|
|
"dep:web-sys",
|
|
"dep:console_error_panic_hook",
|
|
]
|
|
|
|
[dependencies]
|
|
# bevy
|
|
bevy_derive = { path = "../bevy_derive", version = "0.16.0-dev" }
|
|
bevy_ecs = { path = "../bevy_ecs", version = "0.16.0-dev", default-features = false }
|
|
bevy_reflect = { path = "../bevy_reflect", version = "0.16.0-dev", default-features = false, optional = true }
|
|
bevy_utils = { path = "../bevy_utils", version = "0.16.0-dev", default-features = false }
|
|
bevy_tasks = { path = "../bevy_tasks", version = "0.16.0-dev", default-features = false }
|
|
bevy_platform = { path = "../bevy_platform", version = "0.16.0-dev", default-features = false }
|
|
|
|
# other
|
|
downcast-rs = { version = "2", default-features = false }
|
|
thiserror = { version = "2", default-features = false }
|
|
variadics_please = "1.1"
|
|
tracing = { version = "0.1", default-features = false, optional = true }
|
|
log = { version = "0.4", default-features = false }
|
|
cfg-if = "1.0.0"
|
|
|
|
[target.'cfg(any(all(unix, not(target_os = "horizon")), windows))'.dependencies]
|
|
ctrlc = { version = "3.4.4", optional = true }
|
|
|
|
[target.'cfg(target_arch = "wasm32")'.dependencies]
|
|
wasm-bindgen = { version = "0.2", optional = true }
|
|
web-sys = { version = "0.3", features = ["Window"], optional = true }
|
|
console_error_panic_hook = { version = "0.1.6", optional = true }
|
|
|
|
[dev-dependencies]
|
|
crossbeam-channel = "0.5.0"
|
|
|
|
[lints]
|
|
workspace = true
|
|
|
|
[package.metadata.docs.rs]
|
|
rustdoc-args = ["-Zunstable-options", "--generate-link-to-definition"]
|
|
all-features = true
|