forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bevy_reflect: Remove U32Visitor (#12433)

Browse Source 
# Objective

The `U32Visitor` struct has been unused since its introduction in #6140.
It's made itself known now by causing a recent [CI
failure](https://github.com/bevyengine/bevy/actions/runs/8243333274/job/22543736624).

## Solution

Remove the unused `U32Visitor` struct.

Also removed `PrepassLightsViewFlush` as it was causing a [similar CI
failure](https://github.com/bevyengine/bevy/actions/runs/8243838066/job/22545103746?pr=12433#step:6:269)
on this PR.
This commit is contained in:
Gino Valente 2024-03-11 23:19:29 -07:00 committed by GitHub
parent c7298599ee
commit 4c47e31be6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
crates/bevy_pbr/src/prepass/mod.rs
View File

@ -942,6 +942,3 @@ pub type DrawPrepass<M> = (
SetMaterialBindGroup<M, 2>, SetMaterialBindGroup<M, 2>,
DrawMesh, DrawMesh,
); );
#[derive(Debug, Hash, PartialEq, Eq, Clone, SystemSet)]
struct PrepassLightsViewFlush;

17
crates/bevy_reflect/src/serde/de.rs
View File

@ -240,23 +240,6 @@ impl<'de> Deserialize<'de> for Ident {
} }
} }
struct U32Visitor;
impl<'de> Visitor<'de> for U32Visitor {
type Value = u32;
fn expecting(&self, formatter: &mut Formatter) -> fmt::Result {
formatter.write_str("u32")
}
fn visit_u32<E>(self, v: u32) -> Result<Self::Value, E>
where
E: Error,
{
Ok(v)
}
}
/// A general purpose deserializer for reflected types. /// A general purpose deserializer for reflected types.
/// ///
/// This will return a [`Box<dyn Reflect>`] containing the deserialized data. /// This will return a [`Box<dyn Reflect>`] containing the deserialized data.