9f0c41f26d
# Objective - Fixes #6711 ## Solution - Change the `path` function parameter of `dynamically_load_plugin` and `DynamicPluginExt::load_plugin` to a generic with `AsRef<OsStr>` bound
50 lines
1.7 KiB
Rust
50 lines
1.7 KiB
Rust
use libloading::{Library, Symbol};
|
|
use std::ffi::OsStr;
|
|
use thiserror::Error;
|
|
|
|
use bevy_app::{App, CreatePlugin, Plugin};
|
|
|
|
/// Errors that can occur when loading a dynamic plugin
|
|
#[derive(Debug, Error)]
|
|
pub enum DynamicPluginLoadError {
|
|
#[error("cannot load library for dynamic plugin: {0}")]
|
|
Library(libloading::Error),
|
|
#[error("dynamic library does not contain a valid Bevy dynamic plugin")]
|
|
Plugin(libloading::Error),
|
|
}
|
|
|
|
/// Dynamically links a plugin at the given path. The plugin must export a function with the
|
|
/// [`CreatePlugin`] signature named `_bevy_create_plugin`.
|
|
///
|
|
/// # Safety
|
|
///
|
|
/// The specified plugin must be linked against the exact same libbevy.so as this program.
|
|
/// In addition the `_bevy_create_plugin` symbol must not be manually created, but instead created
|
|
/// by deriving `DynamicPlugin` on a unit struct implementing [`Plugin`].
|
|
pub unsafe fn dynamically_load_plugin<P: AsRef<OsStr>>(
|
|
path: P,
|
|
) -> Result<(Library, Box<dyn Plugin>), DynamicPluginLoadError> {
|
|
let lib = Library::new(path).map_err(DynamicPluginLoadError::Library)?;
|
|
let func: Symbol<CreatePlugin> = lib
|
|
.get(b"_bevy_create_plugin")
|
|
.map_err(DynamicPluginLoadError::Plugin)?;
|
|
let plugin = Box::from_raw(func());
|
|
Ok((lib, plugin))
|
|
}
|
|
|
|
pub trait DynamicPluginExt {
|
|
/// # Safety
|
|
///
|
|
/// Same as [`dynamically_load_plugin`].
|
|
unsafe fn load_plugin<P: AsRef<OsStr>>(&mut self, path: P) -> &mut Self;
|
|
}
|
|
|
|
impl DynamicPluginExt for App {
|
|
unsafe fn load_plugin<P: AsRef<OsStr>>(&mut self, path: P) -> &mut Self {
|
|
let (lib, plugin) = dynamically_load_plugin(path).unwrap();
|
|
std::mem::forget(lib); // Ensure that the library is not automatically unloaded
|
|
plugin.build(self);
|
|
self
|
|
}
|
|
}
|