a7ae0807ac
# Objective - To fix the benches panicking on `main` ## Solution - It appears that systems requiring access to a non-existing `Res` now causes a panic - Some of the benches run systems that access resources that have not been inserted into the world - I have made it so that those resources are inserted into the world ## Testing - I ran all the ecs benches and they all run without panicking Co-authored-by: Oliver Maskery <oliver@wellplayed.games>
52 lines
1.5 KiB
Rust
52 lines
1.5 KiB
Rust
use bevy_ecs::{
|
|
prelude::*,
|
|
system::{DynParamBuilder, DynSystemParam, ParamBuilder},
|
|
};
|
|
use criterion::Criterion;
|
|
|
|
pub fn dyn_param(criterion: &mut Criterion) {
|
|
let mut world = World::new();
|
|
let mut group = criterion.benchmark_group("param/combinator_system");
|
|
|
|
group.warm_up_time(core::time::Duration::from_millis(500));
|
|
group.measurement_time(core::time::Duration::from_secs(3));
|
|
|
|
#[derive(Resource)]
|
|
struct R;
|
|
|
|
world.insert_resource(R);
|
|
|
|
let mut schedule = Schedule::default();
|
|
let system = (
|
|
DynParamBuilder::new::<Res<R>>(ParamBuilder),
|
|
DynParamBuilder::new::<Res<R>>(ParamBuilder),
|
|
DynParamBuilder::new::<Res<R>>(ParamBuilder),
|
|
DynParamBuilder::new::<Res<R>>(ParamBuilder),
|
|
DynParamBuilder::new::<Res<R>>(ParamBuilder),
|
|
DynParamBuilder::new::<Res<R>>(ParamBuilder),
|
|
DynParamBuilder::new::<Res<R>>(ParamBuilder),
|
|
DynParamBuilder::new::<Res<R>>(ParamBuilder),
|
|
)
|
|
.build_state(&mut world)
|
|
.build_system(
|
|
|_: DynSystemParam,
|
|
_: DynSystemParam,
|
|
_: DynSystemParam,
|
|
_: DynSystemParam,
|
|
_: DynSystemParam,
|
|
_: DynSystemParam,
|
|
_: DynSystemParam,
|
|
_: DynSystemParam| {},
|
|
);
|
|
schedule.add_systems(system);
|
|
// run once to initialize systems
|
|
schedule.run(&mut world);
|
|
group.bench_function("8_dyn_params_system", |bencher| {
|
|
bencher.iter(|| {
|
|
schedule.run(&mut world);
|
|
});
|
|
});
|
|
|
|
group.finish();
|
|
}
|