# Objective - Fixes https://github.com/bevyengine/bevy/issues/13155 - fixes https://github.com/bevyengine/bevy/issues/13517 - Supercedes https://github.com/bevyengine/bevy/pull/13381 - Requires https://github.com/DioxusLabs/taffy/pull/661 ## Solution - Taffy has been updated to: - Apply size styles to absolutely positioned children - Pass the node's `Style` through to the measure function - Bevy's image measure function has been updated to make use of this style information ## Notes - This is currently using a git version of Taffy. If this is tested as fixing the issue then we can turn that into a Taffy 0.5 release (this would be the only change between Taffy 0.4 and Taffy 0.5 so upgrading is not expected to be an issue) - This implementation may not be completely correct. I would have preferred to extend Taffy's gentest infrastructure to handle images and used that to nail down the correct behaviour. But I don't have time for that atm so we'll have to iterate on this in future. This PR at least puts that under Bevy's control. ## Testing - I manually tested the game_menu_example (from https://github.com/bevyengine/bevy/issues/13155) - More testing is probably merited --- ## Changelog No changelog should be required as it fixes a regression on `main` that was not present in bevy 0.13. The changelog for "Taffy upgrade" may want to be changed from 0.4 to 0.5 if this change gets merged. --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: François Mockers <francois.mockers@vleue.com>
		
			
				
	
	
		
			51 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			TOML
		
	
	
	
	
	
			
		
		
	
	
			51 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			TOML
		
	
	
	
	
	
[package]
 | 
						|
name = "bevy_ui"
 | 
						|
version = "0.14.0-dev"
 | 
						|
edition = "2021"
 | 
						|
description = "A custom ECS-driven UI framework built specifically for Bevy Engine"
 | 
						|
homepage = "https://bevyengine.org"
 | 
						|
repository = "https://github.com/bevyengine/bevy"
 | 
						|
license = "MIT OR Apache-2.0"
 | 
						|
keywords = ["bevy"]
 | 
						|
 | 
						|
[dependencies]
 | 
						|
# bevy
 | 
						|
bevy_a11y = { path = "../bevy_a11y", version = "0.14.0-dev" }
 | 
						|
bevy_app = { path = "../bevy_app", version = "0.14.0-dev" }
 | 
						|
bevy_asset = { path = "../bevy_asset", version = "0.14.0-dev" }
 | 
						|
bevy_color = { path = "../bevy_color", version = "0.14.0-dev" }
 | 
						|
bevy_core_pipeline = { path = "../bevy_core_pipeline", version = "0.14.0-dev" }
 | 
						|
bevy_derive = { path = "../bevy_derive", version = "0.14.0-dev" }
 | 
						|
bevy_ecs = { path = "../bevy_ecs", version = "0.14.0-dev" }
 | 
						|
bevy_hierarchy = { path = "../bevy_hierarchy", version = "0.14.0-dev" }
 | 
						|
bevy_input = { path = "../bevy_input", version = "0.14.0-dev" }
 | 
						|
bevy_math = { path = "../bevy_math", version = "0.14.0-dev" }
 | 
						|
bevy_reflect = { path = "../bevy_reflect", version = "0.14.0-dev", features = [
 | 
						|
  "bevy",
 | 
						|
] }
 | 
						|
bevy_render = { path = "../bevy_render", version = "0.14.0-dev" }
 | 
						|
bevy_sprite = { path = "../bevy_sprite", version = "0.14.0-dev" }
 | 
						|
bevy_text = { path = "../bevy_text", version = "0.14.0-dev", optional = true }
 | 
						|
bevy_transform = { path = "../bevy_transform", version = "0.14.0-dev" }
 | 
						|
bevy_window = { path = "../bevy_window", version = "0.14.0-dev" }
 | 
						|
bevy_utils = { path = "../bevy_utils", version = "0.14.0-dev" }
 | 
						|
 | 
						|
# other
 | 
						|
taffy = { version = "0.5" }
 | 
						|
serde = { version = "1", features = ["derive"], optional = true }
 | 
						|
bytemuck = { version = "1.5", features = ["derive"] }
 | 
						|
thiserror = "1.0.0"
 | 
						|
nonmax = "0.5"
 | 
						|
smallvec = "1.11"
 | 
						|
 | 
						|
[features]
 | 
						|
serialize = ["serde", "smallvec/serde"]
 | 
						|
 | 
						|
 | 
						|
[lints]
 | 
						|
workspace = true
 | 
						|
 | 
						|
[package.metadata.docs.rs]
 | 
						|
rustdoc-args = ["-Zunstable-options", "--cfg", "docsrs"]
 | 
						|
all-features = true
 |